Skip to content

[Automated] Update aws CLI Options - #5157

Closed
thomhurst wants to merge 1 commit into
mainfrom
automated/update-cli-options-aws
Closed

thomhurst wants to merge 1 commit into
mainfrom
automated/update-cli-options-aws

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Summary

This PR contains automatically generated updates to aws CLI options classes.

The generator scraped the latest CLI help output from the installed tool.

Changes

  • Updated options classes to reflect latest CLI documentation
  • Added new commands if any were detected
  • Updated option types and descriptions

Command coverage

Command coverage report:

  • aws (aws-cli/2.36.46 Python/3.14.6 Linux/6.17.0-1022-azure exe/x86_64.ubuntu.24): 19332 commands, tree f93794b2c00ae699042c1352ec8a5b09781ff6601808106f970f1bb1890110bc
    • Baseline comparison: 18920 commands at aws-cli/2.36.34 Python/3.14.6 Linux/6.17.0-1022-azure exe/x86_64.ubuntu.24 -> 19332 commands at aws-cli/2.36.46 Python/3.14.6 Linux/6.17.0-1022-azure exe/x86_64.ubuntu.24
    • Added: aws accessanalyzer create-analyzer, aws accessanalyzer create-service-linked-analyzer, aws accessanalyzer update-analyzer, aws acm list-certificates, aws agent-registry-control create-registry, aws agent-registry-control update-registry, aws aiops create-investigation-group, aws aiops update-investigation-group, aws appconfig update-experiment-definition, aws appconfig update-extension, aws appflow list-connector-entities, aws appflow reset-connector-metadata-cache, aws application-signals create-service-level-objective, aws application-signals update-service-level-objective, aws apprunner update-service, aws appstream create-fleet, aws appstream create-image-builder, aws appstream update-app-block-builder, aws appstream update-fleet, aws autoscaling create-auto-scaling-group, aws autoscaling put-scaling-policy, aws autoscaling start-instance-refresh, aws autoscaling update-auto-scaling-group, aws b2bi create-transformer, aws b2bi update-transformer, aws backupsearch start-search-job, aws batch cancel-jobs, aws batch create-scheduling-policy, aws batch register-job-definition, aws batch submit-job, aws batch submit-service-job, aws batch terminate-jobs, aws batch terminate-service-jobs, aws batch update-scheduling-policy, aws bedrock create-model-customization-job, aws bedrock create-model-import-job, aws bedrock create-model-invocation-job, aws bedrock-agent create-flow, aws bedrock-agent update-flow, aws bedrock-agent-runtime retrieve, aws bedrock-agent-runtime retrieve-and-generate, aws bedrock-agentcore start-browser-session, aws bedrock-agentcore-control create-agent-runtime, aws bedrock-agentcore-control create-consent-portal, aws bedrock-agentcore-control create-gateway, aws bedrock-agentcore-control create-harness, aws bedrock-agentcore-control create-payment-manager, aws bedrock-agentcore-control create-registry, aws bedrock-agentcore-control delete-consent-portal, aws bedrock-agentcore-control get-consent-portal (+362 more; see manifest)

Verification

  • Solution builds successfully

🤖 Generated with ModularPipelines.OptionsGenerator

@thomhurst thomhurst added automated dependencies Pull requests that update a dependency file labels Sep 16, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-16T01:40:42.257369Z 501bca3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Caution

CodeRabbit couldn't post its review summary.

Error details
Validation Failed: {"resource":"IssueComment","code":"unprocessable","field":"data","message":"Body is too long (maximum is 65536 characters)"} - https://docs.github.com/rest/issues/comments#create-an-issue-comment

@thomhurst

Copy link
Copy Markdown
Owner Author

Closing under generated-output policy: CloudWatch Logs option metavariables become bogus positional Value arguments and incorrectly require optional filters. Source fix tracked in #5158; regeneration will run from latest main after source fixes merge. This PR replaced stale #5155 (and #5148), but is not healthy output for #4367.

@thomhurst thomhurst closed this Sep 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Code Review

This is an autogenerated CLI options PR for aws (aws-cli 2.36.34 → 2.36.46), scoped entirely to src/ModularPipelines.AmazonWebServices/ (Enums, Options, Extensions, Generated manifests) plus the corresponding docs/docs/mp-packages/cli/aws.md reference page. No hand-written or unrelated files are touched.

Checks performed:

  • Confirmed the diff touches only generated (.Generated.cs) files, the two Generated/*.json manifests, and docs — no changes to tools/ModularPipelines.OptionsGenerator/, so this is pure generator output, not a generator-logic change.
  • Verified no PublicAPI.Shipped.txt/PublicAPI.Unshipped.txt files were created or touched, consistent with this package not tracking those baselines.
  • Spot-checked several generated Enum/Options files (e.g. AwsAccessanalyzerCreateAnalyzer*) — well-formed, correctly annotated ([GeneratedCode], [CliOption], [CliSubCommand]), and internally consistent with the matching enum/options pair.
  • Validated both Aws.CommandCoverage.json and Aws.Generation.json parse as valid JSON, and found no zero-byte/truncated generated files or stray merge-conflict markers.
  • Cross-checked the docs table additions against the PR description's "Added" command list — they match, and command coverage is purely additive (18920 → 19332 commands), with no indication of the kind of coverage regression fixed for gcloud in fix(generator): preserve gcloud 585 command coverage #5152.
  • CI is still in progress (claude-review and generated integration (ModularPipelines.AmazonWebServices) both IN_PROGRESS); no failing checks so far. Per repo guidance, pending checks aren't treated as findings here — they should simply be allowed to complete before merge.
  • No prior actionable review feedback to reconcile: the Codex review is still running and CodeRabbit failed to post (comment body exceeded GitHub's size limit), so there's nothing outstanding from either to address.

No correctness, design, or CLAUDE.md-compliance issues found in the generated output.

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

[CliOption("--content-length")]
public int? ContentLength { get; set; }

P2 Badge Preserve 64-bit content lengths

When an Object Lambda response has a content length above Int32.MaxValue, callers cannot represent it with this newly generated int? property, even though AWS declares --content-length as a long. Map AWS long values to C# long? in the generator and regenerate the options.

AGENTS.md reference: AGENTS.md:L34-L34


/// Indicates whether or not the instance should be automatically re- booted before creating the image. Specify one of the following val- ues: o true - The instance is not rebooted before creating the image. This creates crash-consistent snapshots that include only the data that has been written to the volumes at the time the snapshots are created. Buffered data and data in memory that has not yet been written to the volumes is not included in the snapshots. o false - The instance is rebooted before creating the image. This ensures that all buffered data and data in memory is written to the volumes before the snapshots are created. Default: false
/// </summary>
[CliFlag("--reboot", NegatedName = "--no-reboot")]
public bool? Reboot { get; set; }

P2 Badge Align the reboot documentation with the normalized flag

For callers relying on the generated documentation, the polarity here is reversed: the property and primary switch are now Reboot/--reboot, but the summary still says true prevents a reboot and false performs one—the semantics of AWS's original NoReboot field. Following that summary emits the opposite switch and can unexpectedly reboot an instance during image creation; normalize or invert the description when the generator converts a leading --no-* flag.

AGENTS.md reference: AGENTS.md:L34-L34

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@thomhurst

Copy link
Copy Markdown
Owner Author

Source repair is now #5159. All CI runs for this closed branch, including superseded heads, are terminal. Regeneration will follow source merges.

@thomhurst

Copy link
Copy Markdown
Owner Author

Fresh replacement: #5163, generated from main after source fixes #5150 and #5159. AWS CLI 2.36.46 coverage is 19,332 commands with no removals. Provenance matches current main, generation/build succeeded, and integration CI/reviews are in progress. The phantom Value operands and incorrect optional log-filter constraints that closed #5157 are absent. Runtime PR #4367 now uses this complete snapshot and tests both ACL directions. Tracking completion in #5149 and #5158.

@thomhurst

Copy link
Copy Markdown
Owner Author

Replacement generated output is now in #5168, produced from main at 1527863 by run 35058181945. AWS CLI 2.36.46 exposes 19,332 commands with no removals from main's baseline. Generation and solution build passed; provenance matches current main.

Source fixes #5150, #5159, and #5165 are included. The reported SNS attribute-name and single-bullet enum defects are corrected in the fresh snapshot. PR CI and generated-output reviews are still in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant