Skip to content

[Automated] Update aws CLI Options - #5148

Closed
thomhurst wants to merge 1 commit into
mainfrom
automated/update-cli-options-aws
Closed

thomhurst wants to merge 1 commit into
mainfrom
automated/update-cli-options-aws

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Summary

This PR contains automatically generated updates to aws CLI options classes.

The generator scraped the latest CLI help output from the installed tool.

Changes

  • Updated options classes to reflect latest CLI documentation
  • Added new commands if any were detected
  • Updated option types and descriptions

Command coverage

Command coverage report:

  • aws (aws-cli/2.36.45 Python/3.14.6 Linux/6.17.0-1022-azure exe/x86_64.ubuntu.24): 19323 commands, tree 44cb2f3370a3ed33984db0e7c3caeb9682e5001166da65f930862165198e851b
    • Baseline comparison: 18920 commands at aws-cli/2.36.34 Python/3.14.6 Linux/6.17.0-1022-azure exe/x86_64.ubuntu.24 -> 19323 commands at aws-cli/2.36.45 Python/3.14.6 Linux/6.17.0-1022-azure exe/x86_64.ubuntu.24
    • Added: aws accessanalyzer create-analyzer, aws accessanalyzer create-service-linked-analyzer, aws accessanalyzer update-analyzer, aws acm list-certificates, aws agent-registry-control create-registry, aws agent-registry-control update-registry, aws aiops create-investigation-group, aws aiops update-investigation-group, aws appconfig update-experiment-definition, aws appconfig update-extension, aws appflow list-connector-entities, aws appflow reset-connector-metadata-cache, aws application-signals create-service-level-objective, aws application-signals update-service-level-objective, aws apprunner update-service, aws appstream create-fleet, aws appstream create-image-builder, aws appstream update-app-block-builder, aws appstream update-fleet, aws autoscaling create-auto-scaling-group, aws autoscaling put-scaling-policy, aws autoscaling start-instance-refresh, aws autoscaling update-auto-scaling-group, aws b2bi create-transformer, aws b2bi update-transformer, aws backupsearch start-search-job, aws batch cancel-jobs, aws batch create-scheduling-policy, aws batch register-job-definition, aws batch submit-job, aws batch submit-service-job, aws batch terminate-jobs, aws batch terminate-service-jobs, aws batch update-scheduling-policy, aws bedrock create-model-customization-job, aws bedrock create-model-import-job, aws bedrock create-model-invocation-job, aws bedrock-agent create-flow, aws bedrock-agent update-flow, aws bedrock-agent-runtime retrieve, aws bedrock-agent-runtime retrieve-and-generate, aws bedrock-agentcore start-browser-session, aws bedrock-agentcore-control create-agent-runtime, aws bedrock-agentcore-control create-consent-portal, aws bedrock-agentcore-control create-gateway, aws bedrock-agentcore-control create-harness, aws bedrock-agentcore-control create-payment-manager, aws bedrock-agentcore-control create-registry, aws bedrock-agentcore-control delete-consent-portal, aws bedrock-agentcore-control get-consent-portal (+353 more; see manifest)

Verification

  • Solution builds successfully

🤖 Generated with ModularPipelines.OptionsGenerator

@thomhurst
thomhurst force-pushed the automated/update-cli-options-aws branch from 08dbaa1 to dc66e69 Compare September 15, 2026 19:18
@thomhurst thomhurst added automated dependencies Pull requests that update a dependency file labels Sep 15, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T19:27:49.714878Z dc66e69 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown

Too many files changed for review (3000 files, 100 file limit).

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Caution

CodeRabbit couldn't post its review summary.

Error details
Validation Failed: {"resource":"IssueComment","code":"unprocessable","field":"data","message":"Body is too long (maximum is 65536 characters)"} - https://docs.github.com/rest/issues/comments#create-an-issue-comment

@thomhurst

Copy link
Copy Markdown
Owner Author

Replaces closed #5140 after the source fixes reached main. The complete generated AWS source tree is also incorporated unchanged into #4367 at be68326, together with regressions for required scalar/collection arguments and blank JSON input. Generation and the AWS solution build passed; required CI and reviews remain pending.

@github-actions

Copy link
Copy Markdown
Contributor

Review: [Automated] Update aws CLI Options (#5148)

This is a fully automated regeneration of the aws CLI options for ModularPipelines.AmazonWebServices (18,920 → 19,323 commands), consistent with the established ModularPipelines.OptionsGenerator pattern used by prior CLI-options PRs.

Scope check — confirmed via the full file list (24,641 changed files) that every changed path is either:

  • src/ModularPipelines.AmazonWebServices/**/*.Generated.cs, or
  • docs/docs/mp-packages/cli/aws.md

No hand-written source, no PublicAPI.Shipped.txt/PublicAPI.Unshipped.txt (correctly not tracked for this generated CLI package per repo convention), and no files outside the AWS package/docs were touched.

Spot checks — sampled newly added/changed Options and Enums files (e.g. AwsAccessanalyzerCreateAnalyzerOptions.Generated.cs, AwsAccessanalyzerCreateAnalyzerType.Generated.cs) plus the regenerated docs/docs/mp-packages/cli/aws.md. All follow the expected generator conventions: #nullable enable, [GeneratedCode("ModularPipelines.OptionsGenerator", "2.0.0")], [CliSubCommand]/[CliOption] attributes, ArgumentNullException.ThrowIfNull guards, the FromCliInputJson/ForCliSkeleton alternate-input factories, and the IValidatableObject alternate-input validation pattern. Output is well-formed and consistent with previously merged generator output — nothing suggesting a scraper regression.

Process checks — no prior human or bot review left actionable findings to address (Codex's review is still running; Greptile and CodeRabbit both declined due to the file-count/size limits, so there's nothing outstanding from them to reconcile). PR is MERGEABLE with no conflicts. Per repo policy, generated CLI packages are validated through build/tests/command coverage rather than manual diffing of ~24k generated files, which this PR's description documents (command coverage report, "Solution builds successfully" checked).

Note for maintainers (not a blocking finding): at review time the generated integration (ModularPipelines.AmazonWebServices) build/test check was still IN_PROGRESS. Per the repo's PR-maintenance guidance, confirm that check turns green (along with the still-running claude-review check) before merging — pending checks aren't a review failure, just an outstanding gate.

No actionable code issues found in this review.

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

[CliOption("--filter", GroupValues = true)]
public IEnumerable<string>? Filter { get; set; }

P2 Badge Keep the Cognito user filter scalar

The scraped help immediately above describes --filter as one filter string and allows searching on only one attribute, but this change models it as a grouped collection. If a caller supplies multiple elements, command rendering produces --filter first second, so AWS receives extra operands rather than one filter expression. Fix the AWS scraper classification and regenerate this property as string? without GroupValues.

AGENTS.md reference: AGENTS.md:L34-L34


[CliOption("--policy-document", GroupValues = true)]
public IEnumerable<string>? PolicyDocument { get; private init; }

P2 Badge Keep the account policy document as one JSON string

The scraped help identifies --policy-document as a single JSON policy document, but the generated collection plus GroupValues renders multiple supplied elements as separate space-delimited operands after one switch. Callers splitting or composing the document as multiple elements therefore produce an invalid AWS invocation, and callers can no longer pass the documented string directly to the required constructor. Correct the scraper's scalar classification and regenerate.

AGENTS.md reference: AGENTS.md:L34-L34


[CliOption("--app-template-body", GroupValues = true)]
public IEnumerable<string>? AppTemplateBody { get; private init; }

P2 Badge Keep the app template body as one JSON string

The generated documentation states that --app-template-body accepts one JSON string, while this change exposes it as a grouped IEnumerable<string>. When more than one element is supplied, the command builder emits separate operands after the switch instead of a single JSON value, causing the Resilience Hub command to reject or misparse the template. Fix the AWS scraper classification and regenerate the scalar property.

AGENTS.md reference: AGENTS.md:L34-L34

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@thomhurst

Copy link
Copy Markdown
Owner Author

Closing under repository generated-options policy: the scalar/collection classification findings are valid, and the shared output also drops the documented --egress | --ingress boolean alternative. Source fixes and regression coverage are tracked in #5149. A fresh replacement must be generated from main after the source fix lands; this generated PR will not be patched in place.

@thomhurst

Copy link
Copy Markdown
Owner Author

The new --egress | --ingress finding is confirmed. Source fix f3c944e is pushed in #5150, with regression coverage for required, optional, and wrapped synopsis forms. The same source PR fixes scalar-string misclassification found in #5148. All 78 AWS scraper tests and the Release generator build pass.

The generated AWS artifacts in this PR still need replacement after #5150 reaches main and fresh generation succeeds. This finding remains open until that output is incorporated; no generated file has been hand-edited. #5148 was closed under repository policy, with no pending CI remaining. Tracking issue: #5149.

@thomhurst

Copy link
Copy Markdown
Owner Author

Replacement generation completed successfully after the AWS scraper fix in #5150 merged. Fresh replacement: #5155, generated from main by https://github.com/thomhurst/ModularPipelines/actions/runs/35028243480.

The generated solution builds. Command coverage increased from 18,920 to 19,332 commands with no reported removals. Review and PR checks are underway on the replacement.

@thomhurst

Copy link
Copy Markdown
Owner Author

Fresh replacement #5157 was created from current main, then closed after a separate AWS metavariable parsing defect was found. Source repair is tracked in #5158; regeneration will follow the source fix.

@thomhurst

Copy link
Copy Markdown
Owner Author

Fresh replacement: #5163, generated from main after source fixes #5150 and #5159. AWS CLI 2.36.46 coverage is 19,332 commands with no removals. Provenance matches current main, generation/build succeeded, and integration CI/reviews are in progress. The phantom Value operands and incorrect optional log-filter constraints that closed #5157 are absent. Runtime PR #4367 now uses this complete snapshot and tests both ACL directions. Tracking completion in #5149 and #5158.

@thomhurst

Copy link
Copy Markdown
Owner Author

Replacement generated output is now in #5168, produced from main at 1527863 by run 35058181945. AWS CLI 2.36.46 exposes 19,332 commands with no removals from main's baseline. Generation and solution build passed; provenance matches current main.

Source fixes #5150, #5159, and #5165 are included. The reported SNS attribute-name and single-bullet enum defects are corrected in the fresh snapshot. PR CI and generated-output reviews are still in progress.

@thomhurst

Copy link
Copy Markdown
Owner Author

Fresh replacement: #5174, regenerated from main f408d8c after the source fixes. It preserves all 19,332 AWS commands and fixes the secret-metadata finding from #5168. Integration CI and reviews must pass before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant