Repository navigation
Conversation
When the caller exports SHELLOPTS, the command inherited cronic's own -e and -u, so a bash script that reads an unset variable (such as texi2dvi) failed. Running the command in a subshell also keeps the exit and exec builtins from ending cronic before it reports.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue remains from the reviewed changes; normal checks can proceed. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
-
🧪 Generate unit tests (beta)
-
-
- Create a new PR
-
-
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
mernst
changed the title
…ions # Conflicts: # cronic # tests/cronic-test/cronic-test.sh
…for source and eval
|
@coderabbitai review |
✅ Action performedReview finished.
|
Turn off verbose and xtrace for cronic itself, and restore them for the command, so that the report's TRACE OUTPUT is the command's. Discard the traces of cronic's first two commands, so that cronic is silent when the command succeeds. Explain why `$(set +o)` cannot save the caller's options.
1 participant
When the caller exports SHELLOPTS, the wrapped command inherited
cronic's own-eand-u, so a bash script that reads an unset variable failed. For example, Daikon's Rocky Linux CI fails incronic makeinfo --pdfwith:(
texi2dviis a#!/bin/shscript, and/bin/shis bash on Rocky Linux.)cronicnow runs the command with the caller's options. It also does not export its own variables to the command when the caller's exported SHELLOPTS contains allexport.This supersedes #138.