Repository navigation
cronic: run the command with the caller's shell options, and capture all of the subshell's output - #142
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # cronic # tests/cronic-test/cronic-test.sh
…ic's state The BASH_ENV file does not run again for the command, but the command sees the caller's BASH_ENV.
…SHELLOPTS; document that the command sees exported functions
…n trace out of the report when the caller exports xtrace
… an exported SHELLOPTS by its attributes only Co-Authored-By: Claude <[email protected]>
…irecting the whole subshell and turning off `set -u` in it Co-Authored-By: Claude <[email protected]>
mernst
changed the title
set -u from the command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #140.
-a,-e,-u, and-xoptions rather than withcronic's own. When the caller exports SHELLOPTS, a bash script that the command runs no longer inheritscronic'sset -eu. For example, Daikon's Rocky Linux CI fails incronic makeinfo --pdfwith/usr/bin/texi2dvi: line 83: COMSPEC: unbound variable.cronictraces only the command, not itself, so that it does not write to stderr on every run. When the caller exports allexport,cronicdoes not export its own variables to the command.Adds tests for each of these.
This supersedes #135.