Skip to content

Updated the Simulink implementation to work with the current code - #44

Merged
ediget merged 11 commits into
mainfrom
Simulink_fix
Aug 25, 2026
Merged

ediget merged 11 commits into
mainfrom
Simulink_fix

Conversation

@Mads-Elkjaer

Copy link
Copy Markdown
Collaborator

Minor changes have been to the pyhton bindings: removed the PID controller from init.py, since it is also being made in _sdu_controller.cpp which is more updated.

Reshaping of the input to the controllers in simulink have been added, since some of them are sensitive to row vs collum vectors.

@Mads-Elkjaer
Mads-Elkjaer requested a review from Prier May 7, 2026 07:19
@sonarqubecloud

sonarqubecloud Bot commented May 7, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

switch obj.RobotType
case obj.all_robot_types(1)
obj.robot_model = obj.sdu_controllers.models.BreedingBlanketHandlingRobotModel();
obj.robot_model = obj.sdu_controllers.models.ParameterRobotModel("/home/madla/Documents/sdu_controllers/config/models/breeding_blanket_handling_robot.yaml");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it should preferably not point to a specific file on your PC, but use the default through the BreedingBlanketHandlingRobotModel() constructor.

switch obj.RobotType
case obj.all_robot_types(1)
obj.robot_model = obj.sdu_controllers.models.BreedingBlanketHandlingRobotModel();
obj.robot_model = obj.sdu_controllers.models.ParameterRobotModel("/home/madla/Documents/sdu_controllers/config/models/breeding_blanket_handling_robot.yaml");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it should preferably not point to a specific file on your PC, but use the default through the BreedingBlanketHandlingRobotModel() constructor.

ediget added 2 commits August 25, 2026 14:47
…e fullPivHouseholderQr for more numerical stability.

Also added a new example for the Eurofusion robot using the operational space controller while the tilting plate joint is fixed. Here, we also see some of the joints wander a bit off while the end-effector is at the desired position -- that is how it is, when we are using this particular controller.
@sonarqubecloud

Copy link
Copy Markdown

@ediget
ediget merged commit 07ebc56 into main Aug 25, 2026
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants