Repository navigation
Launch unified Connections: remove the beta and the pages it replaced - #105137
Conversation
Re-applies the launch from Expensify#104402's old head, merged with current main. Moves the NetSuite OAuth upgrade hint to the Connections accounting page and points the Zoho Books OAuth pages at Connections, since both landed on main after the launch was written. Signed-off-by: krishna2323 <[email protected]>
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@MelvinBot review |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Signed-off-by: krishna2323 <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ReviewThe PR looks solid overall: typecheck passes, the onboarding strings match each locale's Connections label, and I found no leftover references. Two issues are worth fixing before launch. 1.
2. Admins can no longer turn MCP off
Smaller items (plausible, not verified at runtime)
What I checked
|
…s to Connections A tab left in the params stopped Back from a panel finding the Connections page, so it is read once and cleared. Pages gated on a feature that Connections turns on now redirect there instead of More features, which no longer has those toggles. The "imported from" link opens the Accounting tab like the other accounting links. Signed-off-by: krishna2323 <[email protected]>
…ions-launch # Conflicts: # src/components/Navigation/DebugTabView.tsx # src/components/Search/SearchRouter/useNavigationSuggestions.tsx # src/pages/workspace/WorkspaceInitialPage.tsx # src/pages/workspace/accounting/PolicyAccountingPage.tsx # src/pages/workspace/getWorkspaceMenuItems.ts # tests/unit/PolicyAccountingPageAutoStartFlowTest.tsx # tests/unit/SearchRouterNavigationTest.ts
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safaritest.mov |
|
Back from a panel opened from Rules, Members or Workflows lands on Connections
Expected: You're back on Rules, as on main (Back from the Accounting page returns to Rules). after.movbefore.mov |
situchan
left a comment
There was a problem hiding this comment.
Looks good.
One minor inconsistency issue
Leftover code after the launch, worth cleaning as followup. Not blocker.
@MelvinBot confirm |
Regression check (head
|
|
All 8 items check out against
Related: two more fallbacks to More features in the same file
|
…ions-launch # Conflicts: # src/ROUTES.ts # src/pages/workspace/accounting/useConnectedAccountingIntegration.tsx
…oltip on old URLs Signed-off-by: krishna2323 <[email protected]>
…on Connections Signed-off-by: krishna2323 <[email protected]>
lakchote
left a comment
There was a problem hiding this comment.
Thanks @Krishna2323, looks good now.
|
🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.5.28-4 🚀
|
|
Help site update needed: this PR removes the Draft docs PR: [No QA] Docs updates for E/A#105137 Replace Accounting, HR, and Receipt partners with Connections What the docs PR changes
@Krishna2323, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR view run · no recording available |
|
Hi @Krishna2323. How can we turn off the accounting feature for this test scenario? cc @lakchote @JmillsExpensify @Gonals @situchan
|
|
Deploy Blocker #105711 was identified to be related to this PR. |
|
Deploy Blocker #105713 was identified to be related to this PR. |
|
Deploy Blocker #105722 was identified to be related to this PR. |
|
Deploy Blocker #105734 was identified to be related to this PR. |
|
Deploy Blocker #105786 was identified to be related to this PR |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.5.30-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.5.30-0 🚀
Bundle Size Analysis (Sentry): |
|
Yes, we can remove that test case. It now longer exists. |

Explanation of Change
Launches the Connections page to everyone. This is the launch half of #104402. It was split out so that, if it causes a staging issue, only the launch is reverted and the fixes stay.
unifiedConnectionsbeta. Every workspace now has one Connections page instead of separate Accounting, HR, Recruiting, Receipt partners and MCP pages.Two things landed on main after the launch was written, so they move over here:
Fixed Issues
$ #101509
PROPOSAL:
Tests
/workspaces/<policyID>/accounting,/hr,/receipt-partnersand/mcpdirectly. Verify each one opens Connections.Offline tests
QA Steps
Same as tests.
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
web_chrome.mp4