You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-10] Different page opens when Manage settings button is clicked on More features & Rules #105786
Version Number: 9.5.28-5 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#105137 Email or phone of affected tester (no customers):[email protected] Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
In Step 4 and 8, when Manage settings button is clicked, same page should be opened.
Actual Result:
In Step 4, when Manage settings button is clicked on More features, Connections page opens.
In Step 8, when Manage settings button is clicked on Rules, Sage Intacct settings page opens.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Recommendation: Cherry-pick #105735 to staging. Don't revert #105137. It's the general launch of unified Connections, touches more than 100 files, and other blocker fixes are built on top of it.
Investigation details
Mechanism
Before #105137, a beta check decided where both "Manage settings" buttons went. With the beta off, which covered most users, both opened the old Accounting page. When #105137 removed the beta, it pointed the two buttons at different routes:
Rules > Require fields opens the accounting panel (WORKSPACE_CONNECTIONS_ACCOUNTING): RulesRequireFieldsPage.tsx:225 for Categories and :275 for Tags. RuleCategoriesDisabledEmptyState.tsx and RuleTaxesDisabledEmptyState.tsx got the same change.
The accounting panel shows the settings for whichever integration is connected. Its header is the integration's name (ConnectionsAccountingPage.tsx:84). With Sage Intacct connected, that's the "Sage Intacct settings page" the tester saw.
Regression or new feature?
The issue marks production as "N/A - new feature." For users without the beta, this is still a regression: in production, both buttons opened the same page. The new Connections pages caused the mismatch when they launched to everyone.
After the fix, both buttons open the same page. The starting tab still differs. More features opens the default "All" tab (WorkspaceMoreFeaturesPage/index.tsx:196). Rules opens the "Accounting" tab. If QA wants them identical, pass CONST.TAB.CONNECTIONS.ACCOUNTING as the 6th argument at line 196 too.
Next Steps: Reply with @MelvinBot <your feedback> to refine this analysis.
changed the title [-]Different page opens when Manage settings button is clicked on More features & Rules[/-][+][Due for payment 2026-11-10] Different page opens when Manage settings button is clicked on More features & Rules[/+]on Nov 3, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.30-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-10. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Nov 3, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/c4f8997dd8fa9e1f4a9334c0aee8001cce16a264f53c38a8e7e141739d53cce2
melvin-bot commentedon Nov 3, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #105137
melvin-bot commentedon Nov 3, 2026
@lakchote @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #105137
melvin-bot commentedon Nov 3, 2026
@Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #105137
melvin-bot commentedon Nov 3, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 3, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Nov 3, 2026
Deploy Blocker Analysis
Causing PR: Launch unified Connections: remove the beta and the pages it replaced. This is a frontend bug, and I'm highly confident in the cause.
It's already fixed but not yet on staging. The fix is [CP Staging] fix: restore Connections tab param scoping and the accounting help link. It merged at 15:56 UTC today but isn't in the current deploy checklist. OSBotify says it wasn't deployed because QA is ongoing.
Recommendation: Cherry-pick #105735 to staging. Don't revert #105137. It's the general launch of unified Connections, touches more than 100 files, and other blocker fixes are built on top of it.
Investigation details
Mechanism
Before #105137, a beta check decided where both "Manage settings" buttons went. With the beta off, which covered most users, both opened the old Accounting page. When #105137 removed the beta, it pointed the two buttons at different routes:
WORKSPACE_CONNECTIONS): WorkspaceMoreFeaturesPage/index.tsx:196WORKSPACE_CONNECTIONS_ACCOUNTING): RulesRequireFieldsPage.tsx:225 for Categories and :275 for Tags.RuleCategoriesDisabledEmptyState.tsxandRuleTaxesDisabledEmptyState.tsxgot the same change.The accounting panel shows the settings for whichever integration is connected. Its header is the integration's name (ConnectionsAccountingPage.tsx:84). With Sage Intacct connected, that's the "Sage Intacct settings page" the tester saw.
Regression or new feature?
The issue marks production as "N/A - new feature." For users without the beta, this is still a regression: in production, both buttons opened the same page. The new Connections pages caused the mismatch when they launched to everyone.
The fix in #105735
On
main, all four Rules call sites now go to the Connections page on its Accounting tab: RulesRequireFieldsPage.tsx:225 and :275. The same PR also fixes the other #105137 follow-up blockers: #105713, #105722 and #105690.Optional follow-up
After the fix, both buttons open the same page. The starting tab still differs. More features opens the default "All" tab (WorkspaceMoreFeaturesPage/index.tsx:196). Rules opens the "Accounting" tab. If QA wants them identical, pass
CONST.TAB.CONNECTIONS.ACCOUNTINGas the 6th argument at line 196 too.Next Steps: Reply with
@MelvinBot <your feedback>to refine this analysis.view run
lakchote commentedon Nov 3, 2026
This is fixed by #105735, which was just CP'd to staging. Waiting on QA retest now
IuliiaHerets commentedon Nov 3, 2026
Issue was fixed on Web, Android and iOS, v9.5.28-7. Manage settings CTA from Rules and More features redirects to the Connections page
Recording.225.mp4
Retest.105786.mp4
az_recorder_20261103_121342.mp4
lakchote commentedon Nov 3, 2026
Done
[-]Different page opens when Manage settings button is clicked on More features & Rules[/-][+][Due for payment 2026-11-10] Different page opens when Manage settings button is clicked on More features & Rules[/+]melvin-bot commentedon Nov 3, 2026
@Krishna2323 / @situchan
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.30-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-10. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]