You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-10] Connections - Tooltip does not appear when hovering over truncated sentence #105722
Version Number: 9.5.28-5 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#105137 Email or phone of affected tester (no customers):[email protected] Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Go to staging.new.expensify.com
Go to workspace settings > Connections.
Connect to Sage Intacct with wrong credentials.
Hover over "Cannot sync due to broken..."
Expected Result:
Tooltip will appear when hovering over truncated sentence "Cannot sync due to broken...".
Actual Result:
Tooltip does not appear when hovering over truncated sentence "Cannot sync due to broken...".
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Recommendation: Don't revert #105137. It launches the whole Connections page and touches about 100 files. Fix forward instead. This is a missing piece of a new feature, not a regression, so an internal engineer may want to demote it.
Fix: In ConnectionCard.tsx, show the status text with TextWithTooltip instead of the plain one-line description. You can do this in one of two ways:
Render it inside descriptionAddon after the badge, and remove description and numberOfLinesDescription.
Add a shouldShowDescriptionTooltip prop to MenuItem that wraps the description in TextWithTooltip.
ConnectionCard passes that message as description with numberOfLinesDescription={1}. The "Broken" badge and "Fix" button take up width, so the text gets cut to "Cannot sync due to broken..." (ConnectionCard.tsx#L96-L120).
MenuItem draws the description as plain <Text numberOfLines={...}> with no tooltip, so hovering does nothing (MenuItem.tsx#L697-L705).
TextWithTooltip already measures the text and shows a tooltip only when it overflows. On native it renders plain Text, so mobile won't change.
Why it isn't a regression
In production, the old Accounting page showed the full sync error through errorText, without truncation.
The only tooltip file changed in this deploy is GenericTooltip.tsx. It can't cause this, because the card description is never wrapped in a Tooltip.
Impact: Small. It only affects narrow card layouts on web. The "Broken" badge and "Fix" button still show the state. Clicking the card opens the panel with the full sync error.
Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.
changed the title [-]Connections - Tooltip does not appear when hovering over truncated sentence[/-][+][Due for payment 2026-11-10] Connections - Tooltip does not appear when hovering over truncated sentence[/+]on Nov 3, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.30-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-10. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Nov 3, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/192bcb7da91a36ad03b995d0564ff2d46453aaa452ef9a77cd80628383a55862
melvin-bot commentedon Nov 3, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #105137
melvin-bot commentedon Nov 3, 2026
@lakchote @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #105137
melvin-bot commentedon Nov 3, 2026
@Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #105137
melvin-bot commentedon Nov 3, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 3, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Nov 3, 2026
Deploy Blocker Investigation
Result: The Connections card never had a tooltip for its cut-off status text. Launch unified Connections: remove the beta and the pages it replaced only made the page visible to everyone. The gap came from Consolidate integration to one Connection screen, which built the card behind the
unifiedConnectionsbeta.Recommendation: Don't revert #105137. It launches the whole Connections page and touches about 100 files. Fix forward instead. This is a missing piece of a new feature, not a regression, so an internal engineer may want to demote it.
Fix: In
ConnectionCard.tsx, show the status text withTextWithTooltipinstead of the plain one-linedescription. You can do this in one of two ways:descriptionAddonafter the badge, and removedescriptionandnumberOfLinesDescription.shouldShowDescriptionTooltipprop toMenuItemthat wraps the description inTextWithTooltip.Investigation details
How it happens
ConnectionCardpasses that message asdescriptionwithnumberOfLinesDescription={1}. The "Broken" badge and "Fix" button take up width, so the text gets cut to "Cannot sync due to broken..." (ConnectionCard.tsx#L96-L120).MenuItemdraws the description as plain<Text numberOfLines={...}>with no tooltip, so hovering does nothing (MenuItem.tsx#L697-L705).TextWithTooltipalready measures the text and shows a tooltip only when it overflows. On native it renders plainText, so mobile won't change.Why it isn't a regression
errorText, without truncation.GenericTooltip.tsx. It can't cause this, because the card description is never wrapped in a Tooltip.Impact: Small. It only affects narrow card layouts on web. The "Broken" badge and "Fix" button still show the state. Clicking the card opens the panel with the full sync error.
Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.view run
2 remaining items
lakchote commentedon Nov 3, 2026
@Krishna2323 thanks, I see #105735 covers this one too. Demoting since it's a missing tooltip.
Krishna2323 commentedon Nov 3, 2026
PR is ready for review: #105735
melvin-bot commentedon Nov 3, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Nov 3, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Nov 3, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
IuliiaHerets commentedon Nov 3, 2026
Issue is not repro on Mac 26.6.2 build 9.5.28-7
Retest.Sage.mp4
lakchote commentedon Nov 3, 2026
Done
[-]Connections - Tooltip does not appear when hovering over truncated sentence[/-][+][Due for payment 2026-11-10] Connections - Tooltip does not appear when hovering over truncated sentence[/+]melvin-bot commentedon Nov 3, 2026
@Krishna2323 / @situchan
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.30-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-10. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]