Skip to content

Onboarding - Onboarding task shows "Click Accounting" when there is no Accounting tab #104011

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.9-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #102265
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Other

Action Performed:

Precondition:

  • Enable unifiedConnections beta.
  1. Go to staging.new.expensify.com
  2. Log in with new Gmail account.
  3. Click Skip on work email step.
  4. Select Manage my team's expenses.
  5. Complete onboarding with QBO accounting software.
  6. Go to #admins.
  7. Open Connect to QuickBooks Online task.

Expected Result:

Step 3 in Connect to QuickBooks Online task should be "Click Connections".

Actual Result:

Step 3 in Connect to QuickBooks Online task is "Click Accounting" when there is no Accounting tab.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7286366_1791990355587.5.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7286366

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 14, 2026
  2. melvin-bot commented on Oct 14, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #102265

  3. applause-bot commented on Oct 14, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/a970c3894adee381544c2d124e19fa64404057c8517d0ceedf9b9b075bad21bf

  4. melvin-bot commented on Oct 14, 2026

    @melvin-bot

    @lakchote @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #102265

  5. melvin-bot commented on Oct 14, 2026

    @melvin-bot

    @Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #102265

  6. github-actions commented on Oct 14, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot commented on Oct 14, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. lakchote commented on Oct 14, 2026

    @lakchote
    Contributor

    Behind beta demoting

  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 14, 2026
  10. MelvinBot commented on Oct 14, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Investigation

    Recommendation: Demote and fix in a follow-up. Do not revert. This matches lakchote's "Behind beta demoting" call. DeployBlockerCash is already removed.

    Cause: Consolidate integration to one Connection screen hides the Accounting tab for unifiedConnections beta users and shows Connections instead. It did not update the onboarding task text. That text is hardcoded as "Click Accounting" in src/languages/en.ts:3759.

    Impact: Only the step label is wrong, and only for beta users. The "Take me to accounting" link still works because the PR redirects old Accounting URLs to the Connections page.

    Confidence: High

    Investigation details

    Why not revert: The PR is a large beta-gated feature (about 100 files). The bug affects beta users only and breaks no data, payments, or navigation.

    Suggested follow-up fix:

    1. Pass the beta flag into the onboarding message builder in ReportUtils.ts and OnboardingFlow.ts.
    2. When the beta is on, use "Click Connections" in all 11 language files.
    3. Build the link with the existing getAccountingConnectionsRoute(isUnifiedConnectionsBetaEnabled, policyID) from src/pages/workspace/connections/utils.ts:48-53.

    Caveat: The task text is generated once, when onboarding completes. Existing tasks keep the old wording. If the beta state changes later, the text can become wrong again. Wording that works with or without the beta avoids both problems.


    Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.


    view run

  11. lakchote commented on Oct 19, 2026

    @lakchote
    Contributor

    @Krishna2323 are you picking this up as a follow-up to #102265?

  12. Krishna2323 commented on Oct 20, 2026

    @Krishna2323
    Contributor

    PR is ready for review: #104402

    cc: @situchan @lakchote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions