Skip to content

Chore: Integrate open PRs (2026-11-07) - #505

Merged
b-re-w merged 184 commits into
developfrom
integrate/2026-11-07
Nov 7, 2026
Merged

b-re-w merged 184 commits into
developfrom
integrate/2026-11-07

Conversation

@b-re-w

@b-re-w b-re-w commented Nov 7, 2026

Copy link
Copy Markdown
Member

Integration branch for the open PRs of 2026-11-07 (one branch per repo, owner instruction). The original PRs are still open; the leader closes them after review.

Issues

Closes #98
Closes #100
Closes #101
Closes #105
Closes #401
Closes #404
Closes #409
Closes #476

Refs #483 (stage 1 is #486 plus #503; the other platforms still answer "unavailable"), #278 (FR-39 stack #286, #285, #289, #290 is merged but not built), #4, #66 and #3 (packagers, drafts).

Classification

PR Title Head Base State Mergeable (before) Real CI failures (before) Linked issues Updated Author Class Notes
#503 Feat: macOS file open and save sheets, FR-72 stage 1 (#483) feat/file-dialog-483 develop draft mergeable no real failure (heavy gate only) - 2026-11-07 b-re-w INTEGRATE Second of the pair (it had merged #486 into itself). Carries the fork pin move WINDOW_REVISION -> e3088cc. Part of #483.
#502 Feat: Dismiss open Dialog and Sheet with Escape and restore focus (#476) feat/esc-dismiss-476 develop ready mergeable no real failure (heavy gate only) - 2026-11-07 b-re-w INTEGRATE Closes #476.
#490 Chore: Bump the version to 0.0.7 (draft) feat/release-0-0-7 develop draft mergeable Build and test the renderer (jvm) - 2026-11-07 b-re-w KEEP-OPEN (release prep, not touched) Version bump 0.0.7 draft. Its CHANGELOG v0.0.7 section will conflict with the Unreleased entries now on the integration branch; merge it after the integration PR, moving Unreleased under v0.0.7. Red: renderer (jvm).
#486 Feat: ShowFileDialog and FileDialogResult, common part of FR-72 stage 1 (#483) feat/file-dialog-stage1 develop ready mergeable no real failure (heavy gate only) - 2026-11-06 b-re-w INTEGRATE First of the pair. Fix on the branch: the result filter is now mapped back to the position in the list the Host sent (FileDialogSpec.sentPositions), test fr72_result_filter_is_the_position_in_the_list_the_host_sent. Refs #483.
#480 Chore: Leave macOS jobs of the native renderer test out for other platforms' own files feat/native-skip-macos develop ready mergeable no real failure (heavy gate only) - 2026-11-07 b-re-w INTEGRATE CI-only change.
#466 Feat: Samples build against the released renderer feat/samples-released develop ready conflicting no real failure (heavy gate only) - 2026-11-05 b-re-w INTEGRATE Merged before #276; its resolve/released logic kept, Windows always uses the Kotlin/Native kit.
#463 Publish develop to main release main ready mergeable no real failure (heavy gate only) - 2026-11-07 app/github-actions KEEP-OPEN release -> main sync.
#461 Feat: Send every key to the Host (FR-12.1) feat/all-keys-100 develop ready conflicting Check Rust formatting, lints and tests (ubuntu-latest) - 2026-11-05 b-re-w INTEGRATE Merged after #457 as its body asks. KeyDown grows to 37 bytes. KeyUp now uses the same layout (repeat, code, text) so it stays one payload type. Closes #100.
#457 Feat: OnFocusGained and OnKeyUp node events (FR-45) feat/fr45-focus-keyup-98 develop ready conflicting Build and test the renderer (jvm) - 2026-11-06 b-re-w INTEGRATE Schema tags 48/49 (events) and properties 117/118 kept as allocated. Closes #98.
#452 Feat: Linux drag delivery to the Host (FR-53, #409) feat/fr53-linux-drop-c-cr develop draft conflicting Build and test the renderer (jvm), Check Rust formatting, lints and tests (macos-latest), Generated files are current, Run the shell script tests (macos-latest), Run the shell script tests (ubuntu-latest) - 2026-11-05 b-re-w INTEGRATE Closes #409. CI was red on its own head (rust fmt/tests macOS, generated files, shell tests, jvm); not yet understood, see the PR for fixes made on the integration branch.
#451 Feat: Linux per-window zoom (FR-53, #404) feat/fr53-linux-zoom-c-cr develop draft mergeable Run the shell script tests (macos-latest) - 2026-11-05 b-re-w INTEGRATE Closes #404.
#450 Feat: Linux per-window color scheme (FR-53, #401) feat/fr53-linux-color-c-cr develop draft mergeable Build and test the renderer (android), Check Rust formatting, lints and tests (macos-latest) - 2026-11-05 b-re-w INTEGRATE Closes #401.
#449 Feat: Linux live size hints (needs fork PR #179 pin first) (FR-53, #407) feat/fr53-linux-live-size-c-cr develop draft mergeable no real failure (heavy gate only) - 2026-11-05 b-re-w NEEDS-DECISION (not integrated, leave open) Blocked on fork PR #179 (still OPEN, no merge commit): its Linux X11 hint test cannot pass on the current pin e3088cc. Integrate after the fork PR merges and the pin moves. It was merged once and taken out again before pushing.
#368 Test: Measure hand-check with the resize synchronization on in the probe matrix (#364) feat/resize-sync-kn feat/resize-sync-spike ready mergeable no real failure (heavy gate only) - 2026-11-05 b-re-w KEEP-OPEN (parked by owner) Windows live-resize spike, parked for the owner's 26H2 hardware test.
#367 Chore: Pin the window modules to the backport with the opt-in resize synchronization (#364) spike/resize-sync-measure develop ready conflicting no real failure (heavy gate only) - 2026-11-05 b-re-w KEEP-OPEN (parked by owner) Windows live-resize spike, parked for the owner's 26H2 hardware test.
#366 Docs: Add the optional resize synchronization mode to FR-19.8, record D23 (#364) feat/resize-sync-spec feat/resize-probe-discrimination ready mergeable no real failure (heavy gate only) - 2026-10-26 b-re-w KEEP-OPEN (decision needed) FR-19.8 resize-sync spec; stacked on #354 (base feat/resize-probe-discrimination). Not on the parked list, but part of the same spike chain, so left alone.
#365 Test: Prove the private Windows resize synchronization with a late window (spike, #364) feat/resize-sync-spike feat/resize-probe-discrimination ready mergeable no real failure (heavy gate only) - 2026-11-05 b-re-w KEEP-OPEN (parked by owner) Windows live-resize spike, parked for the owner's 26H2 hardware test.
#354 Test: Make the Windows resize probe tell late frames from prompt ones, per Windows build feat/resize-probe-discrimination develop ready mergeable no real failure (heavy gate only) - 2026-11-05 b-re-w KEEP-OPEN (parked by owner) Windows live-resize spike, parked for the owner's 26H2 hardware test.
#290 Feat: Report call macro errors at the offending argument (#278) feat/fr39-call-macro-spans develop ready conflicting Run the shell script tests (macos-latest), Run the shell script tests (ubuntu-latest) - 2026-10-25 b-re-w INTEGRATE Stack: #286 -> #289 -> #290. Merged in that order.
#289 Feat: Generate a call macro for every composable (#278) feat/fr39-call-macros develop ready conflicting no real failure (heavy gate only) - 2026-10-25 b-re-w INTEGRATE Stack: #286 -> #289 -> #290.
#286 Refactor: Rename #[composable] to #[Composable] (#278) feat/composable-attribute-name develop ready conflicting no real failure (heavy gate only) - 2026-10-25 b-re-w INTEGRATE Stack head. Develop had gained tests using #[composable]; renamed to #[Composable] in a separate Fix commit. Stray tracked file compose-rust/tests/pointer_events.rs-E (a sed backup on develop) still says #[composable]; it is not compiled.
#285 Feat: Make state handles Copy with an arena and generations (#278) feat/fr39-copy-state develop ready conflicting Build the sample (Android) - 2026-10-25 b-re-w INTEGRATE Copy state handles. WindowAmbient (added on develop after the PR) now releases its arena state on drop and keeps it out of any open remember capture. Known risk from the PR body: mutable_state_of needs T: Send; develop code added since may still .clone() states.
#276 Feat: Sample release packaging (.app/.dmg, AppImage, .zip/.msix) feat/sample-release-packaging develop draft conflicting Build a sample here, package and certify it, Build the sample (Android), Flatpak builds and updates, Generated files are current, Packager tests, Packager tests (ubuntu-latest), Packager tests (windows-latest) - 2026-10-25 b-re-w INTEGRATE Carries #114, #115, #116 (merged first). Its test-samples.yml was combined by hand with #466 and the develop version (Windows: windows-static kit only, GraalVM and fork-desktop jobs and Windows Maven cache steps dropped).
#274 Feat: Transform3D, CSS 3D transforms (FR-41.3, FR-41.5 Draft) feat/fr41-3-3d-transform develop ready conflicting Build and test the renderer (jvm) - 2026-10-25 b-re-w INTEGRATE Modifier tag 27 was free (develop jumped 26 -> 31), so no renumbering. Closes #105.
#270 Refactor: Share one span style function and a side-table copy helper feat/span-style-helper develop ready conflicting no real failure (heavy gate only) - 2026-10-25 b-re-w INTEGRATE Develop had meanwhile changed the span style inline (font chains, background); spanStyle now takes the resolved family instead of the font list.
#268 Refactor: Use the Win32 window from the fork's graalvm-windows module (#163, #69) feat/win32-window-from-fork develop draft conflicting Build and smoke test the GraalVM renderer (Linux, arm64), Build and smoke test the GraalVM renderer (Linux, x64), Build and smoke test the GraalVM renderer (macOS, arm64), Build and test the renderer (jvm), Run the shell script tests (macos-latest), Run the shell script tests (ubuntu-latest) - 2026-10-25 b-re-w CLOSE-STALE (branch kept) GraalVM Win32 window refactor, draft, waits for fork PR #161 (OPEN). Windows ships only the Kotlin/Native static renderer now (SPEC NFR-14, #333, #465, #276), so the GraalVM Windows window has no consumer.
#263 Fix: A focused box receives its own key events (#101) feat/key-handler-before-focusable develop ready conflicting no real failure (heavy gate only) - 2026-10-25 b-re-w INTEGRATE Closes #101. Key handlers go ahead of the node modifiers, now with key-up handlers and the focus target for Box/Column/Row/FileDropTarget.
#170 Win32 live resize: present the new size before the window rect changes feat/win32-resize-sync feat/win-linux-window-default draft mergeable Build and smoke test the GraalVM renderer (Linux, arm64), Build and smoke test the GraalVM renderer (Linux, x64), Build and smoke test the GraalVM renderer (macOS, arm64) - 2026-10-25 b-re-w CLOSE-STALE (branch kept) Win32 live resize on the GraalVM window, base feat/win-linux-window-default. Superseded by the Kotlin/Native Windows path; the live-resize work continues in the parked #354 chain.
#155 Feat: Share the desktop window logic between the GraalVM and Kotlin/Native paths, with parity checks feat/shared-window-logic develop ready conflicting no real failure (heavy gate only) - 2026-10-25 b-re-w CLOSE-STALE (branch kept) Shared window logic between the GraalVM and Kotlin/Native windows, parity checks. GraalVM desktop windows are no longer shipped (NFR-14, 2026-10-24 SPEC).
#135 Refactor: Take the Java toolkit off the shipped renderer path feat/remove-awt-shipped-path develop ready conflicting Build and smoke test the GraalVM renderer (macOS, arm64) - 2026-10-25 b-re-w CLOSE-STALE (branch kept) Take AWT off the shipped path; develop already ships AWT-free K/N renderers (#113, #119, #174; devshell split is on develop).
#134 Feat: Open the Win32 toolkit-free window by default, finish the X11 one feat/win-linux-window-default develop ready conflicting no real failure (heavy gate only) - 2026-10-25 b-re-w CLOSE-STALE (branch kept) Toolkit-free Win32/X11 windows by default; same reason as #135.
#118 Feat: Tell the Compose fork's window that the renderer draws its own caption (FR-19.8) feature/window-chrome-to-fork develop draft conflicting no real failure (heavy gate only) - 2026-10-25 b-re-w CLOSE-STALE (branch kept) Tells the fork window the renderer draws its own caption on the GraalVM path; Windows captions were reworked on develop (#340, #341, #468) and Windows is K/N static only.
#117 Feat: Samples drawn in their references' colours (FR-22.5) feature/samples-complete develop draft conflicting Build the sample (Android) - 2026-10-25 b-re-w CLOSE-STALE (branch kept) Draft whose own body says it predates the API rewrite (#85), is 224+ commits behind, conflicts in the samples; all samples were migrated by the #278 chain. Palette fixes (FR-22.5) would have to be ported by hand: leader may prefer NEEDS-DECISION.
#116 Feat: Windows packager, DPI manifest and WACK findings (FR-35) feature/packager-windows develop draft mergeable no real failure (heavy gate only) - 2026-10-25 b-re-w INTEGRATE Draft "not ready to merge" by its own body (MSIX/Store #3 incomplete), but self-contained under scripts/packager-windows and merges cleanly. Cargo.lock merged per package.
#115 Feat: macOS ad hoc signing and update rehearsal (FR-35) feature/packager-macos develop draft mergeable no real failure (heavy gate only) - 2026-10-25 b-re-w INTEGRATE Draft; macOS packager, self-contained, merges cleanly.
#114 Feat: Linux packager and sample release to samples-latest (#66) feature/packager-linux develop draft mergeable no real failure (heavy gate only) - 2026-10-25 b-re-w INTEGRATE Draft; Linux packager (scripts/packager-linux, packager-linux.yml). Cargo.lock merged per package.
#84 Feat: Direct Kotlin to Rust calls on the web through a generated trampoline (#54) feat/web-direct-call develop ready conflicting no real failure (heavy gate only) - 2026-10-25 b-re-w NEEDS-DECISION (not integrated, leave open) Web direct trampoline: its body says the generated files (boundary_wasm.gen.rs, HostBridge.gen.kt, two compose-rust-host.gen.mjs) must be regenerated with cargo run --bin codegen, and codegen.rs conflicts heavily with develop. Needs a builder; the integration PR's "Generated files are current" artifact can supply the regenerated files once the code merges.

Conflicts and how they were resolved

Generated files that may be stale

No cargo or gradle was run. These are stale or hand merged and are checked by the "Generated files are current" job, which uploads the regenerated copies as an artifact: compose-rust/schema-hash.txt, compose-rust/tests/vectors/vectors.json (hash line), compose-rust/tests/vectors/events.bin and mutations.bin, renderer/desktop/src/protocol/Protocol.gen.kt and its Android mirror (SCHEMA_HASH, KeyUp/FileDialogResult/Transform3D parts merged by hand), compose-rust/src/boundary_wasm.gen.rs, renderer/web/src/bridge/HostBridge.gen.kt and the web compose-rust-host.gen.mjs files (untouched, may need the new events), Cargo.lock (merged by script).

v0.0.7 items

All present after this PR: #455, #473 and #479 (via #489), #458, GutterBar (#477), Windows K/N static (#465, #333), #467 and #468, #476 and #502, #480.

Not integrated

#449 (fork PR #179 open), #84 (needs codegen run), #268, #170, #155, #135, #134, #118, #117 (stale, branches kept), #490 and #463 (release PRs), #354, #365, #366, #367, #368 (parked). The classification of each is in the table below and is not final: the leader decides.

b-re-w added 30 commits October 3, 2026 08:22
… app metadata

dioxus-compose-msix stages a package directory from one executable (or a
directory with the renderer beside it): AppxManifest.xml for a full-trust
desktop application, the four tile and logo images drawn from the app icon,
and a four-part version mapped from Cargo.toml (revision 0 for the Store,
a growing build number for App Installer). Identity, publisher, name and
description come from Dioxus.toml, with [windows.msix] holding the values
Partner Center assigns. On Windows it packs .msix and .msixbundle with
MakeAppx and can write an App Installer update feed.

Tests are named for the proposed update packaging requirement, which is
still a draft.
The workflow builds the packager and a small windowed stand-in, packages it
with the notepad sample's metadata, signs it with a throwaway certificate,
installs it, and runs the Windows App Certification Kit against the package
and the bundle, uploading both reports. A second job publishes two builds to
an App Installer feed on a file share and checks that the installed package
sees and takes the update. A dispatch can package a real build from another
run's artifact instead of the stand-in.
…nifest

The certification kit reads DPI awareness from the embedded manifest and
warned that the stand-in was not DPI aware. The build script shows the two
linker arguments an application uses to embed the same manifest.
The file share the feed named was not reachable on the runner
(0x80070003), so the update test now serves the feed and bundles from a
local HTTP server.
Resolved by the Windows package workflow, which runs the packager's
build; nothing else in the lock file moved.
dioxus_compose::update says how the running application was delivered
(AppImage, Flatpak or neither), reads the AppImage's update information
from its .upd_info ELF section, and checks for, applies and restarts into
an update through the appimageupdatetool the packager places inside the
AppImage. A Flatpak is reported as store-managed and never offered an
update.

Covers the self-update criteria of the draft packaging requirement
(provisionally FR-34, Linux part).
packager-linux reads dx's [application], [bundle] and [linux] tables plus
a [linux.store] table for what store listings need, and writes the
desktop entry, AppStream metainfo, hicolor icons, an AppDir carrying
appimageupdatetool, AppImage update information (gh-releases-zsync or
zsync) and a flatpak-builder manifest (prebuilt archive or an offline
build from source with vendored crates).

The demo crate is the small program the packaging workflow builds in two
versions to show each channel updating an installed build.

Covers the metadata criteria of the draft packaging requirement
(provisionally FR-34, Linux part).
appimage.sh fetches pinned appimagetool, runtime and appimageupdatetool,
assembles the AppDir and writes the AppImage with its .zsync. flatpak.sh
vendors crates with a pinned flatpak-cargo-generator, writes the manifest,
and builds and lints it with Flathub's org.flatpak.Builder.

The workflow shows an AppImage 1.0.0 updating itself to 1.0.1 from
.zsync files served by nginx on the runner, refuses a 1.0.2 signed by
another key, updates an installed Flatpak with flatpak update, and starts
the released calculator sample from both packages.
A workflow that is only dispatchable cannot be dispatched from a branch
until it reaches the default branch.
Windows fetches the bundle a feed names in byte ranges and refused
Python's plain server (0x80D05011).
tools/packager/package-macos makes Name.app from the executable cargo built,
with Info.plist taken from the project's Cargo.toml and Dioxus.toml, and signs,
wraps and publishes it for one of two channels:

- sparkle: hardened runtime, no sandbox, Sparkle.framework inside, SUFeedURL and
  SUPublicEDKey in Info.plist; zip archive, notarytool submission and stapling,
  and an appcast whose EdDSA signature is checked against the key the
  application carries before it is written.
- app-store: sandboxed with only the declared capabilities, export compliance
  answered, no Sparkle anywhere (framework, SU keys, or a host binary that names
  it), and the productbuild package App Store Connect takes.

Signing goes inside out without --deep. Ed25519 is implemented after RFC 8032
so keys need no keychain and Linux can sign; signatures are identical to
Sparkle's sign_update, which is preferred when given.

Covers the draft acceptance criteria 1 to 9 of the proposed FR-34
(update and store packaging, macOS part), which is not yet in the SPEC.
dioxus-compose-update loads Sparkle.framework from the bundle's
Contents/Frameworks at run time and creates SPUStandardUpdaterController on the
main thread through objc2, where the renderer's C entry runs [NSApp run]. The
application calls start() before launch and check_for_updates() from a menu
item or button. Install::Immediately supplies an updater delegate that installs
a silently downloaded update at once and relaunches.

The Host rather than the Renderer, because Sparkle is Objective-C and the Rust
side reaches it directly, while the native-image Renderer would need
hand-written glue; nothing crosses the boundary. Sparkle is not linked, so the
crate builds anywhere and is a no-op off macOS. A Mac App Store build leaves the
dependency out, and the packager refuses a store bundle that names Sparkle.

Covers draft criterion 10 of the proposed FR-34.
experiments/self-update builds a small dioxus-compose application at 1.0.0 and
2.0.0 against the published crate (so the released renderer is fetched, not
built), packages both for the sparkle channel signed ad hoc, serves an appcast
from 127.0.0.1, and waits for the installed 1.0.0 to replace itself with 2.0.0:
once installing immediately and relaunching, once installing on quit. It then
builds the same application without the updater for the app-store channel,
makes the .pkg, checks nothing of Sparkle is in it, and runs it sandboxed.

The macOS packaging workflow runs the packager tests on macOS and Linux, the
updater crate's tests and lints, and the rehearsal, uploading its evidence.

Covers draft criterion 11 of the proposed FR-34.
A Flathub build runs cargo with --locked and no network, so the lock file
has to name every crate before the build does.
…et 26.08

The freedesktop SDK has readelf but not patchelf, so a manifest that has
to point the executable at the renderer beside it now builds patchelf in
a module whose files are cleaned out of the application. The renderer's
lib/ directory is flattened beside the executable, the layout it finds
its companions from. The default runtime branch is 26.08, the newest on
Flathub.

flatpak.sh hands flatpak-builder an absolute manifest path, the demo no
longer names a screenshot that does not exist (appimagetool fails on the
validator's warning), and the AppImage job also runs on aarch64.
The sample release's Linux rows wrap every staged sample with
tools/packager-linux/appimage.sh, embedding gh-releases-zsync update
information for this repository and publishing the .zsync beside the
AppImage. They are signed when APPIMAGE_SIGNING_KEY is set and the run
warns when it is not. A sample that cannot be wrapped keeps its archive.

Not run here: this workflow builds the renderer and publishes a release,
so it is verified at the next sample tag. The script it calls is the one
packager-linux.yml exercises on x86_64 and aarch64.
…d-in

The package job now runs twice: once on the stand-in and once on a real
build (the notepad archive from a published sample release, or a run's
artifact when dispatched with a run id), packaged as a directory with the
renderer and its companion files beside the program. Builds use the
committed lock file.
make-sample-icons.py renders the same marks at every size in SIZES. The
64 pixel icon.png every sample embeds for its window is byte for byte
what it was; icon-256.png is new, because Flathub refuses icons under
128 pixels and an upscaled 64 pixel one looks it. The sample release's
AppImages carry both.
The released calculator sample names libdioxus_compose_renderer.so with
no RUNPATH, so inside the AppImage it exited with status 127. AppRun now
puts the payload directory on LD_LIBRARY_PATH, and a Flatpak built from
a prebuilt archive sets the rpath to $ORIGIN with patchelf when the
executable has none.

Also: prebuilt and renderer archives can be given once per architecture
(only-arches), so one manifest serves x86_64 and aarch64 as Flathub
builds both; --app-id overrides the identifier for a listing under
another ID; and the tests are named after FR-35, the packaging
requirement's number (FR-34 belongs to another draft).
org.flatpak.Builder reaches the host's flatpak through the session bus,
which a runner does not have, so installing build dependencies failed.
Every builder call now runs under dbus-run-session.

The workflow generates the Flathub submission for a placeholder ID,
lints it and uploads it; FLATHUB.md is the checklist for submitting it
under the real ID.
The released notepad sample fails the kit's optional Blocked executables
test (the renderer DLL references CreateProcessW, and ICU data matches
blocked names), which leaves the overall result at WARNING. The script
annotated it as an error while passing the step. It now reports optional
failures as warnings, lists them in the summary, and fails the step on any
required failure.
From the command line the kit inspects a full-trust package without
launching it, which the script's description claimed it did.
The first published dioxus-compose links the renderer as @rpath/... and adds no
rpath to the application, so the packager cannot find the renderer from the
executable. --renderer-dir names it; without it the packager says so instead of
building a bundle with no renderer. The rehearsal application turns on the
published crate's native-renderer feature (off by default in 0.0.0) and the
script fetches and checks the released renderer it needs.
The update packaging requirement is FR-35, not FR-34.
…-35)

The certification kit reads DPI awareness from the executable's embedded
manifest and reported every application as not DPI aware, because the
renderer only declares it at run time. The crate's build script now writes
the manifest as a compiled resource file and names it as a native library,
which, unlike a linker argument, reaches the final link of every program
that depends on the crate; the MSVC linker recognises it as a resource by
its contents. The manifest declares PerMonitorV2, the awareness the renderer
asks for, and asInvoker.

On by default through the windows-manifest feature. An application that
embeds its own manifest leaves the feature out, since two manifest
resources fail the link.
@b-re-w b-re-w added the run-heavy-ci Run the heavy CI workflows on this pull request's head label Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-heavy-ci Run the heavy CI workflows on this pull request's head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant