Repository navigation
Conversation
The native-image renderer opened the AppKit window of its own only when DXC_APPKIT_WINDOW was set. macOS now always opens it, and the older arrangement of a second thread for the toolkit is gone from the C entry. The window takes what the application asks for in its first batch: title, size, minimum size, resizable, system or transparent title bar with a unified toolbar so the traffic lights share the bar's line, the icon, and a material behind the page. Files dropped on a FileDropTarget reach the node under them without the toolkit, with the full path list read outside the 96 byte event record. Pointer and accessibility coordinates are converted between points and pixels. The smoke test's auto exit is honoured. Covers FR-27 (file drop) and NFR-14. fr27_* tests in NativeFileDropTest and scripts/tests/macos-window-default.test.sh. Korean IME, VoiceOver and resize feel remain manual checks on a Mac.
… (NFR-14) An unattended macOS runner refuses TransformProcessType, and the window can still be made once the activation policy is set to regular. The refusal is reported instead of stopping the renderer.
A process told it has no display is given no clipboard by Compose desktop, so copy and paste in a text field went nowhere. The window now supplies the clipboard from its own pasteboard. The icon is passed as premultiplied RGBA bytes so that every desktop can read the same record.
Windows: minimum size, resizable, icon, clipboard, OLE file drop with enter and leave, the caption strip taken into the client area in the window's own procedure (moved from the shim, which no longer subclasses the toolkit's frame), drawn buttons through window actions, and the caret position for the IME candidate window. Linux: CLIPBOARD and PRIMARY selections, text commit events, XIM preedit and commit (callbacks style, falling back to the plain styles and to the plain lookup), XDND file drop, _NET_WM_ICON, minimum size and non-resizable hints, undecorated chrome with a drawn caption and edges that hand the move and resize to the window manager through _NET_WM_MOVERESIZE, display scale from Xft.dpi or GDK_SCALE, and bring to front from a notification press without the toolkit. macOS shares the shell and gains the IME spot. RendererEntryPoints no longer falls back to the toolkit's window on any desktop. AT-SPI is not included; it is built on the Kotlin/Native window in #131. Covers NFR-14 and FR-19 (windows chrome), FR-27 (file drop). scripts/tests/native-window-default.test.sh replaces the macOS only test.
The toolkit window and everything only it used (chrome, icon, resize edges, file drop, transparency, the JVM dev entry points) move to renderer/desktop/src/devshell. The shipped sources get AWT-free replacements for what they still needed: the divider's resize icon, the dropped path join, the Windows caption height. The input method and accessibility reachability features go, with the force-loaded toolkit archive and its accessibility roots on macOS, the look and feel and Metal layer registrations, and the CI step that checked the toolkit's accessibility classes. scripts/tests/no-awt-on-shipped-path.test.sh fails for a toolkit import in the shipped sources and for toolkit classes in the metadata that are not on awt-forced.txt, the list of what Compose forces (ClipEntry, PointerIcon constants, libawt loading), filed against the fork as thisisthepy/compose-multiplatform-core-extended#15. Covers NFR-14.
…debounce (FR-5) TextChanged was held back 120 ms after the last keystroke and restarted by every key, so a line echoing the typed text trailed the key by the pause plus a frame or two, and by the whole burst when typing was fast. Measured on the AppKit window with real key events posted to it: 152 ms from key to the echo being on screen, and the Host heard nothing during a burst. The first edit after a quiet period is now sent immediately, later ones are collapsed to at most one per interval carrying the latest text, and the last one is always sent. Covers the FR-5 criterion that the Host is notified of edits through a debounced TextChanged: bursts still collapse. Adds a test that a request for a frame is served by the next turn of the loop.
… not stretched (NFR-14) AppKit stays in its own tracking loop while an edge is dragged and only calls the view back, so the renderer's frame loop did not run: the layer's drawable size changed and the last frame was shown scaled to it. Measured with a scripted resize of 120 sizes: 0 frames presented and 120 sizes shown stretched. setFrameSize now sets the drawable size and asks the renderer for a frame at that size through the draw callback the Windows window already uses, a live resize presents with the window's transaction, and the layer anchors a stale drawable to its corner instead of scaling it. Same scripted resize after: 120 presented, 0 stale, 0 stretched, 6.1 ms per size on average. Also adds the aids used to measure it: DXC_REPORT_LATENCY timestamps from key to pixels, DXC_REPORT_RESIZE counts, DXC_SYNTH=type,keys,resize to drive the window from inside, and DXC_LEGACY_RESIZE to see the old behaviour. The counting is in appkit_resize.h and is tested without a window by scripts/tests/appkit-live-resize.test.sh.
…ed (NFR-14) The X11 window code stays, reached by DXC_X11_WINDOW. Windows and macOS are unchanged. The Linux default flips in a separate change with the Docker and hardware check results.
…that is still the default (NFR-14)
…FR-14) Unmapped keys answered 0, which is the A key, so control with C, V and X arrived as control with A and selected everything. Letters and digits are mapped to the shared board, the Windows virtual key table gains the same, XDND drops report where the last position said the files were, and a shell test reads the X11 table.
…rkPyonix/compose-rust into feat/remove-awt-shipped-path
A window with a click counter, two text fields echoed on screen (so shortcuts, paste and undo are visible), the window size class, and a 60 row list with Korean rows. It is its own workspace root so plain cargo run works on every desktop, and it reads the renderer from COMPOSE_RUST_RENDERER_DIR. Prints event: lines.
…rkPyonix/compose-rust into feat/remove-awt-shipped-path
… feat/win-linux-window-default # Conflicts: # renderer/desktop/c/x11_window.c # renderer/desktop/src/AppKitWindow.kt
…nto feat/remove-awt-shipped-path # Conflicts: # renderer/desktop/src/AccessibilityReachabilityFeature.kt
… frame is not stretched (NFR-14) The scaling field was left at its zero value from memset, which is DXGI_SCALING_STRETCH. An ordinary resize never shows it, because the buffer is refitted and redrawn at the new size before it is presented, but a frame the resize handler skips (a refit refused, or dragging starting before the swapchain exists) leaves DXGI filling the new client area by stretching the old buffer instead of showing it at its own size.
… 120 ms throttle (FR-5) Typing in a field was held back by a 120 ms interval between notifications. An edit is now told to the Host on the next frame, carrying the text the field holds then, so keys inside one frame are one event and the last text is always sent. No measured reason for 120 ms was recorded anywhere in the repository.
… feat/win-linux-window-default
… feat/win-linux-window-default
…nto feat/remove-awt-shipped-path # Conflicts: # .github/workflows/test-native-renderer.yml
…ves to the fork Restores the macOS arm64, Linux x64 and Linux arm64 native-image build and smoke jobs that #113 removed, in their own path-filtered workflow. Windows stays in test-native-renderer.yml.
Resuming from withFrameNanos goes back through the scene's dispatcher, so the send and the recomposition after it each cost a frame. Sent in the callback, the Host's batch is applied before the same frame is composed. Measured on macOS: key to on-screen echo 26 ms to 12.7 ms.
… feat/win-linux-window-default
… feat/win-linux-window-default
…nto feat/remove-awt-shipped-path
This was referenced Oct 4, 2026
b-re-w
added a commit
that referenced
this pull request
Oct 17, 2026
…nd test that the shipped path names none Carried from #135 (cd05bc8): renderer/desktop/src/devshell holds what runs only on a JVM with the toolkit's window, and the build-time tooling that served it: Renderer.kt, WindowChrome.kt, WindowIcon.kt, WindowResize.kt, HostFileDrop.kt, ToolkitResizeCursor.kt, WindowTransparency.kt, the input method and accessibility reachability features, ReachabilityRegistration.kt and MetadataCollectionMain.kt. Packages are unchanged; only the folder moves. no-awt-on-shipped-path.test.sh fails when a source outside it names the toolkit (NativeClipboard.kt may name java.awt.datatransfer), when the shared metadata registers a toolkit class, or when a native image build asks for the toolkit's features, metadata or java.desktop module.
Member
Author
|
Handoff (2026-10-25): Branch: feat/remove-awt-shipped-path. State: open; GraalVM smoke test fails on macOS arm64. Closes #133. Next: needs owner/leader triage. Blocked on: owner/leader triage. |
Member
Author
|
Closed during the 2026-11-07 branch consolidation (integrated via #505 or superseded). Branch kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split (macOS part moved to #173). The macOS part of this change is in #173, which targets develop on its own: no force-loaded toolkit archive or accessibility roots in the macOS image, no input method or accessibility reachability features there, an own resize icon on macOS, and a test scoped to macOS (
no-awt-on-macos-path.test.sh). This PR keeps the Windows remainder (and the Linux part, which waits for #160): the move of toolkit window sources todevshell/, the reachability metadata andawt-forced.txt, the Windows and Linux build script changes, andno-awt-on-shipped-path.test.sh. After #173 merges, rebase-free merge develop in here; the macOS hunks will already be on develop.Closes #133
Stacked on #134 and #128, so the diff includes their commits until they merge.
renderer/desktop/src/devshell(JVM dev shell only). Shipped sources keep AWT-free replacements (resize icon, path join, Windows caption height).scripts/tests/no-awt-on-shipped-path.test.sh: fails for a java.awt, javax.swing, sun.awt import on the shipped path (one documented exception:NativeClipboard.kt, Compose'sClipEntryis a java.awt.datatransfer type) and for metadata entries not inrenderer/desktop/awt-forced.txt.Remaining AWT, and why:
awt-forced.txt(103 names) stays because Compose desktop creates a java.awt.Cursor when PointerIcon.Hand/Text/Crosshair/Default is first read, which loads libawt; libawt's JNI_OnLoad needs those classes in the JNI tables, and the Linux and Windows builds keep-H:Preserve=module=java.desktop. Also libawt/libjawt static linking,kotlinx-coroutines-swingin module.yaml (dev shell windows need it), andjava.awt.headless=true. The fork changes are in thisisthepy/compose-multiplatform-core-extended#15.Needs CI proof on all three desktops: a native image without the force-loaded toolkit archive on macOS has not been built before.
Note: after the Linux hold in #134, Linux still reaches the dev shell window until its default flips, so the shipped path is toolkit free on macOS and Windows and, on Linux, from the flip on.