Skip to content

Feat: Tell the Compose fork's window that the renderer draws its own caption (FR-19.8) - #118

Closed
b-re-w wants to merge 2 commits into
developfrom
feature/window-chrome-to-fork
Closed

b-re-w wants to merge 2 commits into
developfrom
feature/window-chrome-to-fork

Conversation

@b-re-w

@b-re-w b-re-w commented Oct 4, 2026

Copy link
Copy Markdown
Member

What it holds

ForkWindowChrome adapter and its test, wired in Renderer.kt.

Ahead of develop by 2 commits.

What is unfinished

Behind develop by 86 commits; depends on the fork carrying the matching change; not built here.

Linked issue

Part of #26

Notes

This branch has not been merged with develop and may conflict. It is opened as a draft only so the unmerged design is kept as a PR; it is not ready to merge.

b-re-w added 2 commits October 3, 2026 17:22
… caption (FR-19.8)

The fork's ComposeWindow on Windows now takes the caption strip, holds a live
resize for its frame and, by default, draws a band with three buttons there
(thisisthepy/compose-multiplatform-core-extended, feature/windows-window-chrome).
This renderer draws that strip itself: its bar takes the caption and the
design system draws the buttons. Before any window exists it sets
compose.windows.caption to "content" (the strip without the band, the content
told its height as insets), or "system" for Chrome::System, unless the
property was given on the command line.

Nothing reads the property until the renderer builds against the fork's
desktop artifacts; JetBrains' Compose ignores it, and renderer_entry.c,
WindowChrome.kt and the rest keep doing this work until the fork is pinned
and FR-19.8's checks pass on its sample. Then the copy here goes, and the
same property keeps the two from drawing two sets of buttons on one window.

ForkWindowChromeTest covers the mapping and that a property already set is
left alone.
…ome-to-fork

# Conflicts:
#	renderer/desktop/src/ForkWindowChrome.kt
#	renderer/desktop/test/ForkWindowChromeTest.kt
@b-re-w

b-re-w commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

Handoff (2026-10-25): Branch: feature/window-chrome-to-fork. State: draft; no failing checks in the rollup. Next: needs owner/leader triage. Blocked on: owner/leader triage.

@b-re-w

b-re-w commented Nov 7, 2026

Copy link
Copy Markdown
Member Author

Closed during the 2026-11-07 branch consolidation (integrated via #505 or superseded). Branch kept.

@b-re-w b-re-w closed this Nov 7, 2026
@b-re-w
b-re-w deleted the feature/window-chrome-to-fork branch November 12, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant