Repository navigation
Conversation
… caption (FR-19.8) The fork's ComposeWindow on Windows now takes the caption strip, holds a live resize for its frame and, by default, draws a band with three buttons there (thisisthepy/compose-multiplatform-core-extended, feature/windows-window-chrome). This renderer draws that strip itself: its bar takes the caption and the design system draws the buttons. Before any window exists it sets compose.windows.caption to "content" (the strip without the band, the content told its height as insets), or "system" for Chrome::System, unless the property was given on the command line. Nothing reads the property until the renderer builds against the fork's desktop artifacts; JetBrains' Compose ignores it, and renderer_entry.c, WindowChrome.kt and the rest keep doing this work until the fork is pinned and FR-19.8's checks pass on its sample. Then the copy here goes, and the same property keeps the two from drawing two sets of buttons on one window. ForkWindowChromeTest covers the mapping and that a property already set is left alone.
…ome-to-fork # Conflicts: # renderer/desktop/src/ForkWindowChrome.kt # renderer/desktop/test/ForkWindowChromeTest.kt
Member
Author
|
Handoff (2026-10-25): Branch: feature/window-chrome-to-fork. State: draft; no failing checks in the rollup. Next: needs owner/leader triage. Blocked on: owner/leader triage. |
Member
Author
|
Closed during the 2026-11-07 branch consolidation (integrated via #505 or superseded). Branch kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it holds
ForkWindowChrome adapter and its test, wired in Renderer.kt.
Ahead of develop by 2 commits.
What is unfinished
Behind develop by 86 commits; depends on the fork carrying the matching change; not built here.
Linked issue
Part of #26
Notes
This branch has not been merged with develop and may conflict. It is opened as a draft only so the unmerged design is kept as a PR; it is not ready to merge.