Repository navigation
Conversation
…#163), time K/N frames by clock (#69) The native image's Win32 window (externs, Win32GraalWindow, Win32Frames, event drain, describeTo, draw upcall) is now the fork's graalvm-windows module. Win32Window.kt keeps the scene and Host wiring. Frame time comes from the window's FrameClock on the monotonic clock instead of nanos += 16 ms; the Kotlin/Native Windows scene gets the same FrameClock. Win32FrameTest and Win32AccessibilityTest moved with the code.
This was referenced Oct 24, 2026
Member
Author
|
Handoff (2026-10-25): Branch: feat/win32-window-from-fork. State: draft; GraalVM smoke (Linux arm64, Linux x64, macOS arm64), jvm build, shell tests (macOS and Ubuntu) and Heavy checks are red. Next: after fork PR #161 merges, repin, then fix the shell tests and the smoke failures. Blocked on: fork PR #161 merge and repin. |
Member
Author
|
Closed during the 2026-11-07 branch consolidation (integrated via #505 or superseded). Branch kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 1 (Win32) of #163, and the fix for #69. Draft: it depends on the fork PR thisisthepy/compose-multiplatform-core-extended#161 and on a pin bump.
What
renderer/desktop/src/Win32Window.ktkeeps only the glue:runWin32Window, the scene,drawFrameanddrawRasterFrame. Everything else moved to the fork's newgraalvm-windowsmodule (the@CFunctionexterns,Win32GraalWindow,Win32Frames,RasterTarget, the event drain,describeTo, the draw upcall).Win32DrawCallback.java,Win32FrameTest,Win32AccessibilityTest(they moved to the fork).native-image.propertiesandbuild-native-windows.ps1initializeorg.thisisthepy.compose.window.graalvm.windows.Win32DrawCallbackat build time.renderer/desktop/module.yamlandrenderer/scripts/publish-window.shgaingraalvm-windows.AppKitWindow.ktimportsWin32Framesfrom the fork, because the macOS loop shares that door.win32-window-layout,win32-renderer-parity,desktop-c-symbols.Win32ImeKeyTeststays:win32ComposeKeyreturns a ComposeKeyand the fork module names no Compose type.Frame time (#69)
The window's
frameTimeNanos()(aFrameClockonmonotonicNanos) replacesnanos += FRAME_NANOSin the native image path. The same fix is applied inrenderer/windows/src/Win32Window.kt, because the Kotlin/Native Windows scene stays in compose-rust until a later stage. No fixed 16 ms step remains.TODO before this can merge
WINDOW_REVISIONinrenderer/scripts/build-compose.sh) moves after the fork PR merges, in a separate pin-bump PR. Until then the three retargeted shell tests read the old pinned fork, which has nograalvm-windows, so they fail here. Run against the fork branch with the fetch stubbed,win32-window-layoutandwin32-renderer-paritypass;desktop-c-symbolspasses for Linux and Windows (its macOS result differs with a newer fork than the pin, independent of this change).renderer/scripts/compose-fork.changesis part of the pin bump and is not touched here.Needs a Windows build to verify
Nothing here was built (no Amper, Gradle, cargo or native-image).
graalvm-windowsand the native image links (dxc_win32_draw_frameentry point, initialize-at-build-time of the moved class).