Repository navigation
Conversation
…nd drop the AWT shims (NFR-14) The macOS native image links the static skiko from the fork's extended/skiko build, made with --no-jawt, and Skia's own archives, so nothing of the toolkit is linked or shipped for Skia's sake: the AWT force-load, the Objective-C accessibility class roots and the libjawt and libawt_lwawt forwarders are gone. The foreign-entry-point stubs are generated from a first link. image-has-no-awt.test.sh scans the linked image for AWT libraries and symbols. accessibility-link.test.sh is retired with the toolkit archive it checked; the window's own accessibility is appkit_window.m's. Linux still ships the toolkit's libraries and is not changed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #165. Links the fork's extended/skiko static archive built with --no-jawt plus Skia's archives into the macOS GraalVM image, drops the AWT force-load, the accessibility class roots and the libjawt and libawt_lwawt forwarders, generates the foreign-entry-point stubs from a first link, and adds image-has-no-awt.test.sh (otool/nm scan of the linked image) to the GraalVM workflow.
Expected to stay red until the toolkit stops being reached on the shipped path: #135 (the Java toolkit off the shipped renderer path) and fork pointer icons (core-extended #15), since the Cursor path loads libawt. Linux is not changed: its default window is still the toolkit one and its build ships libawt*.so. Never built locally; CI is the first run.