Repository navigation
Refactor: Take the Java toolkit off the macOS renderer path (NFR-14) - #173
Merged
Merged
Conversation
The macOS native image stops force-loading libawt_lwawt.a, rooting its accessibility classes and registering the toolkit's input method and accessibility features: the AppKit window does both itself. The divider's resize pointer is an icon of our own on macOS. Windows and Linux keep the toolkit window and its sources until their own windows are the default (#134, #160). scripts/tests/no-awt-on-macos-path.test.sh covers the macOS build script and the sources outside the toolkit-window list. Part of NFR-14, split from #135.
b-re-w
added a commit
that referenced
this pull request
Oct 26, 2026
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #133, split out of #135 so macOS lands without waiting for #134 (Windows).
libawt_lwawt.a, roots its accessibility classes or registersImeReachabilityFeatureandAccessibilityReachabilityFeature. The AppKit window does text input and accessibility itself.ToolkitResizeCursor.ktfor the windows that are still the toolkit's.accessibility-linkcheck and its CI step go, since the classes it checked are no longer linked.scripts/tests/no-awt-on-macos-path.test.shchecks the macOS build script and every source outside an explicit toolkit-window list.Not in this PR: Linux is on the toolkit window until #160 (X11 default) merges, so the Linux part waits for it. Windows waits for #134. The shared reachability metadata,
awt-forced.txt, the move of toolkit window sources todevshell/and the Linux/Windows build script changes stay in #135, because Linux and Windows still need them.Needs CI proof: a macOS native image without the force-loaded toolkit archive has not been built before.