Repository navigation
Recover stage doors, fences, room assignment, and trigger contacts - #334
Closed
matthewlewisnewton wants to merge 73 commits into
Closed
matthewlewisnewton wants to merge 73 commits into
matthewlewisnewton wants to merge 73 commits into
Conversation
✅ CI passed ·
|
| Check | Result |
|---|---|
| Build + DOL SHA-1 | ✅ |
No regressions (report_delta --check) |
✅ |
| Linked units still link | ✅ |
| Metric | Base | PR | Δ |
|---|---|---|---|
| Matched data (bytes) | 1,758,510 | 1,758,510 | 0 |
| Complete data (bytes) | 1,758,510 | 1,758,510 | 0 |
| Matched code (bytes) | 4,353,092 | 4,353,092 | 0 |
| Complete code (bytes) | 4,353,092 | 4,353,092 | 0 |
| Matched functions | 27,572 | 27,572 | 0 |
| Linked units | 2,449 | 2,448 | -1 |
0 new exact functions, 0 function regressions, 158 renamed functions.
matthewlewisnewton
marked this pull request as draft
November 20, 2026 17:02
matthewlewisnewton
marked this pull request as ready for review
November 20, 2026 17:13
Owner
|
can you get the codex coauthor out of the commit history please. |
matthewlewisnewton
force-pushed
the
recover-stage-doors-fences-and-contacts
branch
from
November 20, 2026 22:38
aa70392 to
9f03861
Compare
Owner
|
fine with ai use just dont want bots as commit authors, but owned to who commits. |
Owner
|
should be merged with other pr. reopen if issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this series recovers
This stage-object series reconstructs more of the C++ structure behind behavior already present in the retail executable. It replaces guessed function signatures, raw object offsets, and duplicate local structs with typed class members, explicit object arguments, and shared data layouts. The matching build checks that those source changes preserve the retail executable.
TObjPlayer, and the City door uses the player’s area ID and position when checking proximity. Door, fence, and collision code use typed interfaces for the objects and packets they work with. Room and trigger changes · City door checkG_IntraMapWarp_6x55packet type, with compile-time checks for its size and position offsets. Stage, player, quest, and lobby callers use shared floor state and command definitions. Intra-map warps · Floor transition stateThe follow-up gives the area accessor to
TObjPlayerand uses shared declarations for player lookup and the live floor rows. The Dubchik render helper now uses the attachment positions on its own class. Cleanup commitThe naming follow-up restores upstream spellings for four functions and 15 fields while preserving the recovered signatures, types, and class layouts. Naming cleanup
Validation
49b48c32e6b47afbb55426ad7ac41c0ec6633480.0d85744b51d7379efb025a943d0cd5aaae2191a3. The preceding accessor cleanup also reproduced that hash in a combined build with the network runtime branch.TObjRain.cppthat covers both original ranges. CI results · Rain unit consolidation