Skip to content

Recover stage doors, fences, room assignment, and trigger contacts - #334

Closed
matthewlewisnewton wants to merge 73 commits into
zeroz41:masterfrom
matthewlewisnewton:recover-stage-doors-fences-and-contacts
Closed

matthewlewisnewton wants to merge 73 commits into
zeroz41:masterfrom
matthewlewisnewton:recover-stage-doors-fences-and-contacts

Conversation

@matthewlewisnewton

@matthewlewisnewton matthewlewisnewton commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

What this series recovers

This stage-object series reconstructs more of the C++ structure behind behavior already present in the retail executable. It replaces guessed function signatures, raw object offsets, and duplicate local structs with typed class members, explicit object arguments, and shared data layouts. The matching build checks that those source changes preserve the retail executable.

  • Doors, fences, and proximity triggers. Room triggers use the position on TObjPlayer, and the City door uses the player’s area ID and position when checking proximity. Door, fence, and collision code use typed interfaces for the objects and packets they work with. Room and trigger changes · City door check
  • Warps, floor transitions, and floor events. The intra-map warp send and receive paths share the G_IntraMapWarp_6x55 packet type, with compile-time checks for its size and position offsets. Stage, player, quest, and lobby callers use shared floor state and command definitions. Intra-map warps · Floor transition state
  • Stage fixtures, containers, and animated objects. The series recovers the model, texture, archive, motion, and contact records used by these objects and expresses their bindings through typed C++ interfaces. For example, the Olga Flow debris code now expresses position, velocity, and rotation through fields on the debris object. Stage fixture archives and motion · Olga Flow debris

The follow-up gives the area accessor to TObjPlayer and uses shared declarations for player lookup and the live floor rows. The Dubchik render helper now uses the attachment positions on its own class. Cleanup commit

The naming follow-up restores upstream spellings for four functions and 15 fields while preserving the recovered signatures, types, and class layouts. Naming cleanup

Validation

  • 487 changed files against upstream master at 49b48c32e6b47afbb55426ad7ac41c0ec6633480.
  • The full GPOE8P build reproduces the retail DOL with SHA-1 0d85744b51d7379efb025a943d0cd5aaae2191a3. The preceding accessor cleanup also reproduced that hash in a combined build with the network runtime branch.
  • The coverage checks report 158 function-label changes, zero new exact functions, zero function regressions, and unchanged matched and linked code and data byte counts. The linked-unit count goes from 2,449 to 2,448 because the two linked rain units were folded into one TObjRain.cpp that covers both original ranges. CI results · Rain unit consolidation

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

✅ CI passed · 9f03861d41 · run

Check Result
Build + DOL SHA-1 ✅
No regressions (report_delta --check) ✅
Linked units still link ✅
Metric Base PR Δ
Matched data (bytes) 1,758,510 1,758,510 0
Complete data (bytes) 1,758,510 1,758,510 0
Matched code (bytes) 4,353,092 4,353,092 0
Complete code (bytes) 4,353,092 4,353,092 0
Matched functions 27,572 27,572 0
Linked units 2,449 2,448 -1

0 new exact functions, 0 function regressions, 158 renamed functions.

@matthewlewisnewton
matthewlewisnewton marked this pull request as ready for review November 20, 2026 17:13
@zeroz41

zeroz41 commented Nov 20, 2026

Copy link
Copy Markdown
Owner

can you get the codex coauthor out of the commit history please.

@matthewlewisnewton
matthewlewisnewton force-pushed the recover-stage-doors-fences-and-contacts branch from aa70392 to 9f03861 Compare November 20, 2026 22:38
@zeroz41

zeroz41 commented Nov 20, 2026

Copy link
Copy Markdown
Owner

fine with ai use just dont want bots as commit authors, but owned to who commits.

@zeroz41

zeroz41 commented Nov 21, 2026

Copy link
Copy Markdown
Owner

should be merged with other pr. reopen if issues.

@zeroz41 zeroz41 closed this Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants