Repository navigation
Conversation
✅ CI passed ·
|
| Check | Result |
|---|---|
| Build + DOL SHA-1 | ✅ |
No regressions (report_delta --check) |
✅ |
| Linked units still link | ✅ |
| Metric | Base | PR | Δ |
|---|---|---|---|
| Matched data (bytes) | 1,758,510 | 1,758,510 | 0 |
| Complete data (bytes) | 1,758,510 | 1,758,510 | 0 |
| Matched code (bytes) | 4,353,092 | 4,353,092 | 0 |
| Complete code (bytes) | 4,353,092 | 4,353,092 | 0 |
| Matched functions | 27,572 | 27,572 | 0 |
| Linked units | 2,449 | 2,449 | 0 |
0 new exact functions, 0 function regressions, 1 renamed functions.
matthewlewisnewton
marked this pull request as draft
November 20, 2026 16:49
matthewlewisnewton
marked this pull request as ready for review
November 20, 2026 16:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Recover the game's original interfaces between the C++ socket and lobby code and the C network runtime. On master, the C++ UDP handler describes only the first words of a datagram and supplies its own
udp_opendeclaration. Other paths use partial records, raw offsets, or different declarations for the same entry point. The shared types in this PR make those callers agree on the actual records, callback signatures, and status widths.Scope
The patch preserves the existing upstream helper names. The UDP handler's signature symbol follows from using the shared datagram type.
Validation
49b48c32e6b47afbb55426ad7ac41c0ec6633480.0d85744b51d7379efb025a943d0cd5aaae2191a3. Strict coverage and linkage checks pass.