Repository navigation
Real classes, constructors and member calls - #335
Merged
Merged
Conversation
…compiler-emitted vtable
…'s helpers real member signatures
…ntries, type two technique parameter uses
…ter and trim matching notes
…rs, TWindowCost::set_cost, TWindowMeseta::set_value, init_shield_params
…py, Obj_80515BA0::get_dest_area, normalize_vector_safe, pso_load_texture and the area sound helpers
…r/packet helpers their real receivers
…nd TObjEneDD::vfunc_86 an s32 return, dropping the shadow vtable structs
…it_launch and the gold dragon's breath/effect helpers real members
Elias843
force-pushed
the
real-classes-and-types
branch
from
November 21, 2026 00:08
98923bc to
b05988e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces hand-mangled calls and hand-written constructors with real C++ classes, members and types. Code and data
are unchanged: the DOL still matches and check_pr reports no regressions.
Member calls
meth__<n>ClsF...(void *, ...)prototypes become real member calls, static or non-static by howcallers use them; narrow returns that callers widen are
s32, with the narrowing kept in the body.inventory walks go from
TObjPlayertoTPlyItemandTItemList; area sound and 2D drawing helpers get their ownheaders).
Real constructors and vtables
TObjCharaand its target cursor records, the NPC classes, enemies, bosses (Dragon, De Rol Le, Vol Opt, DarkFalz, Barba Ray, Olga Flow), containers and traps, stage objects, technique/item/sprite effects, windows and
front-end screens get real constructors (callers use
new), destructors and compiler-emitted vtables in place ofhand vptr stores and hand vtable data.
Types
TBoss2Mine,TBoss6Type2,TNpcPlayer,TObjNpcBase, thetechnique parameter tables, the gold dragon, the city shop sequences and item windows.
Where #334 already converted something, its names and structure were kept.