Repository navigation
Declare diffrax and orthax as dependencies - #48
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
rogeriojorge
force-pushed
the
agent/declare-diffrax-orthax
branch
from
September 26, 2026 21:11
72f5a89 to
1cf130d
Compare
This was referenced Sep 26, 2026
spectrax imports diffrax (time integration) and orthax (inverse Hermite transform), but pyproject.toml did not list them, so pip install left the package unimportable in a clean environment.
diffrax 0.7, matplotlib 3.10+ and current jax need at least 3.11, tomllib is in the standard library from 3.11, and CI tests 3.11 and 3.12. The old >=3.5 could not resolve.
rogeriojorge
force-pushed
the
agent/declare-diffrax-orthax
branch
from
October 3, 2026 14:26
1cf130d to
1e795e9
Compare
This was referenced Oct 4, 2026
Benjamin-Herfray
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPECTRAX imports
diffrax(time integration) andorthax(inverse Hermite transform), butpyproject.tomldid not declare them, so a cleanpip installgave a package that fails atimport spectrax.requirements.txtalready lists both.Change (pyproject.toml only, 2 lines)
diffraxandorthaxtodependencies.requires-python>=3.5->>=3.11. Evidence: diffrax 0.7.2 and matplotlib 3.11 require >=3.11, jax 0.11 requires >=3.12 (pip falls back to jax 0.10.2 on 3.11),tomllibis stdlib from 3.11, and CI tests 3.11 and 3.12. No 3.10 support is claimed or tested.Evidence (tested SHA 1e795e9, rebased on main ab87385; local)
Fresh venvs,
pip install git+file://<clone>@<ref>, thenimport spectraxandsimulation({'t_max': 0.5}, Nx=9, Nn=4, timesteps=3)from outside the source tree:ModuleNotFoundError: No module named 'diffrax'.total_energy[-1] = 1.7500044641735002.python -m pytest -n 2 -q tests(3.12.9, jax 0.11.2): 8 passed.Overlap: #21 edits the same line (adds
solvax); whichever merges second needs a one-line rebase. Side note, not changed here:total_energyis returned with complex dtype (zero imaginary part).