Migrate built-in macros `pattern_type` & `view_type` to macros 2.0 that expand to internal syntax by fmease · Pull Request #165487 · rust-lang/rust

fmease · 2026-11-05T03:25:44Z

Part of MCP-approved #110680.

Best reviewed commit by commit. Please see individual commit messages for further details.

Pinging owner of pattern types @oli-obk & owner of view types @scrabsha for visibility.

_{(No LLM was or will be used by me during the entire creation process of this PR)}

rustbot · 2026-11-05T03:25:49Z

Some changes occurred in src/tools/compiletest

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

rustbot · 2026-11-05T03:25:51Z

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 77 candidates
Random selection from 19 candidates

rustbot · 2026-11-05T13:52:54Z

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

rustc_codegen_cranelift is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_cranelift instead.

cc @bjorn3

@jieyouxu

…ition, r=jieyouxu compiletest: Fix the edition of minicore to the latest stable one ...instead of using whatever edition the dependent / the reverse dependency is using (!). Context: rust-lang#165479 (comment). Unblocks PR rust-lang#165487. r? @jieyouxu (no rush) (No LLM was or will be used by me during the entire creation process of this PR)

@jieyouxu

…ition, r=jieyouxu compiletest: Fix the edition of minicore to the latest stable one ...instead of using whatever edition the dependent / the reverse dependency is using (!). Context: rust-lang#165479 (comment). Unblocks PR rust-lang#165487. r? @jieyouxu (no rush) (No LLM was or will be used by me during the entire creation process of this PR)

@jieyouxu

…ition, r=jieyouxu compiletest: Fix the edition of minicore to the latest stable one ...instead of using whatever edition the dependent / the reverse dependency is using (!). Context: rust-lang#165479 (comment). Unblocks PR rust-lang#165487. r? @jieyouxu (no rush) (No LLM was or will be used by me during the entire creation process of this PR)

@jieyouxu

Rollup merge of #165483 - fmease:comptest-fixate-minicore-edition, r=jieyouxu compiletest: Fix the edition of minicore to the latest stable one ...instead of using whatever edition the dependent / the reverse dependency is using (!). Context: #165479 (comment). Unblocks PR #165487. r? @jieyouxu (no rush) (No LLM was or will be used by me during the entire creation process of this PR)

rustbot · 2026-11-05T19:35:21Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Just because the parser of a specific syntax fragment kind returns an `Err(_)` doesn't automatically mean that the problematic token sequence isn't "of" that fragment's kind. The token sequence might "almost" be of that kind (i.e., share a non-empty prefix) but simply contain a syntax error in it. On a side note, it's rather odd that the now removed `annotate_err_with_kind` only added the note "this macro call doesn't expand to a $fragkind" if the target fragment kind was *type* or *pat*, there are 20 kinds at the of writing.

…..)` This also means that it's now available under `core::pat` instead of `core` directly. This makes it consistent with the `std` re-export which is only available under `std::pat` and not under `std` directly. Moreover, drop library feature `pattern_type_macro` and demote language feature `pattern_types` to a library feature. This is nice because it means `std::pat::pattern_type` is no longer unnecessarily gated behind two (!) feature gates.

This also means that it's now available under `core::view` instead of `core` directly. This makes it consistent with the `std` re-export which is only available under `std::view` and not under `std` directly. Moreover, drop library feature `view_type_macro` and demote language feature `view_types` to a library feature. This is nice because it means `std::view::view_type` is no longer unnecessarily gated behind two (!) feature gates.

mati865

I'm not familiar with the code here, but the changes seem pretty straightforward. If you prefer review from somebody familiar with this code, please r- and reroll.
@bors r+

View changes since this review

rust-bors · 2026-11-09T19:15:50Z

📌 Commit 8f7bf49 has been approved by mati865

It is now in the queue for this repository.

@oli-obk

…syntax, r=mati865 Migrate built-in macros `pattern_type` & `view_type` to macros 2.0 that expand to internal syntax Part of MCP-approved rust-lang#110680. Best reviewed commit by commit. Please see individual commit messages for further details. Pinging owner of pattern types @oli-obk & owner of view types @scrabsha for visibility. (No LLM was or will be used by me during the entire creation process of this PR)

@oli-obk

…syntax, r=mati865 Migrate built-in macros `pattern_type` & `view_type` to macros 2.0 that expand to internal syntax Part of MCP-approved rust-lang#110680. Best reviewed commit by commit. Please see individual commit messages for further details. Pinging owner of pattern types @oli-obk & owner of view types @scrabsha for visibility. (No LLM was or will be used by me during the entire creation process of this PR)

@oli-obk

…syntax, r=mati865 Migrate built-in macros `pattern_type` & `view_type` to macros 2.0 that expand to internal syntax Part of MCP-approved rust-lang#110680. Best reviewed commit by commit. Please see individual commit messages for further details. Pinging owner of pattern types @oli-obk & owner of view types @scrabsha for visibility. (No LLM was or will be used by me during the entire creation process of this PR)

@oli-obk

…syntax, r=mati865 Migrate built-in macros `pattern_type` & `view_type` to macros 2.0 that expand to internal syntax Part of MCP-approved rust-lang#110680. Best reviewed commit by commit. Please see individual commit messages for further details. Pinging owner of pattern types @oli-obk & owner of view types @scrabsha for visibility. (No LLM was or will be used by me during the entire creation process of this PR)

…uwer Rollup of 16 pull requests Successful merges: - #165575 (Upgrade bundled musl to 1.2.6) - #163992 (add `core::arch::{x86, x86_64}::x87_f80`) - #165117 (std: use skip_unsupported_miri_tests to control when tests should be skipped in Miri due to missing shims) - #165458 (fix incorrect byte count suffix on MSVC) - #165487 (Migrate built-in macros `pattern_type` & `view_type` to macros 2.0 that expand to internal syntax) - #165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - #165586 (Remove `backend_optimization_level`.) - #165646 (fix NumScalableVectors::from_field_count) - #165655 (Unignore passing GCC backend tests) - #165740 (miri subtree update) - #164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - #165682 (interpret: ensure newly created unions have uninit in their padding) - #165693 (Move `check_attr` to attribute parsing) - #165715 (windows: check for null before wide encoding) - #165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - #165733 (docs(num): remove needless whitespaces) Failed merges: - #165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - #153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - #164218 (Tweak private re-export errors to point at correct span and have more context) - #165709 (remove 'x miri' smoke test from PR CI)

JonathanBrouwer · 2026-11-10T12:13:38Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #165747 (comment)

rust-bors · 2026-11-10T12:13:46Z

This pull request was unapproved.

This PR was contained in a rollup (#165747), which was unapproved.

View changes since this unapproval

rust-bors · 2026-11-10T20:31:16Z

☔ The latest upstream changes (presumably #165760) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

fmease added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Nov 5, 2026

rustbot assigned mati865 Nov 5, 2026

fmease mentioned this pull request Nov 5, 2026

compiletest: Fix the edition of minicore to the latest stable one #165483

Merged

fmease added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Nov 5, 2026

This comment has been minimized.

Sign in to view

fmease force-pushed the built-in-macro-to-internal-syntax branch from da7d5bf to a02f646 Compare November 5, 2026 13:52

This comment has been minimized.

Sign in to view

fmease force-pushed the built-in-macro-to-internal-syntax branch from a02f646 to 9b599a1 Compare November 5, 2026 14:36

This comment has been minimized.

Sign in to view

fmease force-pushed the built-in-macro-to-internal-syntax branch from 9b599a1 to ca6cb90 Compare November 5, 2026 15:39

This comment has been minimized.

Sign in to view

fmease force-pushed the built-in-macro-to-internal-syntax branch from ca6cb90 to 7a164f7 Compare November 5, 2026 17:03

fmease force-pushed the built-in-macro-to-internal-syntax branch from 7a164f7 to 8f7bf49 Compare November 5, 2026 19:35

fmease changed the title ~~[STACKED] Migrate built-in macros pattern_type & view_type to macros 2.0 that expand to internal syntax~~ Migrate built-in macros pattern_type & view_type to macros 2.0 that expand to internal syntax Nov 5, 2026

fmease removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Nov 5, 2026

fmease added 3 commits November 5, 2026 20:37

mati865 approved these changes Nov 9, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2026

JonathanBrouwer mentioned this pull request Nov 9, 2026

Rollup of 7 pull requests #165724

Closed

jhpratt mentioned this pull request Nov 10, 2026

Rollup of 11 pull requests #165735

Closed

JonathanBrouwer mentioned this pull request Nov 10, 2026

Rollup of 14 pull requests #165742

Closed

JonathanBrouwer mentioned this pull request Nov 10, 2026

Rollup of 16 pull requests #165747

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 10, 2026

Navigation Menu

Repository navigation

Migrate built-in macros `pattern_type` & `view_type` to macros 2.0 that expand to internal syntax - #165487

Migrate built-in macros `pattern_type` & `view_type` to macros 2.0 that expand to internal syntax#165487
fmease wants to merge 3 commits into
rust-lang:mainfrom
fmease:built-in-macro-to-internal-syntax

fmease commented Nov 5, 2026 •

edited

Loading

Uh oh!

rustbot commented Nov 5, 2026

Uh oh!

rustbot commented Nov 5, 2026

Uh oh!

This comment has been minimized.

rustbot commented Nov 5, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Nov 5, 2026

Uh oh!

mati865 left a comment •

edited by rustbot

Loading

Uh oh!

rust-bors Bot commented Nov 9, 2026

Uh oh!

JonathanBrouwer commented Nov 10, 2026

Uh oh!

rust-bors Bot commented Nov 10, 2026

Uh oh!

rust-bors Bot commented Nov 10, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

fmease commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 5, 2026

Uh oh!

rustbot commented Nov 5, 2026

Uh oh!

This comment has been minimized.

rustbot commented Nov 5, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Nov 5, 2026

Uh oh!

mati865 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Nov 9, 2026

Uh oh!

JonathanBrouwer commented Nov 10, 2026

Uh oh!

rust-bors Bot commented Nov 10, 2026

Uh oh!

rust-bors Bot commented Nov 10, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fmease commented Nov 5, 2026 •

edited

Loading

mati865 left a comment •

edited by rustbot

Loading