Repository navigation
compiletest: Fix the edition of minicore to the latest stable one - #165483
Merged
rust-bors[bot] merged 2 commits intoNov 5, 2026
Merged
Conversation
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
rustbot
added
the
T-bootstrap
fmease
commented
Nov 5, 2026
| pub(crate) const RUSTC_DEFAULT: Self = Self::Year(2015); | ||
| pub(crate) const LATEST_STABLE: Self = Self::Year(2024); | ||
|
|
||
| pub(crate) fn to_flag(self) -> String { |
Member
Author
There was a problem hiding this comment.
Apologies in advance for potential abstraction layer violations.
Member
There was a problem hiding this comment.
It's fine, it's a bit of a mess already. I need to clean this up...
fmease
added
the
A-test-infra-minicore
jieyouxu
approved these changes
Nov 5, 2026
Member
There was a problem hiding this comment.
Thanks. I think there's more fundamental problems in the handling here re. #165479 (comment), but this is at least sensible and a small improvement IMO...
@bors r+ rollup
Comment on lines
+36
to
+37
| // FIXME: Why do we need to ignore the edition? | ||
| let TestProps { edition: _, compile_flags, run_flags, .. } = props; |
Member
There was a problem hiding this comment.
(rustdoc_gui_test is a bit of an hack, and honestly I'm not sure... IIRC rustdoc_gui_test didn't want to mirror/reimpl test directive handling which is why there's a bit of an hack.)
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 5, 2026
…ition, r=jieyouxu compiletest: Fix the edition of minicore to the latest stable one ...instead of using whatever edition the dependent / the reverse dependency is using (!). Context: rust-lang#165479 (comment). Unblocks PR rust-lang#165487. r? @jieyouxu (no rush) <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 5, 2026
…ition, r=jieyouxu compiletest: Fix the edition of minicore to the latest stable one ...instead of using whatever edition the dependent / the reverse dependency is using (!). Context: rust-lang#165479 (comment). Unblocks PR rust-lang#165487. r? @jieyouxu (no rush) <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
This was referenced Nov 5, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
…uwer Rollup of 8 pull requests Successful merges: - #165496 (c-variadic: remove stale `cfg(bootstrap)` comment) - #164716 (Lower UEFI targets through LLVM's *uefi triple) - #165497 (fix unsoundness when compiling `[diverging_const; _]`) - #165275 (Build TPDE with local Clang when available) - #165467 (Use `emit_ptr_va_arg` for `va_arg` on MSP430) - #165483 (compiletest: Fix the edition of minicore to the latest stable one) - #165498 (LoongArch: Fix direct-access-external-data test) - #165501 (rustdoc: Don't add a border on an empty `:target` element)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
Rollup merge of #165483 - fmease:comptest-fixate-minicore-edition, r=jieyouxu compiletest: Fix the edition of minicore to the latest stable one ...instead of using whatever edition the dependent / the reverse dependency is using (!). Context: #165479 (comment). Unblocks PR #165487. r? @jieyouxu (no rush) <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...instead of using whatever edition the dependent / the reverse dependency is using (!).
Context: #165479 (comment).
Unblocks PR #165487.
r? @jieyouxu (no rush)
(No LLM was or will be used by me during the entire creation process of this PR)