Rollup of 7 pull requests by JonathanBrouwer · Pull Request #165724 · rust-lang/rust

JonathanBrouwer · 2026-11-09T21:36:46Z

Successful merges:

std: use skip_unsupported_miri_tests to control when tests should be skipped in Miri due to missing shims #165117 (std: use skip_unsupported_miri_tests to control when tests should be skipped in Miri due to missing shims)
Migrate built-in macros pattern_type & view_type to macros 2.0 that expand to internal syntax #165487 (Migrate built-in macros pattern_type & view_type to macros 2.0 that expand to internal syntax)
Mark the compile unit for -Zdebuginfo-for-profiling #165490 (Mark the compile unit for -Zdebuginfo-for-profiling)
fix NumScalableVectors::from_field_count #165646 (fix NumScalableVectors::from_field_count)
Unignore passing GCC backend tests #165655 (Unignore passing GCC backend tests)
Move check_attr to attribute parsing #165693 (Move check_attr to attribute parsing)
mpsc_sync::stream_send_recv_stress: wait for all threads to finish #165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish)

With `-Zdebuginfo-for-profiling`, set `debugInfoForProfiling` on the `DICompileUnit`, as Clang does for `-fdebug-info-for-profiling` (`CGDebugInfo.cpp`). Before this change, the flag only added the discriminators pass, and the compile unit flag was always false.

Just because the parser of a specific syntax fragment kind returns an `Err(_)` doesn't automatically mean that the problematic token sequence isn't "of" that fragment's kind. The token sequence might "almost" be of that kind (i.e., share a non-empty prefix) but simply contain a syntax error in it. On a side note, it's rather odd that the now removed `annotate_err_with_kind` only added the note "this macro call doesn't expand to a $fragkind" if the target fragment kind was *type* or *pat*, there are 20 kinds at the of writing.

…..)` This also means that it's now available under `core::pat` instead of `core` directly. This makes it consistent with the `std` re-export which is only available under `std::pat` and not under `std` directly. Moreover, drop library feature `pattern_type_macro` and demote language feature `pattern_types` to a library feature. This is nice because it means `std::pat::pattern_type` is no longer unnecessarily gated behind two (!) feature gates.

This also means that it's now available under `core::view` instead of `core` directly. This makes it consistent with the `std` re-export which is only available under `std::view` and not under `std` directly. Moreover, drop library feature `view_type_macro` and demote language feature `view_types` to a library feature. This is nice because it means `std::view::view_type` is no longer unnecessarily gated behind two (!) feature gates.

…ts should be skipped in Miri due to missing shims

@tgross35

…r=maxdexh std: use skip_unsupported_miri_tests to control when tests should be skipped in Miri due to missing shims We currently run some subset of std tests in Miri, skipping some because Miri doesn't support the operations they need. That is based on filters in the makefile. People don't know what is actually being tested and add random `cfg(miri)` in places to disable tests that were never run. This makes it quite hard to track which tests are being skipped and which operations we should add in Miri to get 100% std coverage. So let's replace that string-based filter with a cfg flag, `skip_unsupported_miri_tests`, that can be annotated at the tests. Unfortunately I can't figure out how to disable all doctests in a module based on a cfg flag, so this entirely disables std doctests being run in Miri in our CI. (We still run them in https://github.com/rust-lang/miri-test-libstd.) See prior discussion [on Zulip](https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/Miri.20vs.20tests.20in.20std/with/635913743). Docs PR: rust-lang/std-dev-guide#86 r? @tgross35 try-job: test-x86_64-gnu-aux

@oli-obk

…syntax, r=mati865 Migrate built-in macros `pattern_type` & `view_type` to macros 2.0 that expand to internal syntax Part of MCP-approved rust-lang#110680. Best reviewed commit by commit. Please see individual commit messages for further details. Pinging owner of pattern types @oli-obk & owner of view types @scrabsha for visibility. <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>

…ompile-unit, r=dtolnay Mark the compile unit for `-Zdebuginfo-for-profiling` With `-Zdebuginfo-for-profiling`, set `debugInfoForProfiling` on the `DICompileUnit`, as Clang does for `-fdebug-info-for-profiling` (`CGDebugInfo.cpp`). Before this change, the flag only added the discriminators pass, and the compile unit flag was always false.

…orkingjubilee fix NumScalableVectors::from_field_count I assume that this should've been `2..=8` and not `2..8`, based on the comments and `IntoDiagArg` implementation.

@antoyo

Unignore passing GCC backend tests Since we last checked, a lot more tests now pass with the GCC backend, so unignoring them. r? @antoyo

@mejrs

Move `check_attr` to attribute parsing Just cleanup, should not affect behaviour other than diagnostic ordering. Can be reviewed commit by commit, every commit passes tests. Is also small enough that reviewing as a whole is fine tho. r? @mejrs

@maxdexh

…r=maxdexh mpsc_sync::stream_send_recv_stress: wait for all threads to finish rust-lang#156365 did this for the other two queues, but somehow I skipped mpsc_sync. Best reviewed without whitespace diff. r? @maxdexh (very similar to rust-lang#165643)

JonathanBrouwer · 2026-11-09T21:37:04Z

@bors r+ p=5 force

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu,test-x86_64-gnu-llvm-22-3,test-aarch64-msvc-2

rust-bors · 2026-11-09T21:37:07Z

📌 Commit 9542910 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 7 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2

rust-log-analyzer · 2026-11-09T21:41:52Z

The job test-pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


error[E0433]: cannot find type `AttrKind` in this scope
   --> compiler/rustc_attr_parsing/src/validate_attr.rs:107:45
    |
107 |         .filter(|attr| !matches!(attr.kind, AttrKind::Synthetic(CfgAttrTrace(_))))
    |                                             ^^^^^^^^ use of undeclared type `AttrKind`
    |
help: consider importing one of these enums
    |
  3 + use crate::validate_attr::ast::AttrKind;

rust-log-analyzer · 2026-11-09T21:43:00Z

The job test-armhf-gnu failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


error[E0433]: cannot find type `AttrKind` in this scope
   --> compiler/rustc_attr_parsing/src/validate_attr.rs:107:45
    |
107 |         .filter(|attr| !matches!(attr.kind, AttrKind::Synthetic(CfgAttrTrace(_))))
    |                                             ^^^^^^^^ use of undeclared type `AttrKind`
    |
help: consider importing one of these enums
    |
  3 + use crate::validate_attr::ast::AttrKind;

rust-bors · 2026-11-09T21:52:20Z

PR #165693, which is a member of this rollup, was unapproved.

This rollup was thus unapproved.

rust-bors · 2026-11-09T22:13:41Z

💔 Test for 20f7674 failed: CI. Failed jobs:

try - dist-various-1 (web logs, enhanced plaintext logs)
try - test-aarch64-apple-1 (web logs, enhanced plaintext logs)
try - test-aarch64-apple-2 (web logs, enhanced plaintext logs)
try - test-aarch64-msvc-2 (web logs, enhanced plaintext logs)
try - test-armhf-gnu (web logs, enhanced plaintext logs)
(and 6 other jobs)

apolloww and others added 18 commits November 4, 2026 23:24

fix NumScalableVectors::from_field_count

ad13cdf

Remove parsed arm of check_attr

41ed8b9

Move check_attr to attribute parsing

a8e1a33

Add test checking that the behaviour for diagnostic attrs is preserved

fb94dbd

std Miri testing: use skip_unsupported_miri_tests to control when tes…

3cf3c87

…ts should be skipped in Miri due to missing shims

Unignore passing GCC backend tests

0aa6251

mpsc_sync::stream_send_recv_stress: wait for all thread to finish

0e99915

Rollup merge of rust-lang#165646 - malezjaa:fix-from_field_count, r=w…

1d03644

…orkingjubilee fix NumScalableVectors::from_field_count I assume that this should've been `2..=8` and not `2..8`, based on the comments and `IntoDiagArg` implementation.

Rollup merge of rust-lang#165655 - GuillaumeGomez:gcc-tests, r=antoyo

d2a6a09

Unignore passing GCC backend tests Since we last checked, a lot more tests now pass with the GCC backend, so unignoring them. r? @antoyo

rust-bors Bot added the rollup A PR which is a rollup label Nov 9, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer mentioned this pull request Nov 9, 2026

Move check_attr to attribute parsing #165693

Merged

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 9, 2026

JonathanBrouwer closed this Nov 9, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 9, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 9, 2026

Navigation Menu

Repository navigation

Rollup of 7 pull requests - #165724

Rollup of 7 pull requests#165724
JonathanBrouwer wants to merge 18 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-6Ht1lL0

JonathanBrouwer commented Nov 9, 2026

Uh oh!

JonathanBrouwer commented Nov 9, 2026

Uh oh!

rust-bors Bot commented Nov 9, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Nov 9, 2026

Uh oh!

rust-log-analyzer commented Nov 9, 2026

Uh oh!

rust-bors Bot commented Nov 9, 2026

Uh oh!

rust-bors Bot commented Nov 9, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

JonathanBrouwer commented Nov 9, 2026

Uh oh!

JonathanBrouwer commented Nov 9, 2026

Uh oh!

rust-bors Bot commented Nov 9, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Nov 9, 2026

Uh oh!

rust-log-analyzer commented Nov 9, 2026

Uh oh!

rust-bors Bot commented Nov 9, 2026

Uh oh!

rust-bors Bot commented Nov 9, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants