[malezjaa]

Closes #133125

History

Implementation: #133057

Public API

impl String {
    pub fn into_chars(self) -> IntoChars { .. }
}

#[cfg_attr(not(no_global_oom_handling), derive(Clone))]
pub struct IntoChars {}
impl fmt::Debug for IntoChars {}

impl IntoChars {
    pub fn as_str(&self) -> &str { .. }
    pub fn into_string(self) -> String { .. }
}

impl Iterator for IntoChars {}
impl DoubleEndedIterator for IntoChars {}
impl FusedIterator for IntoChars {}

@rustbot modify labels: +T-libs

No unresolved questions so, hoping to get a FCP started ^^

[malezjaa]

Huh?
r? libs

[clarfonthey]

Probably desirable to derive(Clone) also as part of the stabilization, since that's particularly useful for iterators. Anyway,

@rfcbot merge libs

[rust-rfcbot]

@clarfonthey has proposed to merge this. The next step is review by the rest of the tagged team members:

• @ChrisDenton
• @Mark-Simulacrum
• @cuviper
• @dtolnay
• @joshtriplett
• @nia-e
• @the8472
• @thomcc

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/libs-ping: FCP proposed for libs, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

[clarfonthey]

Since this is just a wrapper over vec::IntoIter, we could pretty easily derive(Clone) and support it. I would say that's useful since cloning iterators is pretty useful for debugging, even if it would allocate a copy here.

View changes since the review

[malezjaa]

Doesn't it already have Clone?

#[cfg_attr(not(no_global_oom_handling), derive(Clone))]

Or did you mean that it should always derive(Clone)?

[clarfonthey]

Oh, I totally missed that line. You just didn't include it in the public API in the description is why I was confused.

[malezjaa]

Sorry, I just copied the output from cargo unstable-api which didn't include the clone 😅 It's probably because it was in #[cfg_attr].

[ChrisDenton]

I admit I felt a bit "meh" about this when I initially saw it but after looking at the motivation in the ACP, I think this is reasonable. And the tracking issue does seem to have gained some interest so there's at least some demand.

So +1 from me.

[rust-rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[clarfonthey]

r=me pending FCP

[rust-rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

[jhpratt]

@bors r=@clarfonthey rollup

[rust-bors]

📌 Commit 7d9c415 has been approved by clarfonthey

It is now in the queue for this repository.