Repository navigation
Rollup of 20 pull requests - #164928
Merged
Merged
Rollup of 20 pull requests#164928
Conversation
After poll returned, the code treated any result without `POLLERR`/`POLLHUP` as success. That's how Linux reports a failed connect, but POSIX only specifies that the socket becomes writable once the connection is established, not how a failed attempt is reported. So on `illumos`, where a refused connect only sets `POLLOUT`, `connect_timeout` returned `Ok` for a socket that never connected. This keeps the behavior for `Linux` and `Android`, which can rely on the status from `POLLERR`/`POLLHUP` as a fast path. Other cases now check `self.take_error()?` to get the actual status. `connect_timeout_error` test was tightened to expect an error.
…t/patch-1 Add note about std debug assertions disabling codegen tests
We need to refer to these rather often, but there hasn't been a common place to locate this information.
Add a Developer Resources section with links to ABI documentation
Signed-off-by: Gauravpawar101 <[email protected]>
GenMC now supports weak CASes and the failure ordering of CASes. Hence, the CAS API is adjusted accordingly (no change in behavior for now).
Modeling spurious failures is opt-in (see `-Zmiri-genmc-weak-cas-spurious-failures`), since Miri-GenMC cannot bound all retry loops involving weak CASes (e.g., the ones in the standard library).
update offload usage
…al-context-ref-readonly Use `eval_context_ref` where mutable access is not needed
rustbot
added
A-rustc-dev-guide
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 25, 2026
Rollup of 20 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot)Important For more information how to resolve CI failures of this job, visit this link. |
Member
Author
|
@bors p=5 |
Contributor
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 76456a6 (parent) -> 8592206 (this PR) Test differencesShow 3742 test diffsStage 1
Stage 2
Additionally, 3664 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 859220648edee0282af5b56f0b490cd4beb074db --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (8592206): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 0.5%, secondary -0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 0.1%, secondary -0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 489.982s -> 488.814s (-0.24%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: 76456a688b In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 31, 2026
…uwer Rollup of 20 pull requests Successful merges: - #163730 (add tests over re-entrancy guarantees for 160776) - #164834 (miri subtree update) - #164849 (Use the span of the doctest code block fence for figuring out the line number) - #164883 (rustdoc: don't panic on a nested use group with no path prefix) - #164890 (Store cold blocks in a bitset instead of a Vec of bools) - #163458 (stabilize {Rc, Arc}::is_unique) - #163499 (vec: stabilise allocators for into_iter) - #163805 (std: check `SO_ERROR` after poll in `TcpStream::connect_timeout`) - #163816 (stabilize String::into_chars) - #163819 (Correct documentation of what `core::ops::Code` is.) - #163847 (add regression test for reborrow-invariant-type) - #164006 (Arduously fix typo) - #164009 (Update `Ready` future expect messages) - #164522 (Add IPv6 hop limit stubs to the motor OS net backend) - #164602 (Improve seek_read_buf_exact() test coverage to match seek_read_exact()) - #164772 (docs: Two nitpick changes to `HashMap`, `BTreeMap` Entry API docs) - #164794 (Expose FloatErrorKind) - #164802 (Migrate stable-specific run-make tests to UI tests) - #164899 (Only recover if we may in `parse_expr_tuple_parens`) - #164903 (rustc-dev-guide subtree update) Failed merges: - #164856 (Switch from `insta` to `expect-test` in bootstrap)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
SO_ERRORafter poll inTcpStream::connect_timeout#163805 (std: checkSO_ERRORafter poll inTcpStream::connect_timeout)core::ops::Codeis. #163819 (Correct documentation of whatcore::ops::Codeis.)Readyfuture expect messages #164009 (UpdateReadyfuture expect messages)HashMap,BTreeMapEntry API docs #164772 (docs: Two nitpick changes toHashMap,BTreeMapEntry API docs)parse_expr_tuple_parens#164899 (Only recover if we may inparse_expr_tuple_parens)Failed merges:
instatoexpect-testin bootstrap #164856 (Switch frominstatoexpect-testin bootstrap)r? @ghost
Create a similar rollup