Skip to content

Rollup of 19 pull requests - #164923

Closed
JonathanBrouwer wants to merge 205 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-TXxvAxa
Closed

JonathanBrouwer wants to merge 205 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-TXxvAxa

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

Warning

This rollup conflicts with pending auto build #164894 and may need to be recreated if the pending build succeeds.

r? @ghost

Create a similar rollup

nia-e and others added 30 commits September 29, 2026 19:34
After poll returned, the code treated any result without
`POLLERR`/`POLLHUP` as success. That's how Linux reports a failed
connect, but POSIX only specifies that the socket becomes writable once
the connection is established, not how a failed attempt is reported.
So on `illumos`, where a refused connect only sets `POLLOUT`,
`connect_timeout` returned `Ok` for a socket that never connected.

This keeps the behavior for `Linux` and `Android`, which can
rely on the status from `POLLERR`/`POLLHUP` as a fast path. Other cases
now check `self.take_error()?` to get the actual status.

`connect_timeout_error` test was tightened to expect an error.
…t/patch-1

Add note about std debug assertions disabling codegen tests
We need to refer to these rather often, but there hasn't been a common
place to locate this information.
Add a Developer Resources section with links to ABI documentation
GenMC now supports weak CASes and the failure ordering of CASes.
Hence, the CAS API is adjusted accordingly (no change in behavior
for now).
Modeling spurious failures is opt-in (see
`-Zmiri-genmc-weak-cas-spurious-failures`), since Miri-GenMC cannot
bound all retry loops involving weak CASes (e.g., the ones in the
standard library).
…al-context-ref-readonly

Use  `eval_context_ref` where mutable access is not needed
support  __cxa_thread_atexit_impl and correctly handle thread cleanup on exit
@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc O-apple Operating system: Apple / Darwin (macOS, iOS, tvOS, visionOS, watchOS) O-linux Operating system: Linux O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Oct 25, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ p=5 force

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu,test-x86_64-gnu-llvm-22-3

@rust-bors

rust-bors Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 116e345 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026
Rollup of 19 pull requests


try-job: dist-various-1
try-job: test-various
try-job: test-x86_64-gnu-aux
try-job: test-x86_64-msvc-1
try-job: test-aarch64-apple-1
try-job: test-aarch64-apple-2
try-job: test-x86_64-mingw-1
try-job: test-i686-msvc
try-job: test-armhf-gnu
try-job: test-x86_64-gnu-llvm-22-3
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 25, 2026
@rust-bors

rust-bors Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

This pull request was unapproved.

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 25, 2026
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-x86_64-msvc-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
 Documenting std v0.0.0 (D:\a\rust\rust\library\std)
error[E0433]: failed to resolve: could not resolve path `libc::dup2`
   --> library\std\src\os\unix\io\mod.rs:223:28
    |
223 |         )) => cvt(unsafe { libc::dup2(other.as_raw_fd(), this.as_raw_fd()) }).map(|_| ()),
    |                            ^^^^^^^^^^ could not resolve path `libc::dup2`
    |
    = note: this error was originally ignored because you are running `rustdoc`
    = note: try running again with `rustc` or `cargo check` and you may get a more detailed error

error[E0433]: failed to resolve: could not resolve path `libc::close`
   --> library\std\src\os\fd\owned.rs:223:25
    |
223 |                 let _ = libc::close(self.fd.as_inner());
    |                         ^^^^^^^^^^^ could not resolve path `libc::close`
    |
    = note: this error was originally ignored because you are running `rustdoc`
    = note: try running again with `rustc` or `cargo check` and you may get a more detailed error

[RUSTC-TIMING] std test:false 6.501
---
[RUSTC-TIMING] getopts test:false 0.406
 Documenting test v0.0.0 (D:\a\rust\rust\library\test)
For more information about this error, try `rustc --explain E0433`.
error: could not document `std`
Command `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin\cargo.exe doc --target x86_64-pc-windows-msvc -Zrustdoc-mergeable-info -Zbinary-dep-depinfo -j 4 -Zroot-dir=D:\a\rust\rust -Zembed-metadata=no --locked --color=always --profile=dist -p alloc -p compiler_builtins -p core -p panic_abort -p panic_unwind -p proc_macro -p profiler_builtins -p rustc-std-workspace-core -p std -p std_detect -p sysroot -p test -p unwind --features 'backtrace panic-unwind profiler compiler-builtins-c' --manifest-path D:\a\rust\rust\library/sysroot/Cargo.toml --no-deps --target-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-std\x86_64-pc-windows-msvc\doc -Zrustdoc-map [workdir=D:\a\rust\rust]` failed with exit code 101
Created at: src\bootstrap\src\core\build_steps\doc.rs:838:21
Executed at: src\bootstrap\src\core\build_steps\doc.rs:769:30

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `test --stage 2 --skip=compiler --skip=src`
Currently active steps:
test::RustdocJSStd { build_compiler: Compiler { stage: 2, host: x86_64-pc-windows-msvc, forced_compiler: false }, target: x86_64-pc-windows-msvc } at src\bootstrap\src\core\build_steps\test.rs:1494
doc::Std { build_compiler: Compiler { stage: 2, host: x86_64-pc-windows-msvc, forced_compiler: false }, target: x86_64-pc-windows-msvc, format: Html, crates: [] } at src\bootstrap\src\core\build_steps\test.rs:1538
Build completed unsuccessfully in 2:12:44
make: *** [Makefile:115: ci-msvc-py] Error 1
  local time: Sun Oct 25 20:52:12 CUT 2026
  network time: Sun, 25 Oct 2026 20:52:12 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 25, 2026
@rust-bors

rust-bors Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 7d3ce56 failed: CI. Failed job:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc O-apple Operating system: Apple / Darwin (macOS, iOS, tvOS, visionOS, watchOS) O-linux Operating system: Linux O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.