Repository navigation
fix: keep minor tetrad symbols lowercase in chord labels - #131
Merged
Merged
Conversation
Blanket capitalization (CSS text-transform and JS capitalize()) was uppercasing the leading letter of raw chord symbols like m7 and mΔ7, turning them into M7/MΔ7 in the Free Play picker and theory modal. Only word-phrase labels (triads, scales, intervals) should be title-cased; chord notation symbols must stay as-is.
3 tasks done
privera-git
added a commit
that referenced
this pull request
Jul 17, 2026
) Follow-up to #131: the same blanket capitalization (text-transform: capitalize) was still uppercasing raw chord symbols like m7b5 in IdleView's quality label. Reuses formatQualityLabel/isChordSymbolQuality from music/display.ts so only word-phrase labels get title-cased. Co-authored-by: Patricio Rivera Alfaro <[email protected]>
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text-transform: capitalizeinFreePlayPicker.vue, JScapitalize()inTheoryModal.vue) was uppercasing the leading letter of raw chord notation symbols, turningm7intoM7andmΔ7intoMΔ7in the Free Play picker and the theory modal.isChordSymbolQuality()insrc/music/display.tsto distinguish word-phrase labels (triads, scales, intervals — which should be title-cased) from raw chord symbols (which must never be case-transformed).sus2/sus4in the Triads picker now render lowercase instead ofSus2/Sus4, which is the correct notation — confirmed with the user.Test plan
npm run lintnpm run test:unit -- --run(509 tests passing, includes new regression tests inFreePlayPicker.spec.tsandTheoryModal.spec.ts)npm run buildm7/mΔ7lowercase; Triads still showsMajor Triad/Minor Triadtitle-cased