Repository navigation
fix: keep minor tetrad symbols lowercase in IdleView quality label - #132
Merged
Merged
Conversation
Follow-up to #131: the same blanket capitalization (text-transform: capitalize) was still uppercasing raw chord symbols like m7b5 in IdleView's quality label. Reuses formatQualityLabel/isChordSymbolQuality from music/display.ts so only word-phrase labels get title-cased.
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text-transform: capitalize/.toUpperCase()) was still uppercasing raw chord symbols likem7b5inIdleView's quality label, turning them into e.g.M7b5.formatQualityLabel/isChordSymbolQualityhelpers frommusic/display.ts(added in fix: keep minor tetrad symbols lowercase in chord labels #131) so only word-phrase labels (triads, scales, intervals) get title-cased, while chord notation symbols stay as-is.Test plan
npm run lintnpm run test:unit -- --run(510 passed, incl. new case:keeps minor tetrad symbols lowercase in the quality label (m7b5))npm run build