Repository navigation
fix: skip capitalization for minor tetrad symbols (m7, mMaj7) - #125
Closed
privera-git wants to merge 1 commit into
Closed
privera-git wants to merge 1 commit into
privera-git wants to merge 1 commit into
Conversation
Adds isMinorSymbolLabel() to distinguish notation symbols where case is semantically load-bearing from word-phrase labels, and gates the capitalize transform in FreePlayPicker, IdleView, and TheoryModal so m7/mMaj7 no longer render as M7/MΔ7. Also fixes IdleView leaking the raw ChordQuality key instead of the formatted label. Fixes #116
Owner
Author
|
Closing without merging — this fixes the same bug as #116, but #116 was already resolved on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
m7/mMaj7were rendering asM7/MΔ7becauseFreePlayPicker.vue,IdleView.vue, andTheoryModal.vueblindly capitalized the first letter of quality labels, corrupting the minor/major distinction.isMinorSymbolLabel()insrc/music/display.tsto distinguish raw notation symbols where case is semantically load-bearing from word-phrase labels (e.g.major triad), and gates each component's capitalize mechanism (CSStext-transformor JScapitalize()) on it.IdleView.vuealso stopped leaking the rawChordQualitykey directly into the template and now callsformatQualityLabel().Fixes #116
Test plan
npm run lintnpm run test:unit -- --run(469 tests passed, including new cases forisMinorSymbolLabeland each affected component)npm run buildm7/mΔ7correctly