Repository navigation
Reject invalid calibration and unsafe native deadlines - #22
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 8, 2026
han-xudong
marked this pull request as ready for review
October 8, 2026 01:08
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calibration and duration edge cases can currently produce non-finite values or unsafe native deadlines. This change rejects out-of-range calibration before delivery, checks duration/deadline conversions, and documents the uncancellable DNS boundary.
The four consumers pin this SDK candidate and retain their private build adapters. Numerical, transport/lifecycle and bounded resolver regressions passed locally; the fixed five-input parser corpus also passed ASan/UBSan. This draft runs the existing platform acceptance before review. No hardware configuration writes or release publication are involved.
Branch naming update: this draft replaces #21 after the source branch was renamed to
fix/ecosystem-improvements. The commit and implementation are unchanged. Original discussion and same-commit acceptance evidence remain on the previous PR; product tests are not repeated solely for the naming change.