Repository navigation
refactor: integrate ConfigMaker and Welcome presentation owners - #240
Conversation
The design defines `ConfigMakerStatusPresentation<TSeverity>` as the focused owner of four status values and their ordered publication sequence. The owner receives three cold callback ports and preserves raw severity, nullable inline strings, equality behavior, and partial state after failures. The document keeps localization, notification construction, sender behavior, and the inline flag within the existing host adapters. The specified sequence resolves the title, raises the notice, reads the flag once, and conditionally updates four properties in order. The documented boundaries exclude unrelated partials, user controls, resources, workflows, platform surfaces, and release acceptance. The implementation plan separates portable characterization from native composition qualification. The plan records focused tests, a controlled ordering mutation, full managed checks, host guards, bounded native evidence, and independent reviews as pending work. The governance inventory registers both documents with their language policy, authorship metadata, and summarized scope. Changed files: - "docs/governance/document-inventory.json" (+20/-0 lines). - "docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md" (+108/-0 lines). - "docs/superpowers/specs/2026-11-11-configmaker-status-presentation-design.md" (+127/-0 lines). The file counts compare the staged tree with its first parent. Refs: #228 Staged-Tree: c273657
The change moves four observable status values from ConfigMakerViewModel into ConfigMakerStatusPresentation<TSeverity>. The view model retains its public accessors and forwards property notifications from the new owner. The ShowEditorMessage method now delegates status publication through the typed presentation object. The presentation resolves the title, raises the current notice callback, and reads the inline setting once afterward. The presentation publishes title, message, severity, and open state in their existing order when inline display is enabled. The disabled path closes the current status without replacing the other values. The stored callbacks remain inactive during construction. The new tests characterize equality suppression, raw nullable values, callback ordering, nested calls, exception identity, partial updates, retries, and independent instances. The test project links the presentation source for direct coverage. The plan marks the completed managed implementation and build activities. The verification report records observed test, mutation, build, and contract results while identifying native and delivery qualification as pending. The governance inventory records the plan history and adds the verification report. Changed files: - "CDPIUI.Tests/CDPIUI.Tests.csproj" (+1/-0 lines). - "CDPIUI.Tests/Presentation/ConfigMakerStatusPresentationTests.cs" (+429/-0 lines). - "CDPIUI/ViewModels/ConfigMaker/ConfigMakerStatusPresentation.cs" (+68/-0 lines). - "CDPIUI/ViewModels/ConfigMaker/ConfigMakerViewModel.cs" (+22/-34 lines). - "docs/governance/document-inventory.json" (+13/-3 lines). - "docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md" (+6/-6 lines). - "docs/superpowers/reports/2026-11-11-configmaker-status-presentation-verification.md" (+106/-0 lines). The file counts compare the staged tree with its first parent. Refs: #228 Staged-Tree: b7e14a2
The inventory records commit 05e0061 as the verification report's first introduction. The plan marks source review, fixture construction, exclusive leasing, and the single owned process run as complete. The report corrects the typed owner's physical size from 69 lines to 68 lines. The native qualification documents the immutable fixture, reconstructed inputs, preserved scenario data, independent reviews, and pinned artifact hashes. The build record reports zero warnings and errors, while the execution record reports 184 unique passing groups and no failures. The evidence also records one completed process, empty output streams, retained hash checks, and guarded lease release. The six new groups cover cold models, accessor behavior, severity text, notification state, nested effects, observer faults, retries, and instance independence. The report distinguishes normalized EventArgs values from nullable inline state and limits reflection to private member characterization. The stated boundaries exclude operating endpoints, desktop input, elevation, file operations, and unrelated workflows. The remaining section keeps delivery gates and unsupported native mutation cases pending. Changed files: - "docs/governance/document-inventory.json" (+2/-2 lines). - "docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md" (+3/-3 lines). - "docs/superpowers/reports/2026-11-11-configmaker-status-presentation-verification.md" (+76/-8 lines). The file counts compare the staged tree with its first parent. Refs: #228 Staged-Tree: 3b92076
The verification report records a fresh independent review of the complete three-commit change range. The review found no Critical or Important findings and identified one Minor documentation inconsistency. The report attributes the review model, inspected evidence, reconstructed behavior, and execution boundaries. The corrected caller-null description now states that the native case proved an empty `EventArgs.Message` against a null inline `StatusMessage`. The inventory summary now includes accepted native184 composition, retained harness failures, and independent reviews. The summary keeps draft publication, CI, and local acceptance pending. The plan marks the whole-branch independent review task as complete. The report states that the reviewer executed no tests, builds, application, verification writer, or user interface. The report also preserves remaining runtime, visual, localization, operating, lifetime, ABI, integration, and release limits. The final verdict remains contingent on final-head CI, actual Project fields, and immediate local acceptance readback. Changed files: - "docs/governance/document-inventory.json" (+1/-1 lines). - "docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md" (+1/-1 lines). - "docs/superpowers/reports/2026-11-11-configmaker-status-presentation-verification.md" (+22/-2 lines). The file counts compare the staged tree with its first parent. Refs: #228 Staged-Tree: 8ff3309
The design defines a typed owner for nine Welcome migration display values and two synchronous display policies. The owner preserves raw values, default equality behavior, notification order, reentry effects, and exception boundaries. The host retains eligibility, session, queue, import, lifecycle, and readiness responsibilities. The specification documents exact status and error lookup sequences, host forwarding, constructor composition, and explicit scope exclusions. The document attributes Project admission and the builder verdict to recorded evidence. The document also distinguishes portable owner checks from native host composition and broader integration qualification. The implementation plan divides the work into managed extraction and native composition stages. The first stage covers characterization, controlled mutation, source guards, managed tests, and the normal GUI build. The second stage defines six native composition groups while retaining the existing 184-case corpus. The plan keeps loaded wizard, operating migration, installed-product, integration, and release acceptance outside this stage. The governance inventory registers both documents with their language policy and ownership summary. Changed files: - "docs/governance/document-inventory.json" (+20/-0 lines). - "docs/superpowers/plans/2026-11-11-welcome-migration-presentation.md" (+141/-0 lines). - "docs/superpowers/specs/2026-11-11-welcome-migration-presentation-design.md" (+174/-0 lines). The file counts compare the staged tree with its first parent. Refs: #231 Staged-Tree: 8a89eae
The change moves nine migration display values into `WelcomeMigrationPresentation<TSeverity>`. The owner preserves defaults, equality suppression, raw nullable values, and derived ready-content visibility. The host retains private-set accessors and forwards owner notifications through its existing observable interface. The owner resolves status resources in assignment order and accepts explicit initial and error severities. The error policy selects nonblank localized text, appends the error code, and exposes retry visibility. The host keeps final Next-button disabling after the error policy returns. The tests characterize defaults, setter equality, numeric edge cases, notification order, nested updates, callback failures, partial state, and independent instances. The test project links the owner and display-item sources for direct coverage. The plan marks the managed implementation and verification tasks complete. The verification report records focused characterization, mutation results, full-suite results, build evidence, preservation checks, and pending native delivery gates. The governance inventory records the plan history and adds the verification report. Changed files: - "CDPIUI.Tests/CDPIUI.Tests.csproj" (+2/-0 lines). - "CDPIUI.Tests/Presentation/WelcomeMigrationPresentationTests.cs" (+430/-0 lines). - "CDPIUI/ViewModels/Welcome/WelcomeMigrationPresentation.cs" (+108/-0 lines). - "CDPIUI/ViewModels/Welcome/WelcomeViewModel.Migration.cs" (+22/-45 lines). - "CDPIUI/ViewModels/Welcome/WelcomeViewModel.cs" (+4/-0 lines). - "docs/governance/document-inventory.json" (+13/-3 lines). - "docs/superpowers/plans/2026-11-11-welcome-migration-presentation.md" (+7/-7 lines). - "docs/superpowers/reports/2026-11-11-welcome-migration-presentation-verification.md" (+136/-0 lines). The file counts compare the staged tree with its first parent. Refs: #231 Staged-Tree: 01874d9
The verification report records the product checkpoint and the technically compiled 190-group Welcome fixture. The report distinguishes inspected source scenarios from runtime evidence because no new native execution exists. The recorded build completed with zero warnings and errors, while source reconstruction, input pins, resources, executable metadata, and artifact hashes are documented. The six new groups cover composition, accessors, owner state, dispatch, localization, continuations, faults, retries, and observer effects. The report identifies derived-observer and missing-key behavior as unexecuted runtime conditions. The prepared view rejects operating endpoints, and cleanup affects only test observers and the owned framework cancellation source. The plan and design permit source review, an incomplete stacked draft, and hosted exact-head CI before native execution. The external user stop still blocks UI execution, native runs, and queue handoffs. The remaining gates include runtime review, Project field readback, local acceptance, and completed-state confirmation. The inventory now records the report introduction commit and summarizes the expanded evidence boundaries. Changed files: - "docs/governance/document-inventory.json" (+3/-3 lines). - "docs/superpowers/plans/2026-11-11-welcome-migration-presentation.md" (+8/-0 lines). - "docs/superpowers/reports/2026-11-11-welcome-migration-presentation-verification.md" (+45/-14 lines). - "docs/superpowers/specs/2026-11-11-welcome-migration-presentation-design.md" (+13/-1 lines). The file counts compare the staged tree with its first parent. Refs: #231 Staged-Tree: 9c4caa9
The plan records verified human authorization to resume the Welcome UI scope while preserving the earlier Esc stop and blocked packet. The plan keeps native execution dependent on fresh review, peer idle, and an exact new grant. The verification report distinguishes the Welcome, Project, and Lessons authorizations and states that their scopes are not interchangeable. The report documents the reviewed commit range, retained evidence, and the absence of native fixture execution or final acceptance. It attributes no product findings of Critical or Important severity to the independent source review. The report describes isolated failures in optimized Python checks and queue replacement behavior. The additive `native-operational-r2` packet rejects optimized execution and disables queue mutation entrypoints before state access. The report states that four regression groups cover optimized recipes, disabled mutations, competing ownership, and lease refusal. The report also documents Root-only grant and release serialization under a named mutex. Two deferred coverage observations remain for setter comparisons and cold-host event timing. Changed files: - "docs/superpowers/plans/2026-11-11-welcome-migration-presentation.md" (+8/-0 lines). - "docs/superpowers/reports/2026-11-11-welcome-migration-presentation-verification.md" (+52/-5 lines). The file counts compare the staged tree with its first parent. Staged-Tree: 0a82ed8
The plan marks source review, fixture preparation, exclusive native execution, and independent runtime review as complete. The plan keeps draft publication, delivery-head checks, Project completion, and local acceptance pending. The verification report records one bounded asInvoker run with 190 unique passing groups, zero failures, empty streams, and preserved earlier outputs. The report documents process absence, queue release, pinned inputs, retained-runtime evidence, and an independent review with no blocking findings. The report also records successful draft-head hosted checks and the observed PR Project metadata. The stated runtime boundary excludes loaded-window, visual, migration, cancellation, concurrency, installed-product, and other untested behavior. The design now distinguishes the historical UI stop from the later verified human resumption. The design describes corrected operational controls, sole Root coordination, fresh peer readiness, grant 173, and release 174. The documents attribute constructor coldness to inspected source because runtime observation began after observer subscription. The final delivery-head CI, completed Project readback, and case-specific local acceptance remain pending. Changed files: - "docs/superpowers/plans/2026-11-11-welcome-migration-presentation.md" (+5/-5 lines). - "docs/superpowers/reports/2026-11-11-welcome-migration-presentation-verification.md" (+53/-6 lines). - "docs/superpowers/specs/2026-11-11-welcome-migration-presentation-design.md" (+12/-1 lines). The file counts compare the staged tree with its first parent. Staged-Tree: 7f1ccd0
The report now identifies the technical checkpoint as a historical state rather than a current authorization. The checkpoint allowed source review, draft publication, and hosted CI before runtime under the documented external-stop amendment. The report states that native review, Project fields, and local acceptance were mandatory and incomplete at that time. The report now distinguishes the acceptance of Parents13, Parents14, Parents15, and earlier drafts as separate acceptance. The revised wording preserves the boundary that the report does not merge those records or declare Task2 complete. The resumption section now describes Root execution and verification status at that historical checkpoint. The report directs readers to later sections for the subsequent native and Project results. The report keeps final local acceptance pending until delivery-HEAD checks and completed, Done, and readback confirmation occur. Changed files: - "docs/superpowers/reports/2026-11-11-welcome-migration-presentation-verification.md" (+7/-5 lines). The file counts compare the staged tree with its first parent. Staged-Tree: 989df9b
The normal merge composes the ConfigMaker status and Welcome migration owners from frozen PR 232, including PR 230, with accepted main d211675. The existing owner implementations and tests retain their published bytes. The composed test project retains all 130 main Compile inputs and adds the three frozen owner links. The document inventory preserves every main record and adds six historical records with their original introduction commits and authors. The integration spec, plan and report separate the completed retained baseline from pending candidate, native, review, CI and main acceptance. The first-introduction pins for the three new documents remain pending until this commit exists. The change preserves all original branch heads and RESW, language and Tray font inputs from main. The source composition check and document governance check pass; no candidate SDK or native result is claimed. Refs #234 Changed files: - "CDPIUI.Tests/CDPIUI.Tests.csproj" (+3/-0 lines). - "CDPIUI.Tests/Presentation/ConfigMakerStatusPresentationTests.cs" (+429/-0 lines). - "CDPIUI.Tests/Presentation/WelcomeMigrationPresentationTests.cs" (+430/-0 lines). - "CDPIUI/ViewModels/ConfigMaker/ConfigMakerStatusPresentation.cs" (+68/-0 lines). - "CDPIUI/ViewModels/ConfigMaker/ConfigMakerViewModel.cs" (+22/-34 lines). - "CDPIUI/ViewModels/Welcome/WelcomeMigrationPresentation.cs" (+108/-0 lines). - "CDPIUI/ViewModels/Welcome/WelcomeViewModel.Migration.cs" (+22/-45 lines). - "CDPIUI/ViewModels/Welcome/WelcomeViewModel.cs" (+4/-0 lines). - "docs/governance/document-inventory.json" (+90/-0 lines). - "docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md" (+108/-0 lines). - "docs/superpowers/plans/2026-11-11-welcome-migration-presentation.md" (+157/-0 lines). - "docs/superpowers/plans/2026-11-14-presentation-owner-integration.md" (+32/-0 lines). - "docs/superpowers/reports/2026-11-11-configmaker-status-presentation-verification.md" (+194/-0 lines). - "docs/superpowers/reports/2026-11-11-welcome-migration-presentation-verification.md" (+263/-0 lines). - "docs/superpowers/reports/2026-11-14-presentation-owner-integration.md" (+42/-0 lines). - "docs/superpowers/specs/2026-11-11-configmaker-status-presentation-design.md" (+127/-0 lines). - "docs/superpowers/specs/2026-11-11-welcome-migration-presentation-design.md" (+197/-0 lines). - "docs/superpowers/specs/2026-11-14-presentation-owner-integration-design.md" (+30/-0 lines). The file counts compare the staged tree with its first parent. Staged-Tree: 3f08cae
The inventory replaces three pending introduction placeholders with merge commit `8dc3b8aaffb92e043d3f27d39538e5acd8e86094`. Each affected record now contains the merge hash, author, and subject in `firstIntroduction`. Each `first_commit` field now contains the same merge hash. The integration report identifies the accepted-main and frozen232 parents of the normal merge. The report states that the inventory was the only conflict and describes how the resolution preserved baseline records. The report also records the resulting 133 unique compile items and retention of both current-main language links. The report documents source composition verification before and after the merge. The documented checks cover product and test blobs, fixed refs, ancestry, historical inventory rows, and the baseline closure pin. The report records governance inspection of 180 Markdown files and a clean whitespace check. The report distinguishes these source checks from product execution and keeps acceptance work pending. Changed files: - "docs/governance/document-inventory.json" (+6/-6 lines). - "docs/superpowers/reports/2026-11-14-presentation-owner-integration.md" (+2/-2 lines). The file counts compare the staged tree with its first parent. Staged-Tree: e0a3fe2
The integration report now records fresh managed, font, GUI, resource, source-shape, and compiled-shape candidate results for the composed presentation changes. The report identifies the tested source, retained artifact closures, runtime versions, warning baseline, resource coverage, and independent review outcomes. The documented results distinguish measured compatibility from broader ABI, runtime identity, and product behavior guarantees. The native section records fresh 190-case host execution and a separate six-event real-close tail. The report documents fixture provenance, runner controls, process identities, releases, retained evidence pins, permitted file additions, and execution boundaries. The documented acceptance applies only to the declared instrumented cold-host and close scenarios. The plan now marks stages 1 through 6 complete and keeps stage 7 active. The remaining gates include whole-branch review, published-HEAD CI, metadata checks, original pull-request disposition, main integration, post-checks, and closeout. The governance inventory now reflects the accepted candidate and native stages while preserving the pending delivery boundaries. Changed files: - "docs/governance/document-inventory.json" (+2/-2 lines). - "docs/superpowers/plans/2026-11-14-presentation-owner-integration.md" (+3/-1 lines). - "docs/superpowers/reports/2026-11-14-presentation-owner-integration.md" (+39/-4 lines). The file counts compare the staged tree with its first parent. Staged-Tree: d7c38a2
The report now records three operational findings that closed before native execution. The V1 review found that its 45-second timer excluded identity and start-record work. The V2 runner starts timing immediately before `Popen` and measures the complete launch duration against the same limit. The independent V3 review identified missing final authority verification and insufficient shutdown binding for accepted host outputs. The documented V3 runner checks authority, STOP state, host runtime, current outputs, process identity, preserved closure, and permitted additions. The report attributes 14 initial assertion failures and later successful results to eight regression controls for the V3 findings. The report also records all 56 operational controls as successful and retains the original packets and failed controls. The report separates Windows and POSIX path-separator failures in Root prechecks from product and runtime changes. The coordinator normalized those comparisons while preserving failed preparations. A separate receipt correction normalized consumed SHA strings. The document states that these preparation changes affected no product, fixture, or binary bytes and triggered no native replay. Changed files: - "docs/superpowers/reports/2026-11-14-presentation-owner-integration.md" (+3/-1 lines). The file counts compare the staged tree with its first parent. Staged-Tree: 7741cd1
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Explicit original PR disposition before aggregate integrationIssue #234 now has independently accepted candidate managed/native evidence, final whole-branch review on Before the aggregate merge, explicitly retarget PR230 from This route follows the coordinator's retained conditional decision |
Problem
The accepted ConfigMaker status and Welcome migration presentation owners remain on frozen PR230/232 branches. Current main contains later language, RESW and Tray font changes. This integration composes those owners with accepted main and preserves their public surfaces and observable behavior.
Changes
The normal merge retains main
d21167564afbf60a0c6ad5b5f559a464c1e261f6and frozen2325c7a9459589b6d8c18a794d675c29ac0ed285e54as parents. Frozen230 remains an ancestor. The five product paths and two test files retain their published frozen blobs. The test project keeps all130 main Compile items and adds exactly3 links, for133 unique inputs. Current-main language, RESW and font changes remain present.The document inventory preserves all historical rows and authorship. The new integration spec, plan and report identify the exact revisions, executed checks and remaining boundaries. All eight original branch heads remain preserved.
Verification
Executed local source checkpoint is
2a2ddcc748add4ea63ccbed498847352c549e86e. The fresh retained d211 baseline passed2600 managed and10 font tests. The composed candidate passed86 focused,2684 unfiltered managed and10 font tests, with zero failed/skipped/error/aborted results. All2600 baseline actual test IDs remain present in the complete candidate run. Normal Release/x64 GUI build/publish and source/compiled surface comparisons pass. The source/loose/embedded/PRI resource values match current RESW.The new190-group and separate Close/Low/Exit fixture builds pass with522 pinned binary files each, asInvoker/uiAccess=false and current resource parity. Independent source, candidate SDK and fixture source/build reviews report no blocking product findings. Each GUI build emits220 existing WMC1506 warning lines, matching the baseline after source-root normalization. Historical Welcome first-value assertion coverage remains a disclosed Minor.
Actual native grant281 ran190 canonical groups plus COMPLETE, with one process exit0 and no failed groups or child streams. After independent host acceptance and actual release282, separate grant283 ran the six ordered real-close/Low/Exit events with registry counts2/1/1/0/0/0, one actual exit, process exit0 and empty streams. The same fresh independent reviewer accepted both outcomes. Root separately verified all6883 baseline bytes,98 pinned inputs, permitted six host outputs and one tail log, qualified owned process absence and actual release284. Combined native acceptance SHA256 is
87C28F894C04EAD219FCB310EA38AED8C0E08505427C6568E846F49B88248AAE.Published documentation HEAD is
793f7319f225cd4abddc69e8cda8b8dca6323a03. Exactly three documentation paths differ from tested2a2; all product, test, project, resource and build inputs have identical Git blobs. The verification report records commands, artifact pins, failures corrected before execution and scoped limits. The final review documentation Minor was corrected: the report now records the V1 timer finding/V2 correction before the two V3 fixes, with preparation-tool failures kept distinct. The same fresh independent reviewer accepted the complete final branch with zero Critical/Important/new Minor findings (receipt SHA256720B0DB6E28F8AC90DC1346745C27680DE43128118DBF0282AEE9840B4F9A324). Exact-HEAD PR CI, CodeQL, governance and contribution metadata pass. Actual Project7 items234/302235576 and240/304479216 were read after table/board reload as Review/P2/Architecture/Low, with lumenpearson/G2/canonical labels, under grant285 and actual release286. The existing auto-added PR card was reused; zero cards were added. Normal integration completed as99e3701f00ac1b7045238b6b2c99f2073d15eb9b, with the final reviewed tree and exact d211/793 parents. GitHub reports actual merged dispositions for original230/232. All eight original remote heads remain preserved. Post-main CI, CodeQL and governance pass, with raw2684+10 tests/0failed0skipped and file+13-added-commit secret scans. Main setup-msi14086360517 ZIP digest isb51277b2f33e67a2d38abf564f631cb97f2154de4996bfc2403c88b975809975, confirmed by API and upload log; no installation claim. Issue234 is accepted and closed as completed with7/7 criteria. Actual Project7 readback under287/actual release288 confirms all four existing cards234/240/230/232 Done/P2/Architecture/Low, with lumenpearson/G2/canonical labels. Exactly4 Status writes,0 other field writes and0 additions. The final source owner independently checked13 proofs, original table/two board images and AX; Root independently accepted the same facts. Release SHA256 is37B108286D596B6E4535B1BA5F3A01805B586514365A27DB463B6677445B26EA. Frozen branches and foreign work remain preserved; broader G1/G3-G5/installed/release boundaries stay separate.Risk and recovery
The product delta moves local presentation state behind narrow typed callbacks. Preserve raw values, object identity, notification sender/order, reentry, exceptions, localization interleaving and the Welcome Next tail. The bounded native fixtures do not accept the broader functional, accessibility, installed-product or release matrix. If a required gate fails, preserve evidence and stop integration. Recovery must preserve the original frozen refs and foreign work.
Related work
Refs #234. Original changes: #230 and #232. RESW/font dependencies: #237, #238 and #239. Broader acceptance and owner adoption remain in their existing tasks, including #13, #15 and #236.
Maintainer checks
type:label and at least onearea:label.