Skip to content

refactor: extract ConfigMaker status message presentation - #230

Merged
lumenpearson merged 4 commits into
mainfrom
dev/configmaker-status-presentation
Nov 13, 2026
Merged

lumenpearson merged 4 commits into
mainfrom
dev/configmaker-status-presentation

Conversation

@lumenpearson

@lumenpearson lumenpearson commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Problem

ConfigMakerViewModel mixes inline status values and ordered message publication with editor, document, help and test composition. A notification callback can change the inline setting or show another message before the outer sequence continues. This local extraction gives that status pipeline one owner while preserving the original observation points.

Changes

  • Add internal ConfigMakerStatusPresentation for four observable values, an explicit initial severity and three stored cold title/notice/inline callbacks.
  • Keep the four original host accessor visibilities, including public IsStatusOpen, and public ShowEditorMessage as forwards. One synchronous bridge keeps the VM PropertyChanged sender.
  • Preserve the literal host severity/localizer adapter, current event lookup, existing EventArgs construction and current UseInlineStatusMessages. EventArgs still normalizes null strings to empty; inline values retain raw null. Unknown severity remains raw.
  • Preserve resolve-title, notice, one late inline read and ordered title/message/severity/open assignments, or disabled close only. Nested values stay current while outer locals continue; equality, exception identity, partial effects and retries retain their old behavior.
  • Keep all other eight ConfigMaker partials, UserControl/second sender bridge, resources, XAML, packages, settings/background, logging, document/help/test/timer/IO workflows and Core/AddOns/Shared/security unchanged.
  • Reduce the main source from 381 to 369 lines and its nine-partial sum from 986 to 974. The focused owner has 68 physical lines. This separates an owned pipeline rather than splitting files to meet a line threshold.

Verification

Windows/.NET 8.0.427. Product pin 05e00619c256ebde45b79f4688154d4aa33b9876; later evidence commits change documentation only. Final publication HEAD: b0f2c93d66000eb02cd963cf4421173980686e95.

  • Missing-owner CS0246 observed before owner/link implementation. All 37 focused behavior cases preceded product code. First run: 37/37 in 30 ms, no warnings.
  • Early-inline mutant: 21 failed, 16 passed, 37 total in 40 ms, no compilation error. Exact owner restored in finally to SHA256 E6F6A012E6DF7C31EEFDF58B83DC07CDE9A652517B6B824F976F5C56E3EC5BD9; restored 37/37 in 27 ms. The wrapper's cp1251 printing error occurred after saving the actual test failure, before its assertion; retained log/exit/hash were separately validated without a replacement rerun.
  • dotnet test CDPIUI.Tests/CDPIUI.Tests.csproj -c Release --no-restore: 2625/2625 in 10 s, zero failures/skips.
  • dotnet build CDPIUI/CDPIUI.csproj -c Release -p:Platform=x64 --no-restore: zero warnings/errors in 45.10 s. Normal GUI SHA256 950A924D49B387DE0355CE4BB39680AA343D4DC731ADFF7859160280E9A4D3D8.
  • Source signatures for 451 exported types across 621 to 622 GUI C# files and compiled 452 GUI/88 Core retained shapes have zero drift within their documented limits. Whole-host/literal policy/four defaults/equality/accessors/three cold ports/current event/one bridge/constructor order/other partial/footprint/source-link guards pass.
  • NEW immutable native fixture built with zero warnings/errors in 78.00 s from product05e. Independent pre-build/prelaunch/retained-runtime reviews found no actionable issue. All 1608 source inputs, 21 inherited cuts (20 raw identical plus one EXE literal), 35 old raw case partials, 37 bootstraps/41 extras/no reparse are reconstructed. Actual pins: 77 inputs, comprising 5 binaries, 20 resources and 52 source/evidence files; all 522 prior filenames/hashes. All 20 resources equal generated bytes and 5206 source JSON entries; 54 keys checked.
  • New grant 151: one PID 89224 ran from 2026-11-11T19:02:26.2190286Z to 19:02:32.4840147+00:00. All 184 unique groups passed, with the exact 178/older prefixes and peer141 projection, one COMPLETE, zero FAIL, exit0 and empty streams. All 77 pins/522 prior hashes/source/resources, three literal inputs of 16/16/15 bytes, two golden outputs of 354/260 bytes, exactly six new names from 522 to 528, forbidden/custom absence and unchanged normal GUI passed. Separate PID/exact EXE absence, idle151/requestfalse/pendingfalse/release152.previous151/all six paused were verified. No second launch.
  • Actual cold ConfigMakerVM/closed owner/current dispatcher/private/public setters/VM sender, real severity text/raw enum/EventArgs-versus-inline null, late flag/nesting/equality/partial faults/retry/independent hosts are qualified. Native model workflows stay cold and view operating endpoints reject.
  • Governance: 168 Markdown files, zero errors, redacted changed-file scans and whitespace checks pass. Initial link-anchor/guard/count-print and physical 69-to-68 corrections remain documented; product behavior was not changed to hide these harness failures.

Fresh whole-range reviewer configmaker_status_final_review (gpt-6-astra/xhigh) reviewed 3afa82e..a3b7252: zero Critical, zero Important and one Minor concerning two stale documentation phrases. The final documentation-only commit corrects those records and records the review. Product, tests, native case/pins and runtime outputs remain unchanged. The coordinated peer reviews and fresh final review have distinct attribution.

Evidence: design, plan, verification.

Full loaded Page/UserControl, its second sender bridge at runtime, visual EN/RU/accessibility, actual operating workflows, GC/thread extensions, all metadata/native ABI, installed product, G1, integration and release remain separate. Native title-null/localization-subscriber mutation/arbitrary inline-port failures are managed/source-only boundaries.

Risk and recovery

P2/Low because this moves local display state without persistence or operating-route changes. Callback ordering and raw-versus-normalized strings are the main preservation risks. Keep the typed owner per host, the current observation points and the exact partial state after failure. Repair through an additive corrective commit; retain all refs, worktrees, archives and accepted/rejected artifacts. No parent/main merge or destructive cleanup is part of this local stage.

Related work

Refs #228. Refs #14. Stack on frozen PR227/dev/store-download-presentation at 3afa82e3f4947ce4bef38b14d86c642c93ddbe90. Local #225 is completed with all six criteria, actual Done147, final receipt6803654520 and post-criterion metadata43075493266 success on its own pin. Parents #13/#14/#15 and earlier drafts remain open/unmerged; integration and release have their own acceptance.

Maintainer checks

  • Link the owning task and complete contract in docs/task-lifecycle.md.
  • Read back actual issue and Project fields; body classification alone is insufficient.
  • Set exactly one type: label and at least one area: label.
  • Set an assignee and the owning G1 to G5 milestone.
  • Add the PR to the delivery Project. Set Status, Priority, Area and Risk.
  • Record dependencies and the previous status for blocked work.
  • Complete independent review and resolve review conversations.
  • Verify required checks on the final HEAD. Record native verification when relevant.
  • Update EN/RU instructions and release notes when behavior changes.

Issue #228 actual Project intake149 was independently read after fresh navigation: In progress/P2/Architecture/Low/G2/lumenpearson/exactly type:refactor+area:architecture. PR230 metadata, actual Project intake and exact final-head checks were read back successfully. Product resources/instructions/release notes remain unchanged because public behavior is preserved. The six-section LOCAL acceptance record is issue comment6805594637. Issue228 is closed as completed with all six criteria checked and actual Project Done verified after fresh navigation under157; PR230 stays open, draft and In progress.

Actual PR230 Project intake under NEW157 was verified by fresh navigation and full AX/screenshot/view URL: In progress/P2/Architecture/Low/G2/lumenpearson/exactly type:refactor+area:architecture. Exact final-head CI43086922084 (four jobs), CodeQL43086922181, Governance43086922105 and Contribution metadata43086933714 succeeded; hosted libraries130753615189 passed2625/2625/8s,0fail/skip. Issue228 local acceptance/closure/Done follows its explicit local contract; later metadata edits require a fresh authoritative commit status read.

The design defines `ConfigMakerStatusPresentation<TSeverity>` as the focused owner of four status values and their ordered publication sequence. The owner receives three cold callback ports and preserves raw severity, nullable inline strings, equality behavior, and partial state after failures.

The document keeps localization, notification construction, sender behavior, and the inline flag within the existing host adapters. The specified sequence resolves the title, raises the notice, reads the flag once, and conditionally updates four properties in order. The documented boundaries exclude unrelated partials, user controls, resources, workflows, platform surfaces, and release acceptance.

The implementation plan separates portable characterization from native composition qualification. The plan records focused tests, a controlled ordering mutation, full managed checks, host guards, bounded native evidence, and independent reviews as pending work. The governance inventory registers both documents with their language policy, authorship metadata, and summarized scope.

Changed files:

- "docs/governance/document-inventory.json" (+20/-0 lines).
- "docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md" (+108/-0 lines).
- "docs/superpowers/specs/2026-11-11-configmaker-status-presentation-design.md" (+127/-0 lines).

The file counts compare the staged tree with its first parent.

Refs: #228
Staged-Tree: c273657
The change moves four observable status values from ConfigMakerViewModel into ConfigMakerStatusPresentation<TSeverity>. The view model retains its public accessors and forwards property notifications from the new owner. The ShowEditorMessage method now delegates status publication through the typed presentation object.

The presentation resolves the title, raises the current notice callback, and reads the inline setting once afterward. The presentation publishes title, message, severity, and open state in their existing order when inline display is enabled. The disabled path closes the current status without replacing the other values. The stored callbacks remain inactive during construction.

The new tests characterize equality suppression, raw nullable values, callback ordering, nested calls, exception identity, partial updates, retries, and independent instances. The test project links the presentation source for direct coverage.

The plan marks the completed managed implementation and build activities. The verification report records observed test, mutation, build, and contract results while identifying native and delivery qualification as pending. The governance inventory records the plan history and adds the verification report.

Changed files:

- "CDPIUI.Tests/CDPIUI.Tests.csproj" (+1/-0 lines).
- "CDPIUI.Tests/Presentation/ConfigMakerStatusPresentationTests.cs" (+429/-0 lines).
- "CDPIUI/ViewModels/ConfigMaker/ConfigMakerStatusPresentation.cs" (+68/-0 lines).
- "CDPIUI/ViewModels/ConfigMaker/ConfigMakerViewModel.cs" (+22/-34 lines).
- "docs/governance/document-inventory.json" (+13/-3 lines).
- "docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md" (+6/-6 lines).
- "docs/superpowers/reports/2026-11-11-configmaker-status-presentation-verification.md" (+106/-0 lines).

The file counts compare the staged tree with its first parent.

Refs: #228
Staged-Tree: b7e14a2
The inventory records commit 05e0061 as the verification report's first introduction. The plan marks source review, fixture construction, exclusive leasing, and the single owned process run as complete.

The report corrects the typed owner's physical size from 69 lines to 68 lines. The native qualification documents the immutable fixture, reconstructed inputs, preserved scenario data, independent reviews, and pinned artifact hashes. The build record reports zero warnings and errors, while the execution record reports 184 unique passing groups and no failures. The evidence also records one completed process, empty output streams, retained hash checks, and guarded lease release.

The six new groups cover cold models, accessor behavior, severity text, notification state, nested effects, observer faults, retries, and instance independence. The report distinguishes normalized EventArgs values from nullable inline state and limits reflection to private member characterization. The stated boundaries exclude operating endpoints, desktop input, elevation, file operations, and unrelated workflows. The remaining section keeps delivery gates and unsupported native mutation cases pending.

Changed files:

- "docs/governance/document-inventory.json" (+2/-2 lines).
- "docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md" (+3/-3 lines).
- "docs/superpowers/reports/2026-11-11-configmaker-status-presentation-verification.md" (+76/-8 lines).

The file counts compare the staged tree with its first parent.

Refs: #228
Staged-Tree: 3b92076
The verification report records a fresh independent review of the complete three-commit change range. The review found no Critical or Important findings and identified one Minor documentation inconsistency. The report attributes the review model, inspected evidence, reconstructed behavior, and execution boundaries.

The corrected caller-null description now states that the native case proved an empty `EventArgs.Message` against a null inline `StatusMessage`. The inventory summary now includes accepted native184 composition, retained harness failures, and independent reviews. The summary keeps draft publication, CI, and local acceptance pending.

The plan marks the whole-branch independent review task as complete. The report states that the reviewer executed no tests, builds, application, verification writer, or user interface. The report also preserves remaining runtime, visual, localization, operating, lifetime, ABI, integration, and release limits. The final verdict remains contingent on final-head CI, actual Project fields, and immediate local acceptance readback.

Changed files:

- "docs/governance/document-inventory.json" (+1/-1 lines).
- "docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md" (+1/-1 lines).
- "docs/superpowers/reports/2026-11-11-configmaker-status-presentation-verification.md" (+22/-2 lines).

The file counts compare the staged tree with its first parent.

Refs: #228
Staged-Tree: 8ff3309

Copy link
Copy Markdown
Owner Author

Explicit original PR disposition before aggregate integration

Issue #234 now has independently accepted candidate managed/native evidence, final whole-branch review on 793f7319f225cd4abddc69e8cda8b8dca6323a03, green current-HEAD CI and actual private Project intake. Aggregate PR #240 preserves the accepted d211 main and the exact frozen PR230/232 ancestry through a normal additive merge. All sixteen local/cached refs and eight live remote heads were freshly read back unchanged. Repository settings read back allow_merge_commit=true and delete_branch_on_merge=false.

Before the aggregate merge, explicitly retarget PR230 from dev/store-download-presentation@3afa82e3f4947ce4bef38b14d86c642c93ddbe90 to main@d21167564afbf60a0c6ad5b5f559a464c1e261f6, and PR232 from dev/configmaker-status-presentation@b0f2c93d66000eb02cd963cf4421173980686e95 to that same main. Their source heads remain exactly b0f2c93d66000eb02cd963cf4421173980686e95 and 5c7a9459589b6d8c18a794d675c29ac0ed285e54. This records their intended integration destination while preserving the original published commits and branches; there is no rebase, cherry-pick, reset, force push or branch deletion.

This route follows the coordinator's retained conditional decision A5F66C2C1A0BBA25D14759C2C2140481A8450096D598F633FCDBD94DDE31B3F2. Read actual GitHub merged booleans and merge SHAs after the normal PR240 merge. Commit reachability alone does not establish original PR disposition or authorize Project Done. If indirect merged marking does not occur, stop the disposition claim and agree an honest normal-merge route with the coordinator. Post-main CI and final issue/Project acceptance remain required.

@lumenpearson
lumenpearson changed the base branch from dev/store-download-presentation to main November 13, 2026 23:21
@lumenpearson
lumenpearson merged commit b0f2c93 into main Nov 13, 2026
20 of 21 checks passed

Copy link
Copy Markdown
Owner Author

Integrated disposition verified

GitHub reports this PR as actually merged after its explicit recorded retarget to main and the normal PR240 integration. Actual API merge SHA: b0f2c93d66000eb02cd963cf4421173980686e95; preserved original head: b0f2c93d66000eb02cd963cf4421173980686e95. Main integration is 99e3701f00ac1b7045238b6b2c99f2073d15eb9b, with the final independently reviewed tree. All eight original branches remain present at their frozen SHAs.

Current main CI43526566733, CodeQL43526566754 and governance43526566734 pass. Raw logs confirm2684 managed+10 font tests,0 failures/skips, both secret scans and GUI/MSI/tool builds. New190 and separate real-close tail acceptance are recorded in issue234. The broader installed/functional/release boundaries remain separate. Final issue234 closure and actual Project Done readback are queued behind the shared heavy-resource release; no closed-unmerged or inferred Done claim is made.

@lumenpearson lumenpearson moved this from In progress to Done in CDPI UI — Delivery & Release Gates Nov 13, 2026

Copy link
Copy Markdown
Owner Author

Final issue234 acceptance and Project readback are complete: six-section accepted record. Issue234 is closed as completed with7/7 criteria. This PR is actually merged, and its existing Project7 card is now independently verified Done/P2/Architecture/Low with lumenpearson/G2/canonical labels under grant287 and actual release288. Exactly four scoped Status writes, zero other field writes and zero added cards. All original source heads and remote branches remain preserved. The earlier pending procedural state is superseded by this actual final readback; broader G1/G3-G5/installed/release boundaries remain separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:architecture Decomposition, contracts, state ownership and lifecycle. type:refactor Change structure while preserving agreed behavior and contracts.

Projects

Development

Successfully merging this pull request may close these issues.

1 participant