Repository navigation
refactor: extract ConfigMaker status message presentation - #230
Conversation
The design defines `ConfigMakerStatusPresentation<TSeverity>` as the focused owner of four status values and their ordered publication sequence. The owner receives three cold callback ports and preserves raw severity, nullable inline strings, equality behavior, and partial state after failures. The document keeps localization, notification construction, sender behavior, and the inline flag within the existing host adapters. The specified sequence resolves the title, raises the notice, reads the flag once, and conditionally updates four properties in order. The documented boundaries exclude unrelated partials, user controls, resources, workflows, platform surfaces, and release acceptance. The implementation plan separates portable characterization from native composition qualification. The plan records focused tests, a controlled ordering mutation, full managed checks, host guards, bounded native evidence, and independent reviews as pending work. The governance inventory registers both documents with their language policy, authorship metadata, and summarized scope. Changed files: - "docs/governance/document-inventory.json" (+20/-0 lines). - "docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md" (+108/-0 lines). - "docs/superpowers/specs/2026-11-11-configmaker-status-presentation-design.md" (+127/-0 lines). The file counts compare the staged tree with its first parent. Refs: #228 Staged-Tree: c273657
The change moves four observable status values from ConfigMakerViewModel into ConfigMakerStatusPresentation<TSeverity>. The view model retains its public accessors and forwards property notifications from the new owner. The ShowEditorMessage method now delegates status publication through the typed presentation object. The presentation resolves the title, raises the current notice callback, and reads the inline setting once afterward. The presentation publishes title, message, severity, and open state in their existing order when inline display is enabled. The disabled path closes the current status without replacing the other values. The stored callbacks remain inactive during construction. The new tests characterize equality suppression, raw nullable values, callback ordering, nested calls, exception identity, partial updates, retries, and independent instances. The test project links the presentation source for direct coverage. The plan marks the completed managed implementation and build activities. The verification report records observed test, mutation, build, and contract results while identifying native and delivery qualification as pending. The governance inventory records the plan history and adds the verification report. Changed files: - "CDPIUI.Tests/CDPIUI.Tests.csproj" (+1/-0 lines). - "CDPIUI.Tests/Presentation/ConfigMakerStatusPresentationTests.cs" (+429/-0 lines). - "CDPIUI/ViewModels/ConfigMaker/ConfigMakerStatusPresentation.cs" (+68/-0 lines). - "CDPIUI/ViewModels/ConfigMaker/ConfigMakerViewModel.cs" (+22/-34 lines). - "docs/governance/document-inventory.json" (+13/-3 lines). - "docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md" (+6/-6 lines). - "docs/superpowers/reports/2026-11-11-configmaker-status-presentation-verification.md" (+106/-0 lines). The file counts compare the staged tree with its first parent. Refs: #228 Staged-Tree: b7e14a2
The inventory records commit 05e0061 as the verification report's first introduction. The plan marks source review, fixture construction, exclusive leasing, and the single owned process run as complete. The report corrects the typed owner's physical size from 69 lines to 68 lines. The native qualification documents the immutable fixture, reconstructed inputs, preserved scenario data, independent reviews, and pinned artifact hashes. The build record reports zero warnings and errors, while the execution record reports 184 unique passing groups and no failures. The evidence also records one completed process, empty output streams, retained hash checks, and guarded lease release. The six new groups cover cold models, accessor behavior, severity text, notification state, nested effects, observer faults, retries, and instance independence. The report distinguishes normalized EventArgs values from nullable inline state and limits reflection to private member characterization. The stated boundaries exclude operating endpoints, desktop input, elevation, file operations, and unrelated workflows. The remaining section keeps delivery gates and unsupported native mutation cases pending. Changed files: - "docs/governance/document-inventory.json" (+2/-2 lines). - "docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md" (+3/-3 lines). - "docs/superpowers/reports/2026-11-11-configmaker-status-presentation-verification.md" (+76/-8 lines). The file counts compare the staged tree with its first parent. Refs: #228 Staged-Tree: 3b92076
The verification report records a fresh independent review of the complete three-commit change range. The review found no Critical or Important findings and identified one Minor documentation inconsistency. The report attributes the review model, inspected evidence, reconstructed behavior, and execution boundaries. The corrected caller-null description now states that the native case proved an empty `EventArgs.Message` against a null inline `StatusMessage`. The inventory summary now includes accepted native184 composition, retained harness failures, and independent reviews. The summary keeps draft publication, CI, and local acceptance pending. The plan marks the whole-branch independent review task as complete. The report states that the reviewer executed no tests, builds, application, verification writer, or user interface. The report also preserves remaining runtime, visual, localization, operating, lifetime, ABI, integration, and release limits. The final verdict remains contingent on final-head CI, actual Project fields, and immediate local acceptance readback. Changed files: - "docs/governance/document-inventory.json" (+1/-1 lines). - "docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md" (+1/-1 lines). - "docs/superpowers/reports/2026-11-11-configmaker-status-presentation-verification.md" (+22/-2 lines). The file counts compare the staged tree with its first parent. Refs: #228 Staged-Tree: 8ff3309
Explicit original PR disposition before aggregate integrationIssue #234 now has independently accepted candidate managed/native evidence, final whole-branch review on Before the aggregate merge, explicitly retarget PR230 from This route follows the coordinator's retained conditional decision |
Integrated disposition verifiedGitHub reports this PR as actually merged after its explicit recorded retarget to main and the normal PR240 integration. Actual API merge SHA: Current main CI43526566733, CodeQL43526566754 and governance43526566734 pass. Raw logs confirm2684 managed+10 font tests,0 failures/skips, both secret scans and GUI/MSI/tool builds. New190 and separate real-close tail acceptance are recorded in issue234. The broader installed/functional/release boundaries remain separate. Final issue234 closure and actual Project Done readback are queued behind the shared heavy-resource release; no closed-unmerged or inferred Done claim is made. |
|
Final issue234 acceptance and Project readback are complete: six-section accepted record. Issue234 is closed as completed with7/7 criteria. This PR is actually merged, and its existing Project7 card is now independently verified Done/P2/Architecture/Low with lumenpearson/G2/canonical labels under grant287 and actual release288. Exactly four scoped Status writes, zero other field writes and zero added cards. All original source heads and remote branches remain preserved. The earlier pending procedural state is superseded by this actual final readback; broader G1/G3-G5/installed/release boundaries remain separate. |
Problem
ConfigMakerViewModel mixes inline status values and ordered message publication with editor, document, help and test composition. A notification callback can change the inline setting or show another message before the outer sequence continues. This local extraction gives that status pipeline one owner while preserving the original observation points.
Changes
Verification
Windows/.NET 8.0.427. Product pin
05e00619c256ebde45b79f4688154d4aa33b9876; later evidence commits change documentation only. Final publication HEAD:b0f2c93d66000eb02cd963cf4421173980686e95.dotnet test CDPIUI.Tests/CDPIUI.Tests.csproj -c Release --no-restore: 2625/2625 in 10 s, zero failures/skips.dotnet build CDPIUI/CDPIUI.csproj -c Release -p:Platform=x64 --no-restore: zero warnings/errors in 45.10 s. Normal GUI SHA256 950A924D49B387DE0355CE4BB39680AA343D4DC731ADFF7859160280E9A4D3D8.Fresh whole-range reviewer configmaker_status_final_review (gpt-6-astra/xhigh) reviewed 3afa82e..a3b7252: zero Critical, zero Important and one Minor concerning two stale documentation phrases. The final documentation-only commit corrects those records and records the review. Product, tests, native case/pins and runtime outputs remain unchanged. The coordinated peer reviews and fresh final review have distinct attribution.
Evidence: design, plan, verification.
Full loaded Page/UserControl, its second sender bridge at runtime, visual EN/RU/accessibility, actual operating workflows, GC/thread extensions, all metadata/native ABI, installed product, G1, integration and release remain separate. Native title-null/localization-subscriber mutation/arbitrary inline-port failures are managed/source-only boundaries.
Risk and recovery
P2/Low because this moves local display state without persistence or operating-route changes. Callback ordering and raw-versus-normalized strings are the main preservation risks. Keep the typed owner per host, the current observation points and the exact partial state after failure. Repair through an additive corrective commit; retain all refs, worktrees, archives and accepted/rejected artifacts. No parent/main merge or destructive cleanup is part of this local stage.
Related work
Refs #228. Refs #14. Stack on frozen PR227/dev/store-download-presentation at
3afa82e3f4947ce4bef38b14d86c642c93ddbe90. Local #225 is completed with all six criteria, actual Done147, final receipt6803654520 and post-criterion metadata43075493266 success on its own pin. Parents #13/#14/#15 and earlier drafts remain open/unmerged; integration and release have their own acceptance.Maintainer checks
type:label and at least onearea:label.Issue #228 actual Project intake149 was independently read after fresh navigation: In progress/P2/Architecture/Low/G2/lumenpearson/exactly type:refactor+area:architecture. PR230 metadata, actual Project intake and exact final-head checks were read back successfully. Product resources/instructions/release notes remain unchanged because public behavior is preserved. The six-section LOCAL acceptance record is issue comment6805594637. Issue228 is closed as completed with all six criteria checked and actual Project Done verified after fresh navigation under157; PR230 stays open, draft and In progress.
Actual PR230 Project intake under NEW157 was verified by fresh navigation and full AX/screenshot/view URL: In progress/P2/Architecture/Low/G2/lumenpearson/exactly type:refactor+area:architecture. Exact final-head CI43086922084 (four jobs), CodeQL43086922181, Governance43086922105 and Contribution metadata43086933714 succeeded; hosted libraries130753615189 passed2625/2625/8s,0fail/skip. Issue228 local acceptance/closure/Done follows its explicit local contract; later metadata edits require a fresh authoritative commit status read.