Skip to content

Move genkit_llamadart compatibility to llamadart 0.19 - #1816

Merged
leehack merged 2 commits into
mainfrom
genkit-3-8
Nov 8, 2026
Merged

leehack merged 2 commits into
mainfrom
genkit-3-8

Conversation

@leehack

@leehack leehack commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Compatibility PR: widen genkit_llamadart to llamadart: ^0.19.0, qualified against published core 0.19.0 (version stays 3.7.0; changelog under Unreleased) (#1813, same flow as #1747).
  • Update the lower-bound pin ([email protected]) in CI and the Genkit publisher, the CI selection test, package README/CONTRIBUTING/migration/tool-schema docs, the package changelog, a "planned, not published yet" note in integrations/genkit.md, and maintainers/genkit-package.md.

Production-readiness scope

  • User-facing scope: Genkit users can adopt core 0.19.0; no plugin API change.
  • Supported platforms/paths: Existing adapter paths against published core 0.19.0; Flutter iOS/macOS use matching 0.19.x companions.
  • Unsupported or intentionally unavailable paths: Unchanged; core's typed LlamaUnsupportedException paths pass through.
  • Out of scope / follow-ups: None. Core and Apple companion versions untouched. Next steps, as 3.7 (#1780 → #1799 → #1803): two-file 3.8.0 release-prep PR with maintainer approval (publishes), then the website docs pairing after publication. This PR does not publish.

Completeness checklist

  • Declared scope is fully implemented, or explicitly reduced above.
  • Unsupported platform/option combinations fail loudly with actionable diagnostics or are clearly documented as unavailable. (unchanged)
  • Public API docs, README/website docs, examples, support matrices, and changelog entries are updated where relevant.
  • Regression coverage covers the original issue plus key negative/version-skew paths where relevant. (existing adapter suite and CI lower-bound leg)
  • Validation coverage registry: N/A, no capability change.
  • Security/privacy review completed: no secrets or paths touched.
  • Follow-up work: None.

PR type guidance

  • Feature PR: N/A, dependency/compatibility bump.

Test Plan

  • dart run tool/prepare_workspace.dart
  • dart format --output=none --set-exit-if-changed .
  • dart analyze N/A for root (no root Dart change); package: dart analyze --fatal-infos clean
  • dart test -p vm -j 1 --exclude-tags local-only N/A, no core change; ran test/unit/tooling/ci_workflow_selection_test.dart and package_skills_test.dart (pass)
  • dart test -p chrome --exclude-tags local-only N/A, no core change
  • coverage-lib N/A, no lib/ change
  • Package lanes in packages/genkit_llamadart (Flutter 3.47.1, hosted llamadart 0.19.0): dart pub get, format, dart analyze --fatal-infos, python3 .github/check_docs.py, dart test -x real-model (471 passed), staged dart pub publish --dry-run (0 warnings); verify_release_docs_versions.dart passes

Matrix Evidence

Matrix row Scope covered Platform / model / backend Result Evidence / notes
genkit package lanes analyze, docs, unit, publish dry-run macOS, Dart 3.12+, hosted core 0.19.0 Pass above
lower-bound, local-core, real-model, browser CI adapter job legs CI See CI real-model/model-backed checks run only in CI leg

Review Notes

  • Independent review status: PASS. Fresh agent session (independent-audit-session-1816, not the author) audited exact head 1903ae9: zero blocking findings, zero PR-caused P1. Merging publishes nothing: release_genkit_on_prep_merge.yml needs a release/genkit_llamadart-v... head or the release-prep:genkit_llamadart label, and release_on_prep_merge.yml needs release-prep plus a root pubspec change.
  • Audit commands: package lanes (format, dart analyze --fatal-infos, check_docs.py, 7 Python tests, 471 unit tests, lower-bound in-place analyze + 471 tests, staged publish dry-run with 0 warnings); root prepare/format/analyze, tooling suite (only 6 environmental pwsh-missing windows_registry failures), verify_release_docs_versions; merged-tree (head + e8201c800) markdown suites, ci_workflow_selection_test and genkit_llamadart_floor_pin_test (773 pass).
  • Mutations killed: ci.yml pin to 0.18.0 fails ci_workflow_selection_test ("Genkit lower bounds pin...") and genkit_llamadart_floor_pin_test; publish_genkit_pubdev.yml pin to 0.18.0 and package floor ^0.18.0 fail genkit_llamadart_floor_pin_test.
  • Readiness evidence (high_risk_readiness.dart, schema v2): unverifiedPrerequisites, exit 2 (internally consistent; external prerequisites are unconfigured by design).
  • CI status / head SHA: 1903ae9, CI run 42519498390 green, including Genkit (lower bounds and published) and Genkit (local core: 471 unit, 10/32 real-model, 122 browser).
  • Base: evidence is bound to merge base 60821c1. main has since moved to e8201c8 (#1817); it shares no files with this PR, mergeStateStatus is CLEAN, and the merged-tree check above passed.

High-risk regression review

  • Classification: high-risk (artifactConsumer, regressionPolicy, releaseAutomation)
  • Implementation task: this PR
  • Independent blocking QA task: independent-audit-session-1816, PASS at exact head
  • Exact head / current base: 1903ae9 / merge base 60821c1 (origin/main now e8201c8, no shared files)
  • Production-branch deletion, bypass, or miswire proof: N/A, version pins only; pin mutations killed by the tests above
  • Affected-family real-model/artifact evidence: CI run 42519498390, Genkit local core real-model leg 10/32 (pinned fixture subset), green
  • Explicit unavailable-family or other N/A evidence: N/A
  • Known PR-caused P1 regressions: 0
  • Unresolved review threads: 0

@leehack leehack changed the title Move genkit_llamadart to llamadart 0.19 (3.8.0) Move genkit_llamadart compatibility to llamadart 0.19 Nov 8, 2026
@leehack
leehack marked this pull request as ready for review November 8, 2026 20:54
@leehack
leehack merged commit 60c8fe3 into main Nov 8, 2026
43 checks passed
@leehack
leehack deleted the genkit-3-8 branch November 8, 2026 20:55
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Chat app preview removed for leehack/llamadart-chat-pr-1816.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant