Repository navigation
Move genkit_llamadart compatibility to llamadart 0.19 - #1816
Merged
Merged
Conversation
leehack
marked this pull request as ready for review
November 8, 2026 20:54
Contributor
|
Chat app preview removed for |
This was referenced Nov 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
genkit_llamadarttollamadart: ^0.19.0, qualified against published core 0.19.0 (version stays 3.7.0; changelog under Unreleased) (#1813, same flow as #1747).[email protected]) in CI and the Genkit publisher, the CI selection test, package README/CONTRIBUTING/migration/tool-schema docs, the package changelog, a "planned, not published yet" note inintegrations/genkit.md, andmaintainers/genkit-package.md.Production-readiness scope
LlamaUnsupportedExceptionpaths pass through.Completeness checklist
PR type guidance
Test Plan
dart run tool/prepare_workspace.dartdart format --output=none --set-exit-if-changed .dart analyzeN/A for root (no root Dart change); package:dart analyze --fatal-infoscleandart test -p vm -j 1 --exclude-tags local-onlyN/A, no core change; rantest/unit/tooling/ci_workflow_selection_test.dartandpackage_skills_test.dart(pass)dart test -p chrome --exclude-tags local-onlyN/A, no core changecoverage-libN/A, nolib/changepackages/genkit_llamadart(Flutter 3.47.1, hosted llamadart 0.19.0):dart pub get, format,dart analyze --fatal-infos,python3 .github/check_docs.py,dart test -x real-model(471 passed), stageddart pub publish --dry-run(0 warnings);verify_release_docs_versions.dartpassesMatrix Evidence
Review Notes
independent-audit-session-1816, not the author) audited exact head 1903ae9: zero blocking findings, zero PR-caused P1. Merging publishes nothing:release_genkit_on_prep_merge.ymlneeds arelease/genkit_llamadart-v...head or therelease-prep:genkit_llamadartlabel, andrelease_on_prep_merge.ymlneedsrelease-prepplus a root pubspec change.dart analyze --fatal-infos,check_docs.py, 7 Python tests, 471 unit tests, lower-bound in-place analyze + 471 tests, staged publish dry-run with 0 warnings); root prepare/format/analyze, tooling suite (only 6 environmentalpwsh-missingwindows_registryfailures),verify_release_docs_versions; merged-tree (head +e8201c800) markdown suites,ci_workflow_selection_testandgenkit_llamadart_floor_pin_test(773 pass).ci.ymlpin to 0.18.0 failsci_workflow_selection_test("Genkit lower bounds pin...") andgenkit_llamadart_floor_pin_test;publish_genkit_pubdev.ymlpin to 0.18.0 and package floor^0.18.0failgenkit_llamadart_floor_pin_test.high_risk_readiness.dart, schema v2):unverifiedPrerequisites, exit 2 (internally consistent; external prerequisites are unconfigured by design).mainhas since moved to e8201c8 (#1817); it shares no files with this PR,mergeStateStatusis CLEAN, and the merged-tree check above passed.High-risk regression review
independent-audit-session-1816, PASS at exact head