Repository navigation
Sweep #1815: macOS LiteRT-LM smoke, model-store floors, closed-stdout supervisor echo - #1828
Merged
Merged
Conversation
…osed-stdout supervisor echo
This was referenced Nov 8, 2026
leehack
marked this pull request as ready for review
November 9, 2026 00:11
Contributor
|
Chat app preview removed for |
This was referenced Nov 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testfloors, and a closed-stdout guard in the Chrome test supervisor.tool/litert_lm_library_smoke.dart: macOS arm64 is a supported host and resolveslibLiteRtLm.dylib.packages/llamadart_model_store/pubspec.yaml:flutter: ">=3.38.6"(first Flutter whose Dart 3.10.7 satisfiessdk: ^3.10.7) andtest: ^1.26.3(firsttestaccepting Flutter 3.38.6'stest_api0.7.7); rationale inwebsite/docs/maintainers/model-store-package.md.tool/ci/supervise_chrome_test.py:reserve_standard_descriptors()keeps a closed fd 0/1/2 from being reused by the nextopen(), which sent echoed output into the events file.Production-readiness scope
Completeness checklist
PR type guidance
Test Plan
Pinned Flutter 3.47.1, macOS arm64, head
6430609a437f499b8c8807f4af4e39c22018d426.dart run tool/prepare_workspace.dart: clean.dart format --output=none --set-exit-if-changed .: 0 changed.dart analyze: clean.check_platform_boundaries.dart: OK.dart test -p vm -j 1 --exclude-tags local-only: CI green;test/unit/tooling+1608 ~5 -6 locally (the 6 failures are the missing-pwshwindows_registry tests only).dart test -p chrome --exclude-tags local-only: N/A, nolib/or Web change.coverage-lib: N/A, nolib/change.test/ci/test_supervise_chrome_test.py: 21 OK inpython:3.12-slim; manual closed fd 0/1/2/1+2/all OK.litert_lm_library_smoke_test: +61; real macOS arm64 smoke run RESULT exit 0.pub get,analyze --fatal-infos,pub downgrade,flutter test+51 (non-root).Matrix Evidence
high-risk-exact-head-independent-qaunverifiedPrerequisites, expected locally)Review Notes
6430609a437f499b8c8807f4af4e39c22018d426, zero blocking findings.6430609a437f499b8c8807f4af4e39c22018d426.mainhas since moved to50d897054(#1829, #1826); no file overlap andgit merge-treeis clean. Evidence is bound to merge base9f532720b.High-risk regression review
reserve_standard_descriptorscall failstest_closed_stdout_cannot_redirect_the_echo_into_events; dropping themacosArm64line fails the macOS smoke cases6430609a437f499b8c8807f4af4e39c22018d426/9f532720b9de18f263e492ef1c049cc1abfd0ae8(merge base)high_risk_readiness.dartrun exits 2 (unverifiedPrerequisites), as expected for a local run.