Skip to content

Fix multi-line native pin changelog replacement and stale model-store CI comment - #1818

Merged
leehack merged 1 commit into
mainfrom
sweep-1815-c
Nov 8, 2026
Merged

leehack merged 1 commit into
mainfrom
sweep-1815-c

Conversation

@leehack

@leehack leehack commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • update_core_changelog_native_pin now removes a whole hand-written - Updated the default llama.cpp native runtime pin to … bullet (non-indented continuation lines and trailing blank lines) without touching the next bullet or heading.
  • Corrects the stale comment above the model store "Publish dry-run" step in ci.yml.

Part of #1815; does not close it.

Production-readiness scope

  • User-facing scope: Maintainer release tooling only; no runtime change.
  • Supported platforms/paths: tool/native/sync_native_release_pins.py, CI comment.
  • Unsupported or intentionally unavailable paths: N/A
  • Out of scope / follow-ups: Remaining #1815 items.

Completeness checklist

  • Declared scope is fully implemented.
  • Unsupported platform/option combinations: N/A (no runtime behavior).
  • Public API docs/changelog: N/A (maintainer tooling, not user-observable).
  • Regression test added; verified failing on the old pattern before the fix.
  • Validation coverage registry: N/A (no public capability change).
  • Security/privacy: no secrets involved.
  • Follow-ups tracked in #1815.

PR type guidance

  • Bugfix PR: root cause: the old pattern (?:\n .*)* only consumed two-space-indented continuation lines, so other continuation lines and blank lines survived the replacement. Test test_replaces_a_hand_written_entry_with_unindented_continuation_lines fails on the old pattern (leftover b1 text) and passes now.

Test Plan

  • dart run tool/prepare_workspace.dart
  • dart format --output=none --set-exit-if-changed .
  • dart analyze
  • dart test -p vm -j 1 --exclude-tags local-only N/A locally: no lib/ change; test/unit/tooling/ run (only environmental pwsh-missing windows_registry_qualification_test failures)
  • dart test -p chrome --exclude-tags local-only N/A: no web/lib change
  • coverage-lib N/A: no lib/ change
  • python3 -m unittest discover -s tool/native -p 'test_*.py': 190 OK (after prepare); python3 tool/native/test_sync_native_release_pins.py: 148 OK
  • python3 -m unittest discover -s test/ci -p test_select_jobs.py: 41 OK
  • TMPDIR=$(mktemp -d) dart test -p vm on test/unit/tooling/{companion_release_workflow_scripts,check_released_changelog_sections,classify_high_risk_changes,test_matrix,high_risk_readiness}_test.dart: +410 ~1, pass

Matrix Evidence

Matrix row Scope covered Platform / model / backend Result Evidence / notes
high-risk-exact-head-independent-qa Release tooling Python tests + tooling Dart tests macOS Pass Exact head 2150fcd; CI run 42520716719 success; N/A: no model/runtime path touched

Review Notes

  • Independent review status: PASS (fresh agent session, not the author), blocking-only, at exact head 2150fcd. Zero blocking findings, zero PR-caused P1, 0 review threads.
  • CI status / head SHA: 2150fcd, CI run 42520716719 success.
  • Base: merge base e8201c8. main has since moved to 60c8fe3 (#1816); its ci.yml change does not overlap this PR's comment-only hunk and git merge-tree with origin/main is clean.
  • Readiness evidence (v2, surfaces artifactConsumer, regressionPolicy): tool/testing/high_risk_readiness.dart exits 2 (unverifiedPrerequisites), the expected result for a valid local run.

High-risk regression review

  • Classification: high-risk (artifactConsumer, regressionPolicy)
  • Implementation task: this PR
  • Independent blocking QA task: fresh agent audit, PASS at exact head. Only caller update_llama_cpp_project_docs (sync_native_release_pins.py:4655) edits root CHANGELOG.md ## Unreleased only, run from workflow_dispatch sync_native_bindings.yml into a reviewable PR. Replay of old vs new pattern over all 2,211 historical changelog blobs: 0 content diffs, 0 released-section changes, 111 blank-line-only improvements; no catastrophic backtracking. Mutation: restoring main's old pattern fails the new test.
  • Exact head / current base: 2150fcd / merge base e8201c8 (main at 60c8fe3, merge-tree clean)
  • Production-branch deletion, bypass, or miswire proof: N/A (tooling-only)
  • Affected-family real-model/artifact evidence: N/A (no model family affected)
  • Explicit unavailable-family or other N/A evidence: N/A
  • Known PR-caused P1 regressions: 0
  • Unresolved review threads: 0

@leehack
leehack marked this pull request as ready for review November 8, 2026 21:25
@leehack
leehack merged commit ab2ead0 into main Nov 8, 2026
43 checks passed
@leehack
leehack deleted the sweep-1815-c branch November 8, 2026 21:26
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Chat app preview removed for leehack/llamadart-chat-pr-1818.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant