Repository navigation
feat(settings): OPDS sharing pane - #150
Closed
phildenhoff wants to merge 1 commit into
Closed
phildenhoff wants to merge 1 commit into
phildenhoff wants to merge 1 commit into
Conversation
phildenhoff
added this pull request to stack #156
September 18, 2026 00:24
This was referenced Sep 18, 2026
libcalibre Test Coverage ReportOverall coverage: 79.96% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-6-sharing-ui
branch
from
September 18, 2026 03:16
b738365 to
a8dd64c
Compare
libcalibre Test Coverage ReportOverall coverage: 79.96% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 79.96% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-6-sharing-ui
branch
from
September 18, 2026 17:11
a8dd64c to
a0d938f
Compare
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-6-sharing-ui
branch
from
September 18, 2026 18:26
a0d938f to
ec35a33
Compare
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-6-sharing-ui
branch
from
September 18, 2026 22:05
ec35a33 to
0a95bac
Compare
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-6-sharing-ui
branch
from
September 19, 2026 06:50
0a95bac to
df61468
Compare
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend layers can serve feeds, plan binds, and check passwords, but until now the only way to use any of it was curl. This adds the Sharing pane: start/stop, interface picking, and credential management, plus the settings plumbing underneath.
What changed
SharingSettingspane in Settings: lifecycle state, port, interface picker (with an explicit note when the selected interface is unavailable — the service waits rather than widening, per feat(opds): sharing service lifecycle and Tauri commands #148), and credential generate / configure / clear.use-opds-sharinghook, not the component.supportsLocalOpdsServer) so the web build degrades cleanly instead of rendering a pane that can't work.Validation
Unit tests in the diff cover the sharing service layer, settings migration, and the settings store; full workspace suite (348 tests) green at the stack tip, including 62 citadel-opds tests on the Rust side.
Part of the OPDS v1 stack (builds on #146 → #147 → #148 → #149 below; the stack continues above).