Repository navigation
feat(opds): HTTP Basic auth and credential management - #149
Closed
phildenhoff wants to merge 2 commits into
Closed
phildenhoff wants to merge 2 commits into
phildenhoff wants to merge 2 commits into
Conversation
phildenhoff
added this pull request to stack #156
September 18, 2026 00:24
phildenhoff
changed the title
This was referenced Sep 18, 2026
libcalibre Test Coverage ReportOverall coverage: 79.96% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-5-auth
branch
from
September 18, 2026 03:16
72e7d08 to
4859d1f
Compare
libcalibre Test Coverage ReportOverall coverage: 79.96% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 79.96% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-5-auth
branch
from
September 18, 2026 17:11
4859d1f to
ce5fcd9
Compare
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-5-auth
branch
from
September 18, 2026 18:26
ce5fcd9 to
30a520e
Compare
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-5-auth
branch
from
September 18, 2026 22:05
30a520e to
a8d111d
Compare
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-5-auth
branch
from
September 19, 2026 06:50
a8d111d to
6bd55d2
Compare
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sharing your whole book library onto the LAN needs at least a door latch, and Basic auth is what readers like KOReader actually speak. The failure modes are well known — plaintext compares, world-readable credential files, wall-clock leaks that reveal whether a username exists — so this layer does the boring version right.
What changed
Honest limitation: it's still Basic auth over plain HTTP, so credentials cross the wire base64-visible. Fine as a home-LAN latch; TLS is a separate conversation.
Validation
Covered by auth and credential-store tests in the diff (challenge behavior, cache opacity and boundedness, padding of unknown-user and cached rejections); full workspace suite (348 tests) green at the stack tip, including 62 citadel-opds tests.
Part of the OPDS v1 stack (above #146 → #147 → #148; #150 → #151 → #152 → #153 → #154 → #155 build on top).