Repository navigation
feat(opds): sharing service lifecycle and Tauri commands - #148
Merged
Merged
Conversation
phildenhoff
added this pull request to stack #156
September 18, 2026 00:24
phildenhoff
changed the title
This was referenced Sep 18, 2026
libcalibre Test Coverage ReportOverall coverage: 79.96% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-4-service
branch
from
September 18, 2026 03:16
3c3eed2 to
c0b23c7
Compare
libcalibre Test Coverage ReportOverall coverage: 79.96% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 79.96% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-4-service
branch
from
September 18, 2026 17:11
c0b23c7 to
182f664
Compare
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-4-service
branch
from
September 18, 2026 18:26
182f664 to
b1117c0
Compare
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-4-service
branch
from
September 18, 2026 22:05
b1117c0 to
22dc8b0
Compare
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-4-service
branch
from
September 19, 2026 06:50
22dc8b0 to
c521667
Compare
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-4-service
branch
from
September 19, 2026 07:18
c521667 to
3c12bce
Compare
phildenhoff
marked this pull request as ready for review
September 19, 2026 07:19
libcalibre Test Coverage ReportOverall coverage: 80.16% Coverage breakdown available in the artifacts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting a server is the easy part. The actual problem is a laptop whose networks come and go: if you pick your Wi-Fi interface and then leave the house, sharing must fail closed — wait for that interface to return, never quietly widen to every interface on the machine.
What changed
service.rs: start/stop lifecycle with a monitor loop that re-reconciles the listener set against a fresh interface snapshot every 2 seconds.Waiting— the scope only ever narrows.OpdsLifecycleState,OpdsErrorCode) shaped for the UI, plus Tauri commands, shared state, and regenerated TS bindings.The monitor is a poll rather than an OS event subscription. At a 2s interval that's a deliberate simplicity trade — it needs to be right, not instant.
Validation
Covered by service tests in the diff; full workspace suite (348 tests) green at the stack tip, including 62 citadel-opds tests.
Part of the OPDS v1 stack (above #146 → #147; #149 → #150 → #151 → #152 → #153 → #154 → #155 build on top).