Repository navigation
feat(headset): back up settings and calibration across reinstalls - #14
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3bd5cb63c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 370b6b73b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Keep tracking shutdown bounded when termination or output draining fails, and report when a tracking process remains alive after cleanup. Handle Windows adapter-enumeration errors during OSC discovery, and stop lipsync status and meter timers immediately on navigation or window closure. For an unreadable headset backup, preserve the archive and show localized instructions for moving it aside before retrying with defaults. Preserve specific wrong-headset guidance during fresh installs. These changes address late findings on #11, #12, and #14 and reuse the existing timer and error paths. Validation: Windows Release build; bounded process shutdown, output-drain and log-retention checks; incomplete-shutdown status; WPF rapid-navigation and missing-microphone tests; existing lipsync checks; twelve backup/restore tests including corrupt-archive recovery and wrong-device guidance; localization and source checks.
Removing QFT+ Headset through Windows now backs up its settings and calibration to
%LOCALAPPDATA%\QFTPlus\headset-backups. Reinstalling through the same PC restores them for that headset. Uninstall keeps these backups.Validation: Windows app build; Quest app compile; native and Python syntax checks; resource validator and its tests. Merges cleanly with the other four PRs from this split in any order.