Repository navigation
feat(lipsync): add voice-driven visemes with vrchat osc discovery and headset mic - #12
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 11
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 392bb7659e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebb2416457
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Keep tracking shutdown bounded when termination or output draining fails, and report when a tracking process remains alive after cleanup. Handle Windows adapter-enumeration errors during OSC discovery, and stop lipsync status and meter timers immediately on navigation or window closure. For an unreadable headset backup, preserve the archive and show localized instructions for moving it aside before retrying with defaults. Preserve specific wrong-headset guidance during fresh installs. These changes address late findings on #11, #12, and #14 and reuse the existing timer and error paths. Validation: Windows Release build; bounded process shutdown, output-drain and log-retention checks; incomplete-shutdown status; WPF rapid-navigation and missing-microphone tests; existing lipsync checks; twelve backup/restore tests including corrupt-archive recovery and wrong-device guidance; localization and source checks.
Adds voice-driven lip sync. Studio runs the selected microphone, or the headset microphone, through OVR LipSync on this PC and sends visemes to VRChat over OSC using VRCFaceTracking parameter names. VRChat OSCQuery discovery reports which avatar parameters exist.
Studio gets a Lip sync page with Mouth shapes, Sound and VRChat sub-pages, a back button for sub-pages, and a Lip sync row on the Tracking page. Studio reopens on the last page used.
Validation: Windows app build; Quest app compile; native and Python syntax checks; resource validator and its tests. Merges cleanly with the other four PRs from this split in any order.
Summary by CodeRabbit