Repository navigation
Retry an action's input fetch on the worker after a transient store failure - #2932
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amankrx
force-pushed
the
fix/worker-prepare-retry
branch
from
October 13, 2026 14:15
bbc3550 to
c3a5a1f
Compare
corcillo
reviewed
Oct 13, 2026
corcillo
reviewed
Oct 13, 2026
corcillo
reviewed
Oct 13, 2026
corcillo
reviewed
Oct 13, 2026
corcillo
reviewed
Oct 13, 2026
corcillo
previously approved these changes
Oct 13, 2026
Collaborator
|
Separate from this PR, but this adds a call site: |
…on timeout to the scheduler, and settle every retried fetch on one outcome
amankrx
force-pushed
the
fix/worker-prepare-retry
branch
from
October 13, 2026 16:50
fbc5533 to
a6d7b4f
Compare
corcillo
approved these changes
Oct 13, 2026
corcillo
previously approved these changes
Oct 13, 2026
corcillo
approved these changes
Oct 13, 2026
This was referenced Oct 13, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A worker that fails an input fetch hands the action back, and the scheduler sends it to another worker to fetch the same inputs from the same store. Against an object store answering 503 for minutes, one customer's workers failed 788,690 fetches in 18 hours that way, each spending a scheduler retry on a store that would not answer anyone.
The worker now fetches the Command and the input tree again itself after a transient store error, from an empty work directory, pausing 1 s doubling to 30 s, while
max_download_timeout_sleaves room for another attempt or the action's own timeout when shorter. The scheduler is not told; its ceilings still bound the action, and themax_download_timeout_sdoc says to stay below them. Only store failures are retried: an error the worker's own OS raised (full disk, link limit, read-only mount) hands the action back to land on a healthy worker. Counterworker.prepare.retries{outcome}:retriedper attempt, then one ofrecovered,exhausted,failed,abandoned.How was this verified?
Tests under paused time: recovery after 1 s and 2 s; a partly built tree cleared and restaged; a store that never recovers stopping at the download deadline and at a shorter action timeout; a kill during the pause. Unit tests cover the classifier, OS errors and the outcome tally. Worker suite and clippy pass.
Risk
Low. A permanent store error still fails at once; a transient one costs the worker slot up to the window instead of a scheduler retry.
AI assistance
An agent drafted the change and I reviewed every line.