Repository navigation
Record the input fetch retry outcome under a prefixed attribute - #2935
Merged
amankrx merged 3 commits intoOct 13, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
corcillo
reviewed
Oct 13, 2026
| pub const SCHEDULER_MATCH_RESULT: &str = "scheduler.match.result"; | ||
| /// The platform properties no worker could satisfy, comma separated. | ||
| pub const SCHEDULER_UNSATISFIABLE_PROPERTIES: &str = "scheduler.unsatisfiable.properties"; | ||
| pub const WORKER_PREPARE_OUTCOME: &str = "worker.prepare.outcome"; |
Collaborator
There was a problem hiding this comment.
+1 on the convention. A few other unreleased labels are still bare, though, and since none of them has shipped yet, renaming them now costs nothing:
| Metric | Current label | Suggested |
|---|---|---|
worker.input.relinks (#2926) |
kind |
worker.relink.kind |
store.object.throttles (#2931) |
provider, op |
store.object.provider, store.object.operation |
scheduler.queue.age, scheduler.executing.age (#2929) |
age |
scheduler.action.age |
corcillo
previously approved these changes
Oct 13, 2026
corcillo
approved these changes
Oct 13, 2026
corcillo
approved these changes
Oct 13, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
#2932 recorded the outcome of a worker's input fetch retry under a bare
outcomeattribute, while every other NativeLink attribute is prefixed by its subject (scheduler.match.result,worker.disconnect.reason,execution.result), which is also what dashboards and alert rules key on once the collector turns the dots into underscores. The chart's alert on this counter was about to carry the only unprefixed label in the file.The key is now
worker.prepare.outcome, a constant beside the others. Nothing is released with the old name yet.How was this verified?
The metrics reference regenerates with the attribute under the worker group; nativelink-util tests and clippy for util and worker pass.
Risk
None in a release: the counter has not shipped. A dashboard built against a main build since #2932 would need the label renamed.
AI assistance
An agent drafted the change and I reviewed every line.