Repository navigation
ci(release): publish with the English README on the npm page, 0.24.3 - #65
Merged
Merged
Conversation
npm takes the package page's readme from the package directory, not from
the tarball: @npmcli/package-json globs {README,README.*} and keeps the
first .md it sees, and with README.md and README.ru.md side by side it
picks README.ru.md, on macOS and on the runner alike. So every release
since 0.23.4, when the Russian README was added, put Russian on the npm
page (`npm view @surdeddd/[email protected] readmeFilename` gives
README.ru.md). The file is not in "files" either, so the workflow drops
it from the checkout before packing.
From the Visual baselines (linux) workflow run on this branch; only the seven hero snapshots, which print the version.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle size report (gzip, threshold 5%)
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The release workflow deletes
README.ru.mdfrom its checkout before it packs and publishes, so the npm page shows the English README. Released as 0.24.3. No code or documentation in the package changes, andREADME.ru.mdstays in the repository.Why
The npm page has been in Russian since 0.23.4, the release that added
README.ru.md:npm publishtakes the readme from the package directory, not from the tarball.@npmcli/package-jsonglobs{README,README.*}and keeps the first.mdit finds; withREADME.mdandREADME.ru.mdside by side that isREADME.ru.md. Thefileslist does not take part in that choice.Checked with the module npm itself uses (
@npmcli/package-jsonfrom npm 11.20.0,normalizewith thereadmestep): with both files present it picksREADME.ru.md; withREADME.ru.mdremoved it picksREADME.md.Verification
npx tsc --noEmit: clean (pre-commit hook)npx vitest run: 100 files, 1040 passed, 2 skippednpx playwright test: visual projects 21 of 21 after regenerating the hero baselines, which print the version (darwin here, linux fromVisual baselines (linux))npm run docs:check: 39 files OKrelease.ymlparsesnpm view @surdeddd/bottom-sheet readmeFilenameChecklist
src/ordemo/docs/andCHANGELOG.md: no API change; CHANGELOG has the entrysrc/styles/bottom-sheet.css? No