Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added three integration methods #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Added three integration methods #49
Changes from all commits
a0693a7a6d7b634dbc4e9File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 47 in include/sdu_controllers/integrator/integrator.hpp
Reduce verbosity with "using enum" for "sdu_controllers::integrator::IntegrationMethod".
Check warning on line 50 in include/sdu_controllers/integrator/integrator.hpp
Remove the commented out code.
Check warning on line 55 in include/sdu_controllers/integrator/integrator.hpp
Remove the commented out code.
Check warning on line 60 in include/sdu_controllers/integrator/integrator.hpp
Remove the commented out code.
Check warning on line 56 in python/sdu_controllers/__init__.py
Rename this parameter "Ki" to match the regular expression ^[_a-z][a-z0-9_]*$.
Check warning on line 56 in python/sdu_controllers/__init__.py
Rename this parameter "Kd" to match the regular expression ^[_a-z][a-z0-9_]*$.
Check warning on line 56 in python/sdu_controllers/__init__.py
Rename this parameter "N" to match the regular expression ^[_a-z][a-z0-9_]*$.
Check warning on line 56 in python/sdu_controllers/__init__.py
Rename this parameter "Kp" to match the regular expression ^[_a-z][a-z0-9_]*$.
Check warning on line 19 in python/sdu_controllers/_integrator.cpp
Use std::format instead of concatenating pieces manually.
Check warning on line 26 in python/sdu_controllers/_integrator.cpp
Use the value returned from "def".
Check warning on line 35 in python/sdu_controllers/_integrator.cpp
Reduce verbosity with "using enum" for "sdu_controllers::integrator::IntegrationMethod".
Check warning on line 42 in python/sdu_controllers/_integrator.cpp
Use the value returned from "value".
Check warning on line 36 in src/controllers/admittance_controller_position.cpp
Remove the misleading "//" characters.
Check warning on line 39 in src/controllers/admittance_controller_position.cpp
Remove the misleading "//" characters.
Check warning on line 42 in src/controllers/admittance_controller_position.cpp
Remove the commented out code.
Check failure on line 46 in src/controllers/admittance_controller_position.cpp
Explicitly capture "input_force" in a non-transient lambda.
Check failure on line 46 in src/controllers/admittance_controller_position.cpp
Explicitly capture "this" in a non-transient lambda.
Uh oh!
There was an error while loading. Please reload this page.