Repository navigation
refactor(ui): menus on QueryaMenuButton, Execute as a QueryaSplitButton - #1425
Merged
Merged
Conversation
Replace QueryaActionMenu and its shadcn OutlineButton trigger: the ERD export and views menus, the chart export, the SQL session menu and ExportMenuButton become QueryaMenuButton, and Execute + its run menu become one QueryaSplitButton (keys run_script / run_menu kept on the halves). The widget goes; QueryaActionMenuItem stays. QueryaSplitButton gains compact and per-half keys. Both files leave the shadcn allow-list. Part of #1335 and #1337.
github-actions
Bot
added
enhancement
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1335 / #1337 (closes neither). Uses the compositions from #1417.
What
QueryaActionMenu(a shadcnOutlineButtontrigger around an arbitrary child) is gone; its six call sites use the kit components:QueryaSplitButton<bool>(main half keyrun_script, chevron keyrun_menu)QueryaMenuButton(enabled: !session.running, icon only when compact)QueryaMenuButton(keyserd_export,erd_viewskept)QueryaMenuButton(ghost,sm, keychart_export)ExportMenuButton(results, extension toolbar)QueryaMenuButton(sm)QueryaActionMenuItemstays (same file, no shadcn import) and is exported fromwidgets.dart.QueryaSplitButtongetscompactand per-half keys (mainKey,menuKey) so tests and shortcuts can target a half.querya_action_menu.dartandexport_menu_button.dartleave the shadcn allow-list.Visible differences (intended)
Tests
Existing tests tap these controls by key (
run_script,session_menu,erd_export,erd_views,chart_export) and by menu item text; the keys are on the same tappable targets, so no test change was needed. No test usedQueryaActionMenudirectly.Not run locally; CI is the check.