Repository navigation
fix(ui): export and copy menu buttons have one chevron - #1437
Merged
Merged
Conversation
QueryaMenuButton draws its own chevron, so the literal '▾' in the labels of ExportMenuButton callers showed two. The labels are plain text again; the tests that found 'Export ▾' and 'Save File ▾' look for the plain labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #1425, found while driving a build of `dev`: Export ▾ ⌄ and Save File ▾ ⌄ showed two chevrons.
`QueryaMenuButton` draws its own chevron, so the literal `▾` in the labels passed by `ExportMenuButton` callers (results tab, extension table toolbar) is removed. The two tests that found `Export ▾` / `Save File ▾` look for the plain labels.
Not run locally; CI is the check.