robomimic-v1: the state-only variants (square, lift, can, transport) build - #13
Merged
Merged
Conversation
…builds - camera_names is optional, and image observations are on only with cameras
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
robomimic-v1ships eight metadata files, but only the four-imgones could be built.square,lift,canandtransportcarry nocamera_names, andRobomimicEnvread that key unconditionally, so each died withKeyError: 'camera_names'. The docs audit flagged it, and running it on guangzhao confirmed it. Every experiment used-imgnames, so nothing here had hit it.The fix reads
camera_nameswith an empty default. It also turns image observations on only when there are cameras. Turning them on with none would have robosuite add its defaultagentviewimage, andprepare_obswould have put it among the states. Theagentviewframe is rendered separately, as before, so every variant still has it.Checked on guangzhao, in the robomimic environment E27, E34 and E40 ran in (robomimic 0.4.0, robosuite 1.4.1, MuJoCo 2.3.7):
squareKeyError: 'camera_names'agentview; 11 state keysliftKeyErrorcanKeyErrortransportKeyErroragentview; both robots' state keyssquare-imgagentview,robot0_eye_in_hand; the same 11 state keysCI does not install robomimic, so no test here can build the env. The table is the check.