Repository navigation
Conversation
antiguru
force-pushed
the
mh/dd-next-vendored-agent
branch
from
November 6, 2026 03:11
7074bd8 to
e76cd28
Compare
antiguru
force-pushed
the
mh/dd-next-vendored-agent
branch
from
November 7, 2026 03:35
e76cd28 to
67928ad
Compare
…race agent Copy differential's TraceAgent, TraceWriter, arrange_core and reduce_with_tactic (with reduce_trace) into mz_timely_util::arrange_agent, taken from differential-dataflow revision 6074cc78, whose copied sources the 0.26.0 release the workspace depends on ships unchanged. The drivers take a factory that builds the agent and writer, behind local Writer and Agent traits shaped after differential issue #959, and TraceAgent::factory builds them exactly as upstream does. The copies are run through rustfmt and mark every deviation with a "Not upstream" comment, so a later bump can re-derive them by diffing against a rustfmt-formatted upstream. They carry mz-timely-util's Apache 2.0 header next to the MIT attribution. Compute's arrangements, reductions and imports now go through the copies. Behavior is unchanged. Storage stays on differential's TraceAgent. Co-Authored-By: Claude Opus 5.5 <[email protected]>
antiguru
force-pushed
the
mh/dd-next-vendored-agent
branch
from
November 7, 2026 07:51
67928ad to
e2273c4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 of 14 in the interactive-runtime stack, which supersedes #37770. Followed by #40513. The design document is
doc/developer/design/20261107_interactive_runtime.mdin #40559.Compute's arrangements, reduces and imports now go through copies of differential's
TraceAgent,TraceWriterand the two drivers that construct an agent, inmz_timely_util::arrange_agent. Behavior is unchanged. The interactive runtime needs to own the agent and writer so a second runtime can share an arrangement, and copying them lets that work proceed without a differential change. The copies come from differential revision 6074cc78, which the 0.26.0 release the workspace depends on ships unchanged.agent.rsandwriter.rscopyoperators/arrange/agent.rsandwriter.rs, includingTraceBox.TraceReplayInstruction,ShutdownButton,Arrangedand the frontier wrappers stay differential's.arrangement.rsandreduce.rscopyarrange_coreandreduce_with_tacticasarrange_core_withandreduce_with_tactic_with, which build their agent through a factory.reduce_trace_withuses differential's publicCursorTactic.clippy.tomldisallows callingarrange_core_withandreduce_trace_withdirectly, as it does their differential originals.arrange_agent.rsholds theWriter,AgentandArrangeContexttraits, with the shape proposed in Let arranging operators take a caller-chosen agent and writer TimelyDataflow/differential-dataflow#959, andTraceAgent::factory(). Copying alone would give compute the agent. The factory and traits exist so the operator copies can go once differential takes coord: merge transient and coordinator modules #959. Until thenTraceAgent::factory()is the only factory, and compute: a shared-trace primitive for cross-thread arrangement reads #38386 adds publishing by editing the copied agent and writer in place.Not upstream, so a differential bump can re-derive them by diffing against the rustfmt-formatted revision named in each header. They carry mz-timely-util's Apache 2.0 header next to the MIT attribution.TraceAgent.A reviewer should check that every difference from the named upstream revision carries a
Not upstreammarker.Posted by Claude Code.
🤖 Generated with Claude Code