Repository navigation
Conversation
…race agent Copy differential's TraceAgent, TraceWriter, arrange_core and reduce_with_tactic (with reduce_trace) into mz_timely_util::arrange_agent, taken from the differential-dataflow revision the workspace pins. The drivers take a factory that builds the agent and writer, behind local Writer and Agent traits shaped after differential issue MaterializeInc#959, and TraceAgent::factory builds them exactly as upstream does. The copies keep upstream's formatting and mark every deviation with a "Not upstream" comment, so a later bump can re-derive them by diffing against upstream. Compute's arrangements, reductions and imports now go through the copies. Behavior is unchanged. Storage stays on differential's TraceAgent. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Member
Author
|
Superseded by #40512, the same commit from a branch in this repository so the interactive stack can use it as a base. Posted by Claude Code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute's arrangements, reduces and imports now go through copies of differential master-next's
TraceAgent,TraceWriterand the two drivers that construct an agent, inmz_timely_util::arrange_agent. Behavior is unchanged. The interactive runtime needs to own the agent and writer so a second runtime can share an arrangement, and copying them lets that work proceed without a differential change. This builds on the master-next port (#38805) and is the base the interactive stack rebases onto.agent.rsandwriter.rscopyoperators/arrange/agent.rsandwriter.rs, includingTraceBox.TraceReplayInstruction,ShutdownButton,Arrangedand the frontier wrappers stay differential's.arrangement.rsandreduce.rscopyarrange_coreandreduce_with_tacticasarrange_core_withandreduce_with_tactic_with, which build their agent through a factory.reduce_trace_withuses differential's publicCursorTactic.arrange_agent.rsholds theWriter,AgentandArrangeContexttraits, with the shape proposed in Let arranging operators take a caller-chosen agent and writer TimelyDataflow/differential-dataflow#959, andTraceAgent::factory().#[rustfmt::skip]and mark each deviationNot upstream, so a differential bump can re-derive them by diffing against the revision named in each header.TraceAgent.Posted by Claude Code.
🤖 Generated with Claude Code