Repository navigation
Conversation
Arranging operators now return `SharedAgent`, a Materialize-owned trace handle whose trace can be published to readers on other threads, in place of differential's `TraceAgent` over a `SharedSpine` wrapper. Differential 0.25.1 has no way for a caller to choose the agent an arranging operator builds, so `mz_timely_util::arrange_agent` carries copies of `arrange_core` and the `reduce_with_tactic` driver that take an agent factory, plus the private cursor reduce tactic they need. The copies deviate from upstream only in agent construction, and in rebuilding the private `ValueHistory::replay_key` from public API. Compute's arrange and reduce wrappers, typedefs, the trace manager, and the shared-trace glue move to the new agent. Storage keeps using differential's operators and `TraceAgent`. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
…red reduce Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arranging operators now return Materialize's own
SharedAgentand feed its writer directly. The shared trace no longer wraps every spine inSharedSpineor reaches into differential'sTraceBox. Differential'sarrange_coreandreduce_with_tacticconstruct aTraceAgentinternally, so they cannot return a caller-chosen agent. This PR copies the three operators that build the agent intomz_timely_util::arrange_agentand builds against stock differential-dataflow 0.25.1, with no patch entry and no lockfile change.The copies keep the signatures proposed upstream in TimelyDataflow/differential-dataflow#959: a
Writerand anAgenttrait, and anArrangeContextfactory passed toarrange_core_withandreduce_trace_with. If differential adopts that shape, the copies can be deleted and the callers switch back. #39989 is the same port against a patched differential, and serves as the reference for the upstream ask.arrangement.rscopiesarrange_core.reduce.rscopies thereduce_with_tacticdriver. Both change only where they build the trace and agent.reduce/cursors.rscopiesCursorTactic, which 0.25.1 keeps private. In 0.25.1 theValueHistory::replay_keymethod it calls is private too, so the copy rebuilds it from the publicload_iterwith a per-history scratch buffer. Differential master-next exportsCursorTacticitself, so the master-next port (deps: update differential-dataflow to 0.26 and timely to 0.32 #38805) can drop this file and the rebuild with it.SharedAgent::import_frontier_corereplays the shared agent into another scope on the same worker.clippy.tomldisallows the vendored entry points outside the compute wrappers.Each copied file names its upstream file and revision, so a differential bump can re-derive it by diffing.
Posted by Claude Code.
🤖 Generated with Claude Code