Repository navigation
Say the Aqua pin is lifted - #21
Merged
Merged
Conversation
Compat only. No package code changes. Aqua 0.8.18, released 2026-09-18, fixes the persistent_tasks bug the pin in PR #16 worked around: its release notes say test_persistent_tasks "no longer errors on a weak dependency that is also listed in [deps] but not installed", which is exactly the ChainRulesCore-behind-AbstractFFTs case here. Project.toml already reads Aqua = "0.8" -- CompatHelper's PR #19 merged that change to main without a CHANGELOG entry. This closes that gap. Pkg.test() confirms: Aqua resolves to 0.8.18, persistent_tasks passes, and the full suite (65 968 tests) is green. Co-Authored-By: Claude Sonnet 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Project.tomlneeds no change: CompatHelper's CompatHelper: bump compat for Aqua in [extras] to 0.8, (keep existing compat) #19 already mergedAqua = "0.8"tomain, but without a CHANGELOG entry explaining why that was safe.ChainRulesCorebehindAbstractFFTs) no longer stopstest_persistent_tasks's manifest walk.Test plan
Pkg.test()onmain(post-CompatHelper: bump compat for Aqua in [extras] to 0.8, (keep existing compat) #19): Aqua resolves to 0.8.18,persistent_taskspasses, full suite (65,968 tests) green.🤖 Generated with Claude Code